Maniphest T401587

Drop User::getGlobalBlock and User::isBlockedGlobally
Closed, ResolvedPublic0.1 Estimated Story Points
Actions

Description

Summary

Both User::isBlockedGlobally and User::getGlobalBlock are hard deprecated and per the stable interface policy they can be removed.

Background & Technical notes

T387574: Hard deprecate User::getGlobalBlock hard deprecated User::getGlobalBlock in 1.44 and 94acff644ad5354a449eeeae5786bf592b883190 hard deprecated User::isBlockedGlobally in 1.43
- The UserIsBlockedGlobally hook which both of these rely on is currently soft deprecated, however, the hook is only called by these two hard-deprecated methods (so this hook can also be safely hard deprecated)
This task focuses on removing User::isBlockedGlobally and User::getGlobalBlock. Removing the hook these methods rely on can be done in a different ticket.

Acceptance criteria

User::isBlockedGlobally and User::getGlobalBlock are removed

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Drop User::isBlockedGlobally and User::getGlobalBlock	Dreamy Jazz	mediawiki/core	master	+2 -52

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T277511 Drop hard-deprecated User methods once they've been hard-deprecated in at least once release
		Resolved		Dreamy_Jazz	T401594 Remove the UserIsBlockedGlobally hook
		Resolved		Dreamy_Jazz	T401587 Drop User::getGlobalBlock and User::isBlockedGlobally
		Resolved		Dreamy_Jazz	T401591 Hard deprecate the UserIsBlockedGlobally hook

Event Timeline

Dreamy_Jazz created this task.Aug 11 2025, 1:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2025, 1:51 PM

Dreamy_Jazz added a project: Trust and Safety Product Sprint.Aug 11 2025, 1:51 PM

Dreamy_Jazz moved this task from Backlog to Maintenance to triage on the Trust and Safety Product Sprint board.

Dreamy_Jazz mentioned this in T401594: Remove the UserIsBlockedGlobally hook.Aug 11 2025, 2:02 PM

Dreamy_Jazz added a parent task: T401594: Remove the UserIsBlockedGlobally hook.

Dreamy_Jazz added a parent task: T274211: Finish hard-deprecation and removal of User methods depecated prior to MW 1.36.

Dreamy_Jazz edited parent tasks, added: T277511: Drop hard-deprecated User methods once they've been hard-deprecated in at least once release; removed: T274211: Finish hard-deprecation and removal of User methods depecated prior to MW 1.36.Aug 11 2025, 2:05 PM

Dreamy_Jazz moved this task from Untriaged to 2023+ | MW 1.40+ on the Technical-Debt (Deprecation process) board.

Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Aug 11 2025, 2:09 PM

Dreamy_Jazz set the point value for this task to 0.1.

OKryva-WMF added a project: Essential-Work.Aug 13 2025, 3:29 PM

OKryva-WMF triaged this task as Medium priority.Aug 19 2025, 10:39 AM

OKryva-WMF edited projects, added: Trust and Safety Product Sprint (Sprint Princess Tarta (August 18 - September 5)); removed: Trust and Safety Product Sprint.

OKryva-WMF moved this task from Priority Backlog to Maintenance Ready on the Trust and Safety Product Sprint (Sprint Princess Tarta (August 18 - September 5)) board.

OKryva-WMF moved this task from Maintenance Ready to Priority Backlog on the Trust and Safety Product Sprint (Sprint Princess Tarta (August 18 - September 5)) board.Aug 19 2025, 10:52 AM

Dreamy_Jazz claimed this task.Aug 21 2025, 8:40 AM

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Princess Tarta (August 18 - September 5)) board.

Change #1180821 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Drop User::isBlockedGlobally and User::getGlobalBlock

https://gerrit.wikimedia.org/r/1180821

gerritbot added a project: Patch-For-Review.Aug 21 2025, 8:57 AM

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Princess Tarta (August 18 - September 5)) board.Aug 21 2025, 9:00 AM

Dreamy_Jazz closed subtask T401591: Hard deprecate the UserIsBlockedGlobally hook as Resolved.Aug 21 2025, 10:33 AM

Patch has been +2'd (thanks for the quick review) + no need for QA = resolving

Change #1180821 merged by jenkins-bot:

[mediawiki/core@master] Drop User::isBlockedGlobally and User::getGlobalBlock

https://gerrit.wikimedia.org/r/1180821

Maintenance_bot removed a project: Patch-For-Review.Aug 21 2025, 3:31 PM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.16; 2025-08-26).Aug 21 2025, 4:00 PM

Dreamy_Jazz mentioned this in T319069: Remove global-blocks-specific methods and hook from User class.Oct 3 2025, 3:36 PM