Page MenuHomePhabricator

Hard deprecate the UserIsBlockedGlobally hook
Closed, ResolvedPublic0.25 Estimated Story Points

Description

Summary

The UserIsBlockedGlobally hook is currently soft deprecated and per the stable interface policy the hook can now be hard deprecated

Background & Technical notes

  • T387574: Hard deprecate User::getGlobalBlock hard deprecated User::getGlobalBlock in 1.44 and 94acff644ad5354a449eeeae5786bf592b883190 hard deprecated User::isBlockedGlobally in 1.43
    • The UserIsBlockedGlobally hook is only run by the above hard-deprecated methods, though is implemented by the GlobalBlocking extension
  • By hard-deprecating the UserIsBlockedGlobally hook we can then remove the methods that ran this hook (as hard deprecation allows us to make the code "act as no-ops instead of actually functioning"

Acceptance criteria

  • The UserIsBlockedGlobally hook is marked as hard deprecated

Event Timeline

Dreamy_Jazz set the point value for this task to 0.25.

Change #1180138 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Drop handling the UserIsBlockedGlobally hook

https://gerrit.wikimedia.org/r/1180138

Change #1180144 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Hard deprecate the UserIsBlockedGlobally hook

https://gerrit.wikimedia.org/r/1180144

Change #1180138 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Stop handling the UserIsBlockedGlobally hook

https://gerrit.wikimedia.org/r/1180138

Change #1180144 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate the UserIsBlockedGlobally hook

https://gerrit.wikimedia.org/r/1180144