Page MenuHomePhabricator

[SF] #autoedit error when user does not have edit permissions (ex: anonymous editing disabled)
Closed, ResolvedPublicBUG REPORT

Description

When a user does not have edit permissions, like anonymous editing is disabled with $wgGroupPermissions['*']['edit'] = false; in LocalSettings.php, #autoedit still attempts the edit and returns the following error:

Fatal error: Call to a member function setResponseCode() on a non-object in /usr/home/coin/public_html/w/extensions/SemanticForms/includes/SF_AutoeditAPI.php on line 63

#autoedit should probably be enhanced to make the link non-functional for disallowed editors, and should perhaps be enhanced to permit optional styling for the link to appear "grayed out" so it is somewhat apparent that it's an element that should work in different circumstances, similar to grayed out form elements. Another possible enhancement might be to allow alternative behavior or text to be specified when the user does not have edit permissions.


Version: unspecified
Severity: normal

Details

Reference
bz38171

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:55 AM
bzimport set Reference to bz38171.
Aklapper triaged this task as Low priority.Feb 4 2022, 8:07 PM
Aklapper changed the subtype of this task from "Task" to "Bug Report".
Yaron_Koren claimed this task.
Yaron_Koren subscribed.

I think this specific bug was fixed a long time ago; and in general, I would say the current handling of #autoedit for pages that the user can't edit is good enough.