tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/5390

@JTannerWMF @SChekfa-WMF

This build is accessible from the Staging build #96. Please let me know if you do not have access to this build in TestFlight and I will check your permissions.

Test steps:

1. Fresh install on Staging build, ensure your device region is set as US and app language is EN.
2. Log into app. Visit various articles to collect a good sample of category data.
3. Go to app Settings > Year in Review. Turn off toggle, then turn it back on to regenerate report.
4. Go to year in review from Profile. You should see a category slide with 5 categories.
5. Go to developer settings tool and flip toggle to limit category titles by 2+ underscores.
6. Repeat step 3-4. Confirm category slide has longer category titles (at least 2 spaces).

Screenshot:

Moving to design review for your feedback on the underscores logic. Thanks!

@JTannerWMF @SChekfa-WMF I just sent you an email invite on TestFlight to install the staging build - apologies for having to deal with a 3rd app but it is temporary until we have our new wikifeeds config deployed.

It looks like this:
{F65804262}

@Tsevener hi! i accepted the invitation and downloaded the new app, but i'm stuck at step 3 — i don't see an option for Year in Review in Profile show up (although if i go to developer settings i do see the config for 2+ underscores) — 

@SChekfa-WMF Whoops, sorry I think something is messed up with the build. I'll let you know when I have it fixed in a new one.

@SChekfa-WMF I have a new build kicked off, Staging build 97. Let me know if that works for you, thanks.

Thank you for fixing! I can see Year in Review now, but when I turn on the 2+ underscore developer config and open up Year in Review from Profile again, I’m seeing the same categories from before I turned on the config, some of which do not have at least two underscores:

Is this a caching issue, like maybe it’s just creating the YIR once and retaining the initial version I saw every time I revisit? @Tsevener

@SChekfa-WMF It is retaining the initial version - there was a product requirement last year to "freeze" the data after the first time it's generated. In order to re-generate the report, after you change the developer setting, go to Settings > Year in Review > toggle Off, then back On.

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/5390

@Tsevener that makes sense, thank you for explaining! i'm looking at this again, but for some reason i'm unable to see the underscore developer config anymore — is it no longer available because the task was closed? :

@SChekfa-WMF Check to make sure you are on Staging build 97. The build number is in parenthesis, and you might need to dig into a previous version number since these have been up between releases:

All of these design review builds are kicked off from different branches (pre-merge), so the latest Staging build might not have the same logic as an earlier one. That's why it could be missing from the latest Staging build.

thank you for explaining, this makes sense and I see that it's working as expected. i'll move this ticket over to code review.