Page MenuHomePhabricator
Create Task
Maniphest T401855

☂ PHP 8.3 issues found during WMF rollout
Closed, ResolvedPublic
Actions

Description

From https://wikitech.wikimedia.org/wiki/PHP_upgrade_process_for_MediaWiki#Test
  • Monitor and fix deprecation warnings as found in Logstash. Create a tracking task and routinely monitor Logstash for production errors that are PHP deprecations, create tasks for them, tag with #php_8.3_support, and attach them as child tasks under this tracking task.
  • Review existing tasks on the #php_8.3_support Phabricator board and make progress on those (either directly or by escalating to someone in/outside the team).

Tools:

On duty:

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT376276 PHP 8.4: Implicitly nullable parameter declarations deprecated
 OpenNoneT379587 PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs
 ResolvedReedyT378424 PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs
 OpenNoneT317255 PHP's getElementsByTagName is slow prior to PHP 8.3
 OpenNoneT358667 Drop PHP 8.2 support from MediaWiki
 OpenNoneT366644 Raise MediaWiki's MariaDB requirement to 10.6
 OpenNoneT366646 Raise Quibble jobs' tested version of MariaDB to 10.6
 DeclinedNoneT405346 Remove okvpn/clock-lts post WMF PHP 8.3 upgrade
 ResolvedReedyT405344 Upgrade web-auth/webauthn-lib to >= 5.2.3
 ResolvedKrinkleT358666 Drop PHP 8.1 support from MediaWiki
 ResolvedKrinkleT360995 Migrate Wikimedia production from PHP 8.1 to PHP 8.3
 ResolvedcscottT401855 ☂ PHP 8.3 issues found during WMF rollout
 ResolvedScott_FrenchT402424 PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /srv/monitoring/lib.php on line 99
 DuplicatePRODUCTION ERRORNoneT403514 Expectation (readQueryRows <= 10000) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: 12860)
 ResolvedPRODUCTION ERRORMichaelT407403 Error: Invalid serialization data for DatePeriod object
 ResolvedPRODUCTION ERRORMichaelT408852 PHP Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated
 ResolvedMichaelT401005 Investigate Production Errors from ComputedUserImpactLookup::getPageViewData
 DuplicatePRODUCTION ERRORNoneT409248 PHP Warning: Trying to access array offset on null

Event Timeline

Krinkle created this task.Aug 13 2025, 6:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2025, 6:20 PM
Krinkle added a parent task: T360995: Migrate Wikimedia production from PHP 8.1 to PHP 8.3.Aug 13 2025, 6:20 PM
Krinkle mentioned this in T360995: Migrate Wikimedia production from PHP 8.1 to PHP 8.3.
Krinkle moved this task from Backlog to Wikimedia production on the PHP 8.3 support board.Aug 13 2025, 6:23 PM
A_smart_kitten subscribed.Aug 13 2025, 7:59 PM
A_smart_kitten added a project: WMF-General-or-Unknown.Aug 13 2025, 8:03 PM
Scott_French mentioned this in T401254: Upgrade mw-debug/next to PHP 8.3.Aug 13 2025, 10:31 PM
Pppery subscribed.Aug 14 2025, 1:54 AM
MSantos moved this task from Inbox, needs triage to MW Release Working Group on the MediaWiki-Engineering board.Aug 14 2025, 9:02 AM
MSantos added subscribers: Arlolra, Atieno.
MSantos subscribed.Aug 14 2025, 9:07 AM
Jdforrester-WMF awarded a token.Aug 14 2025, 1:59 PM
ABreault-WMF edited subscribers, added: ABreault-WMF; removed: Arlolra.Aug 15 2025, 12:44 AM
MSantos added a project: OKR-Work.Aug 20 2025, 1:02 PM
MSantos added subscribers: SLopes-WMF, OWresch-WMF, • larissagaulia and 2 others.
Krinkle updated the task description. (Show Details)Aug 20 2025, 6:39 PM
Krinkle updated the task description. (Show Details)
Scott_French subscribed.Aug 21 2025, 12:18 AM
Scott_French closed subtask T402424: PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /srv/monitoring/lib.php on line 99 as Resolved.Aug 21 2025, 5:06 PM
Krinkle mentioned this in T402597: Exploratory testing on PHP 8.3 for MediaWiki Platform Team components.Aug 21 2025, 10:10 PM
Jdforrester-WMF subscribed.Aug 25 2025, 1:16 PM
Krinkle mentioned this in T402809: Exploratory testing on PHP 8.3 for MediaWiki Interfaces Team components.Aug 25 2025, 1:58 PM
Krinkle mentioned this in T402810: Exploratory testing on PHP 8.3 for Content Transform Team components.Aug 25 2025, 2:12 PM
Krinkle mentioned this in T403756: AutoModerator WikiPageConfig::getConfigData failed to load config from wiki: {error}.Sep 4 2025, 4:37 PM
Krinkle mentioned this in T401227: DBQueryError "The MariaDB server is running with the --read-only option" fails MainStash in Beta Cluster.Sep 4 2025, 5:00 PM
Krinkle mentioned this in T299054: Make varnish-frontend-restart work on Beta Cluster.Sep 4 2025, 5:16 PM
Krinkle mentioned this in T380881: Re-create poolcounter instance in Beta Cluster (deployment-prep).Sep 11 2025, 6:59 PM
Krinkle moved this task from MW Release Working Group to Inbox, needs triage on the MediaWiki-Engineering board.Oct 28 2025, 2:22 AM
Krinkle closed subtask T407403: Error: Invalid serialization data for DatePeriod object as Resolved.
Krinkle claimed this task.Oct 28 2025, 8:18 PM
Krinkle updated the task description. (Show Details)
Krinkle added a project: MediaWiki-Platform-Team.
Krinkle moved this task from Inbox, needs triage to In progress (DO NOT USE) on the MediaWiki-Platform-Team board.
Krinkle removed a project: MediaWiki-Engineering.
Krinkle mentioned this in T353180: Flaky test WANObjectCacheTest::testPreemptiveRefresh (at least under php8.2 and php8.3).Oct 28 2025, 8:43 PM
Krinkle updated the task description. (Show Details)Oct 28 2025, 10:18 PM
Krinkle edited subscribers, added: matmarex, ArielGlenn; removed: • larissagaulia.
Krinkle updated the task description. (Show Details)Nov 3 2025, 9:19 AM
Krinkle reassigned this task from Krinkle to ArielGlenn.Nov 3 2025, 9:33 AM

Handing the baton to @ArielGlenn.

matmarex updated the task description. (Show Details)Nov 3 2025, 3:31 PM
ArielGlenn added a comment.Nov 3 2025, 8:31 PM

matmarex and I swapped duty weeks so he has it now and I'll get it next week.

Krinkle reassigned this task from ArielGlenn to matmarex.Nov 4 2025, 1:06 AM
matmarex reassigned this task from matmarex to ArielGlenn.Nov 8 2025, 9:15 PM

I reviewed the dashboard filters to phpversion: 8.3.26, looked at top errors, and then checked whether they also occurred on PHP 8.1. Many errors related to Parsoid seem to occur only on PHP 8.3, but I think that's because all of Parsoid traffic is served by PHP 8.3 servers now (per T405955#11346217). After excluding them (-parsoid in the search field), I haven't noticed anything that would be unique to PHP 8.3.

Be aware of the Parsoid anomaly next week :) (and any other anomalies that could be caused by switching specific things to PHP 8.3 – T405955 has a list of "milestones", Wikifunctions is another notable one).

cscott subscribed.Nov 12 2025, 3:33 PM

I wonder if for future upgrades we should reserve one machine running the 'old version', rather than upgrade all of the parsoid traffic at once, just to make it easier to distinguish 8.3-related issues from general issues.

Krinkle updated the task description. (Show Details)Nov 12 2025, 3:34 PM
Bugreporter2 added a project: Epic.Nov 12 2025, 3:57 PM
Scott_French added a comment.EditedNov 12 2025, 4:00 PM

@cscott - That's a good point, yeah. Unlike the 8.1 migration, where we spread the mw-parsoid service migration over a couple of steps, we decided to switch more quickly this time.

This was mainly due to (1) the very small amount of traffic it now receives (i.e., low confidence that a fractional pilot would provide useful signal) and (2) the fact that it was unexpected (for me at least) that we would encounter a Parsoid 8.3 compatibility issue only in code exercised in mw-parsoid.

What's curious is that we appear to have got rather unlucky w.r.t. #2, in that T409345 is seemingly only(?) tickled on the Parsoid REST API path (so only seen on mw-parsoid - edit: thus having no 8.1-served traffic at that point to provide counter-examples) and 1.46.0-wmf.1 landed for enwiki (seemingly the only wiki affected based on the logs), shortly after the change, which together presented a spurious correlation with 8.3.

For future reference, do you anticipate that the Parsoid REST API will still need to exist in ~ 1 year when the next migration happens?

ABreault-WMF added a comment.Nov 12 2025, 4:46 PM

(2) the fact that it was unexpected (for me at least) that we would encounter a Parsoid 8.3 compatibility issue only in code exercised in mw-parsoid.

T409345 isn't a compatibility issue though

Scott_French added a comment.Nov 12 2025, 4:55 PM

@ABreault-WMF - Indeed, what I mean is that a set of circumstances arose that presented a spurious correlation with the switch to 8.3, so that the influx of assertion failures in T409345 could easily be mistaken with a compatibility issue initially.

ABreault-WMF added a comment.EditedNov 12 2025, 8:06 PM

Sorry, I misunderstood.

The wikitext/to/lint endpoint that's raising T409345 looks like it'll be migrating fairly soon in T384216 or T385066

ArielGlenn reassigned this task from ArielGlenn to BPirkle.Nov 17 2025, 2:13 PM
ArielGlenn updated the task description. (Show Details)
OWresch-WMF edited projects, added MediaWiki-Platform-Team (Q3 Kanban Board); removed MediaWiki-Platform-Team.Nov 21 2025, 11:44 AM
OWresch-WMF moved this task from Essential Work to In Progress on the MediaWiki-Platform-Team (Q3 Kanban Board) board.
MSantos added a project: MW-Interfaces-Team.Nov 24 2025, 12:24 PM
MSantos updated the task description. (Show Details)
OWresch-WMF edited projects, added MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team (Q3 Kanban Board).Nov 24 2025, 3:52 PM
BPirkle reassigned this task from BPirkle to aaron.Nov 24 2025, 7:16 PM
BPirkle updated the task description. (Show Details)
BPirkle subscribed.
aaron triaged this task as High priority.Nov 25 2025, 2:19 AM
aaron moved this task from Incoming (Needs Triage) to Bugs & Chores on the MW-Interfaces-Team board.
aaron updated the task description. (Show Details)
aaron added a comment.Nov 25 2025, 4:01 PM
In T401855#11368401, @ABreault-WMF wrote:

Sorry, I misunderstood.

The wikitext/to/lint endpoint that's raising T409345 looks like it'll be migrating fairly soon in T384216 or T385066

The wikitext/to/lint migration is done already. The page/lint migration also finished today.

Krinkle updated the task description. (Show Details)Dec 2 2025, 6:08 PM
HCoplin-WMF reassigned this task from aaron to cscott.Dec 3 2025, 2:12 PM
HCoplin-WMF added a subscriber: aaron.

Reassigning to CScott (randomly selected from listed CTT subscribers; feel free to reassign @MSantos or @SLopes-WMF ), given the schedule.

Michael closed subtask T408852: PHP Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated as Resolved.Dec 16 2025, 6:02 PM
aaron added a comment.Dec 18 2025, 12:41 AM

All stated weeks have passed and the rollout task is closed. Should this task be closed?

Krinkle closed this task as Resolved.Dec 18 2025, 3:07 AM
Krinkle updated the task description. (Show Details)
Krinkle updated the task description. (Show Details)Dec 18 2025, 11:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits