Page MenuHomePhabricator

cite-ve-dialog-reference-editing-edit-details is hard to translate
Closed, ResolvedPublic

Description

Background

The message cite-ve-dialog-reference-editing-edit-details is hard to translate. It looks like an incomplete sentence, and I suspect that it's a "lego" message.

If it is supposed to have more text, this text should be inserted into the message using a $1 parameter.

If it is supposed to be incomplete, this should be clarified in the qqq documentation.


Message URL: https://translatewiki.net/w/i.php?title=Special:Translate&showMessage=cite-ve-dialog-reference-editing-edit-details&group=ext-cite-visualeditor&language=he

Next steps
Definition of Done
  • cite-ve-dialog-reference-editing-add-details message is updated: You are adding details to this reference:
  • cite-ve-dialog-reference-editing-edit-details message is updated: You are editing the details of this reference:

Event Timeline

Added in T399184. Seems to be a complement to the existing cite-ve-dialog-reference-editing-add-details which has a similar fragmentary pattern, and was added last year in T373876.

thiemowmde added subscribers: ElineWMDE, thiemowmde.

There are two messages that are used as a headline in a dialog window:

The dialog shows the preview of a reference below this headline:

image.png (518×675 px, 41 KB)

T399184 was the relevant ticket for that.

The qqq descriptions already explain this, as far as I can see. I'm not sure what else we could do other than providing this information. What's missing?

I think the issue is that the message looks like it is followed by another word, and in many languages that next word would affect the grammar of the translation. The qqq should be clear that it precedes a preview of an existing reference, or the message could be changed to "You are adding details to this reference:"

I think the issue is that the message looks like it is followed by another word, and in many languages that next word would affect the grammar of the translation.

Exactly.

The qqq should be clear that it precedes a preview of an existing reference, or the message could be changed to "You are adding details to this reference:"

Sounds good.

There's presumably languages where the most-natural translation would include switching the order of the reference and the message, thus the suggestion for $1, though it doesn't really work out to do that in this situation since it's a full block-level display of it.

There's presumably languages where the most-natural translation would include switching the order of the reference and the message, thus the suggestion for $1, though it doesn't really work out to do that in this situation since it's a full block-level display of it.

It's understandable that some things cannot be included in a sentence. Adding "to this reference:" to the message looks like a good solution in this case. The screenshot above is helpful for understanding the context.

For a start I updated the two qqq descriptions (1, 2). Making changes to the dialog itself is up to WMDE-Design and PM as well as our ongoing User-Testing.

Thanks for bringing this up @Amire80! You make a really good point that we had overlooked so far. I agree with your suggestion to complete the sentence.

ElineWMDE updated Other Assignee, added: Lina_Farid_WMDE.

Thanks all! I've been asked to review and have reviewed. @MareikeHeuerWMDE could you kindly create the tasks so that the new product copy is updated in the UI. Thanks!

Change #1186007 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] i18n: Improve text for editing / adding details on subrefs

https://gerrit.wikimedia.org/r/1186007

Change #1186007 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] i18n: Improve text for editing / adding details on subrefs

https://gerrit.wikimedia.org/r/1186007