Page MenuHomePhabricator

Chart displays NaN for entries with no data
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
It displays “Member Count: NaN

What should have happened instead?:
Something that doesn’t require a user to know about IEEE 754 to make sense of.

  • “no data”?
  • custom / localizable string?
  • no tooltip at all?

Other information (browser name/version, screenshots, etc.):
In the underlying tabular data, the years that display NaN have the data set to null. I expect it’s set that way, rather than completely omitting the years with no data, so that the chart won’t show non-adjacent years directly adjacent to each other (but that’s just my guess and I haven’t tested how it would behave otherwise).

Event Timeline

Jdlrobson-WMF moved this task from Incoming/Inbox to Backlog on the Reader Growth Team board.

Change #1207411 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/extensions/Chart@master] Show "no data" message when tooltip does not have a numeric data

https://gerrit.wikimedia.org/r/1207411

Patch looks good in second rev; code is clean and it now checks for both missing data cells and explicit nulls; +2ing for merge. :)

Change #1207411 merged by jenkins-bot:

[mediawiki/extensions/Chart@master] Show "no data" message when tooltip does not contain to show

https://gerrit.wikimedia.org/r/1207411

Change #1210669 had a related patch set uploaded (by Bvibber; author: HMonroy):

[mediawiki/extensions/Chart@wmf/1.46.0-wmf.3] Show "no data" message when tooltip does not contain to show

https://gerrit.wikimedia.org/r/1210669

Change #1210669 merged by jenkins-bot:

[mediawiki/extensions/Chart@wmf/1.46.0-wmf.3] Show "no data" message when tooltip does not contain to show

https://gerrit.wikimedia.org/r/1210669

Mentioned in SAL (#wikimedia-operations) [2025-11-24T21:33:38Z] <dani@deploy2002> Started scap sync-world: Backport for [[gerrit:1208408|Pre-deploy 2025 Global Readers Survey (T410696)]], [[gerrit:1210655|Deploy experiment for 2025 Global Readers Survey (T410696)]], [[gerrit:1210669|Show "no data" message when tooltip does not contain to show (T401990)]]

Mentioned in SAL (#wikimedia-operations) [2025-11-24T22:01:07Z] <dani@deploy2002> dani, bvibber: Backport for [[gerrit:1208408|Pre-deploy 2025 Global Readers Survey (T410696)]], [[gerrit:1210655|Deploy experiment for 2025 Global Readers Survey (T410696)]], [[gerrit:1210669|Show "no data" message when tooltip does not contain to show (T401990)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Fix merged, backported and deployed. <3