Maniphest T402023

Error: Invalid pageId: undefined (FavoriteStore)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

1,923 errors in last 7 days on multiple wikis https://logstash.wikimedia.org/goto/95f145ba7a46cc7e27ea23cc8ae273e2

at parsePageId  https://fr.wikipedia.org/w/load.php?lang=fr&modules=ext.templateData.templateDiscovery&skin=vector-2022&version=1qrqc:20:31
at FavoritesStore.js.FavoritesStore.isFavorite  https://fr.wikipedia.org/w/load.php?lang=fr&modules=ext.templateData.templateDiscovery&skin=vector-2022&version=1qrqc:21:95
at new FavoriteButton  https://fr.wikipedia.org/w/load.php?lang=fr&modules=ext.templateData.templateDiscovery&skin=vector-2022&version=1qrqc:22:266
at new VeUiMWTemplatePage  https://fr.wikipedia.org/w/load.php?lang=fr&modules=ext.visualEditor.core%2Cmwtransclusion&skin=vector-2022&version=3j9cm:1125:684
at VeUiMWTransclusionDialog.getPageFromPart  https://fr.wikipedia.org/w/load.php?lang=fr&modules=ext.visualEditor.core%2Cmwtransclusion&skin=vector-2022&version=3j9cm:1146:291
at VeUiMWTransclusionDialog.getPageFromPart  https://fr.wikipedia.org/w/load.php?lang=fr&modules=ext.visualEditor.core%2Cmwtransclusion&skin=vector-2022&version=3j9cm:1158:501
at VeUiMWTransclusionDialog.onReplacePart  https://fr.wikipedia.org/w/load.php?lang=fr&modules=ext.visualEditor.core%2Cmwtransclusion&skin=vector-2022&version=3j9cm:1144:387
at VeUiMWTransclusionDialog.onReplacePart  https://fr.wikipedia.org/w/load.php?lang=fr&modules=ext.visualEditor.core%2Cmwtransclusion&skin=vector-2022&version=3j9cm:1155:1017
at OO.EventEmitter.emit  https://fr.wikipedia.org/w/load.php?lang=fr&modules=oojs&skin=vector-2022&version=rwdvu:8:193
at VeDmMWTransclusionModel.resolveChangeQueue  https://fr.wikipedia.org/w/load.php?lang=fr&modules=ext.visualEditor.core%2Cmwtransclusion&skin=vector-2022&version=3j9cm:1088:441

Stack trace seems to point to https://gerrit.wikimedia.org/g/mediawiki/extensions/TemplateData/+/f90675b4cb24ca0956b614acf070091915ffe1ed/modules/ext.templateData.templateDiscovery/FavoritesStore.js#128

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Only show template favoriting button if the template exists	Samwilson	mediawiki/extensions/VisualEditor	master	+5 -9

Customize query in gerrit

Event Timeline

Jdlrobson-WMF created this task.Aug 15 2025, 3:24 PM

Restricted Application changed the subtype of this task from "Bug Report" to "Production Error". · View Herald TranscriptAug 15 2025, 3:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdlrobson-WMF added subscribers: Samwilson, TheresNoTime.Aug 15 2025, 3:25 PM

Maintenance_bot added a project: VisualEditor.Aug 15 2025, 3:29 PM

DLynch added a project: Template-Discovery-And-Recall.Aug 15 2025, 3:59 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptAug 15 2025, 3:59 PM

Samwilson claimed this task.Aug 18 2025, 1:02 AM

Samwilson moved this task from New & TBD Tickets to Allow users to favorite a template on the Template-Discovery-And-Recall board.

Samwilson edited projects, added: Template-Discovery-And-Recall (Allow users to favorite a template); removed: Template-Discovery-And-Recall.

Samwilson edited projects, added: Community-Tech (Fox Squad); removed: Community-Tech.

Change #1179292 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/VisualEditor@master] Only show template favoriting button if the template exists

https://gerrit.wikimedia.org/r/1179292

gerritbot added a project: Patch-For-Review.Aug 18 2025, 1:10 AM

This appears to happen when inserting a template that doesn't exist. We shouldn't show the favorite button for those templates.

Change #1179292 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Only show template favoriting button if the template exists

https://gerrit.wikimedia.org/r/1179292

Samwilson moved this task from Feedback and Review to QA on the Community-Tech (Fox Squad) board.Aug 19 2025, 10:25 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 19 2025, 10:30 AM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.16; 2025-08-26).Aug 19 2025, 11:00 AM

I don't see the favourite icon on non-existent template pages.

Error: Invalid pageId: undefined (FavoriteStore)Closed, ResolvedPublicPRODUCTION ERRORActions

Description

Details

Event Timeline

Error: Invalid pageId: undefined (FavoriteStore)
Closed, ResolvedPublicPRODUCTION ERROR
Actions