Page MenuHomePhabricator
Create Task
Maniphest T402179

Backport 8fa6c2c4d8a9d1b046167f8c7809fe501b19c199 to REL1_44
Open, Needs TriagePublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Open Special:UserMerge
  • Try to merge a user into "Anonymous" and check "Delete old user".

What happens?:

[891b0b30a1141afa58b08fdb] /title/Special:UserMerge Wikimedia\Rdbms\DBQueryError: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading or after adding a new extension?

Please see https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:Upgrading and https://www.mediawiki.org/wiki/Special:MyLanguage/Manual:How_to_debug for more information.

Error 1146: Table 'mediawiki.revision_actor_temp' doesn't exist
Function: MergeUser::mergeDatabaseTables
Query: UPDATE `revision_actor_temp` SET revactor_actor = 27 WHERE revactor_actor = 30

Backtrace:

from /srv/http/htdocs/includes/libs/rdbms/database/Database.php(1232)
#0 /srv/http/htdocs/includes/libs/rdbms/database/Database.php(1216): Wikimedia\Rdbms\Database->getQueryException()
#1 /srv/http/htdocs/includes/libs/rdbms/database/Database.php(1190): Wikimedia\Rdbms\Database->getQueryExceptionAndLog()
#2 /srv/http/htdocs/includes/libs/rdbms/database/Database.php(647): Wikimedia\Rdbms\Database->reportQueryError()
#3 /srv/http/htdocs/includes/libs/rdbms/database/Database.php(1518): Wikimedia\Rdbms\Database->query()
#4 /srv/http/htdocs/includes/libs/rdbms/database/DBConnRef.php(127): Wikimedia\Rdbms\Database->update()
#5 /srv/http/htdocs/includes/libs/rdbms/database/DBConnRef.php(413): Wikimedia\Rdbms\DBConnRef->__call()
#6 /srv/http/htdocs/includes/libs/rdbms/querybuilder/UpdateQueryBuilder.php(332): Wikimedia\Rdbms\DBConnRef->update()
#7 /srv/http/htdocs/extensions/UserMerge/includes/MergeUser.php(405): Wikimedia\Rdbms\UpdateQueryBuilder->execute()
#8 /srv/http/htdocs/extensions/UserMerge/includes/MergeUser.php(71): MergeUser->mergeDatabaseTables()
#9 /srv/http/htdocs/extensions/UserMerge/includes/SpecialUserMerge.php(159): MergeUser->merge()
#10 /srv/http/htdocs/includes/htmlform/HTMLForm.php(825): SpecialUserMerge->onSubmit()
#11 /srv/http/htdocs/includes/htmlform/HTMLForm.php(706): MediaWiki\HTMLForm\HTMLForm->trySubmit()
#12 /srv/http/htdocs/includes/htmlform/HTMLForm.php(722): MediaWiki\HTMLForm\HTMLForm->tryAuthorizedSubmit()
#13 /srv/http/htdocs/includes/specialpage/FormSpecialPage.php(211): MediaWiki\HTMLForm\HTMLForm->show()
#14 /srv/http/htdocs/includes/specialpage/SpecialPage.php(734): MediaWiki\SpecialPage\FormSpecialPage->execute()
#15 /srv/http/htdocs/includes/specialpage/SpecialPageFactory.php(1731): MediaWiki\SpecialPage\SpecialPage->run()
#16 /srv/http/htdocs/includes/actions/ActionEntryPoint.php(499): MediaWiki\SpecialPage\SpecialPageFactory->executePath()
#17 /srv/http/htdocs/includes/actions/ActionEntryPoint.php(143): MediaWiki\Actions\ActionEntryPoint->performRequest()
#18 /srv/http/htdocs/includes/MediaWikiEntryPoint.php(202): MediaWiki\Actions\ActionEntryPoint->execute()
#19 /srv/http/htdocs/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#20 {main}

What should have happened instead?:

Merge from X (Y) to Anonymous (0) is complete.

X (Y) has been deleted.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

MediaWiki 1.44.0
PHP 8.4.11 (fpm-fcgi)
ICU 76.1
MariaDB 11.8.3-MariaDB
UserMerge 1.10.2 (7aef163)

Other information (browser name/version, screenshots, etc.):

Cherry-picking 8fa6c2c4d8a9d1b046167f8c7809fe501b19c199 fixes it.

Please backport the commit to the REL1_44 branch.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
MergeUser: ignore tables that do not existmediawiki/extensions/UserMergeREL1_44+24 -0
Customize query in gerrit

Related Objects

Event Timeline

nl6720 created this task.Aug 18 2025, 10:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2025, 10:48 AM
Daimona subscribed.Oct 31 2025, 2:47 PM

Yeah, CI is also broken in the REL1_44 branch due to this:

1) MergeUserTest::testBasicMerge
Wikimedia\Rdbms\DBQueryError: Error 1146: Table 'wikidb.unittest_revision_actor_temp' doesn't exist
Function: MergeUser::mergeDatabaseTables
Query: SELECT  revactor_rev  FROM `unittest_revision_actor_temp` `revision_actor_temp`    WHERE revactor_actor = 1  LIMIT 200  


/workspace/src/includes/libs/rdbms/database/Database.php:1232
/workspace/src/includes/libs/rdbms/database/Database.php:1216
/workspace/src/includes/libs/rdbms/database/Database.php:1190
/workspace/src/includes/libs/rdbms/database/Database.php:647
/workspace/src/includes/libs/rdbms/database/Database.php:1367
/workspace/src/includes/libs/rdbms/database/DBConnRef.php:127
/workspace/src/includes/libs/rdbms/database/DBConnRef.php:351
/workspace/src/includes/libs/rdbms/querybuilder/SelectQueryBuilder.php:762
/workspace/src/extensions/UserMerge/includes/MergeUser.php:418
/workspace/src/extensions/UserMerge/includes/MergeUser.php:71
/workspace/src/extensions/UserMerge/tests/phpunit/MergeUserTest.php:55
gerritbot added a comment.Oct 31 2025, 2:49 PM

Change #1200366 had a related patch set uploaded (by Daimona Eaytoy; author: XtexChooser):

[mediawiki/extensions/UserMerge@REL1_44] MergeUser: ignore tables that do not exist

https://gerrit.wikimedia.org/r/1200366

gerritbot added a project: Patch-For-Review.Oct 31 2025, 2:49 PM
Daimona added a comment.Oct 31 2025, 2:52 PM

(On a related note, I'm wondering if we could just stop referencing the revision_actor_temp table since it's been dropped long ago.)

gerritbot added a comment.Nov 8 2025, 9:20 PM

Change #1200366 merged by jenkins-bot:

[mediawiki/extensions/UserMerge@REL1_44] MergeUser: ignore tables that do not exist

https://gerrit.wikimedia.org/r/1200366

Maintenance_bot removed a project: Patch-For-Review.Nov 8 2025, 9:30 PM
Daimona mentioned this in T409756: Drop references to revision_actor_temp in UserMerge.Nov 10 2025, 5:05 PM
In T402179#11331454, @Daimona wrote:

(On a related note, I'm wondering if we could just stop referencing the revision_actor_temp table since it's been dropped long ago.)

Filed as T409756.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits