Design notes for @JFernandez-WMF:

• Let's remove characters from the summary view
• Let's update links to be like bytes (added & removed)

Random question that just occurred to me: how would this work in mobile? One way to do it would be to have the cards wrap around, but I could easily see that taking up a lot of vertical space just with those cards (think if they are one per line). So, should it maybe not wrap, and be horizontally scrollable instead? Also considering that there's a table below, and tables are generally hard to optimize for mobile, so we probably would need to have horizontal scrolling for that anyway.

Question for @JFernandez-WMF to explore. We can also discuss this during our next 1:1.

In T402211#11110796, @Daimona wrote:

Random question that just occurred to me: how would this work in mobile? One way to do it would be to have the cards wrap around, but I could easily see that taking up a lot of vertical space just with those cards (think if they are one per line). So, should it maybe not wrap, and be horizontally scrollable instead? Also considering that there's a table below, and tables are generally hard to optimize for mobile, so we probably would need to have horizontal scrolling for that anyway.

I updated the design task related to mobile behavior, see T401239#11124789, but basically yes the proposal is horizontal scrolling for both summary and table.

Change #1186993 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Add contribution summary view

https://gerrit.wikimedia.org/r/1186993

Test wiki created on Patch demo by CMelo (WMF) using patch(es) linked to this task:
https://554fabc3ca.catalyst.wmcloud.org/w/

Test wiki created on Patch demo by CMelo (WMF) using patch(es) linked to this task:
https://27a4ec2259.catalyst.wmcloud.org/w/

Test wiki on Patch demo by CMelo (WMF) using patch(es) linked to this task was deleted:

https://554fabc3ca.catalyst.wmcloud.org/w/

Test wiki created on Patch demo by CMelo (WMF) using patch(es) linked to this task:
https://ce2d28a2bc.catalyst.wmcloud.org/w/

Test wiki created on Patch demo by CMelo (WMF) using patch(es) linked to this task:
https://2b7ac98b54.catalyst.wmcloud.org/w/

Test wiki on [[ | Patch demo ]] by CMelo (WMF) using patch(es) linked to this task was deleted:

https://2b7ac98b54.catalyst.wmcloud.org/w/

Test wiki created on Patch demo by CMelo (WMF) using patch(es) linked to this task:
https://c55106d465.catalyst.wmcloud.org/w/

Test wiki on Patch demo by CMelo (WMF) using patch(es) linked to this task was deleted:

https://c55106d465.catalyst.wmcloud.org/w/

Test wiki created on Patch demo by CMelo (WMF) using patch(es) linked to this task:
https://6533b93b1c.catalyst.wmcloud.org/w/

Test wiki on Patch demo by CMelo (WMF) using patch(es) linked to this task was deleted:

https://6533b93b1c.catalyst.wmcloud.org/w/

Test wiki created on Patch demo by CMelo (WMF) using patch(es) linked to this task:
https://9c858794fb.catalyst.wmcloud.org/w/

Change #1193427 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Add summary view to contributions tab

https://gerrit.wikimedia.org/r/1193427

Change #1186993 abandoned by Cmelo:

[mediawiki/extensions/CampaignEvents@master] Add contribution summary view

Reason:

There were too many complicated conflicts to solve, recreated it on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CampaignEvents/+/1193427

https://gerrit.wikimedia.org/r/1186993

Change #1193427 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add summary view to contributions tab

https://gerrit.wikimedia.org/r/1193427

Change #1193917 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Various tweaks for the summary view of the contributions tab

https://gerrit.wikimedia.org/r/1193917

One thing that the AC do not clarify: should "articles edited" include articles that were created as part of the event (and are therefore already included in "articles created")?

(Apologies for the edit conflict, moving back to CR as I had some drafts from an unfinished review, and a couple things I found later, that I turned into a follow-up change)

In T402211#11247227, @Daimona wrote:

One thing that the AC do not clarify: should "articles edited" include articles that were created as part of the event (and are therefore already included in "articles created")?

I think they shouldn't, what do you think @ifried ?

I agree with @cmelo. Articles edited should only be for articles that were already created. "Edited" and "created" should be separate stats, so they can stand on their own as something meaningful and understandable to the user.

Change #1193917 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Various tweaks for the summary view of the contributions tab

https://gerrit.wikimedia.org/r/1193917

In T402211#11256475, @ifried wrote:

I agree with @cmelo. Articles edited should only be for articles that were already created. "Edited" and "created" should be separate stats, so they can stand on their own as something meaningful and understandable to the user.

Okay, makes sense to me. This is not what the current code is doing though -- it excludes page creations when counting pages, but if a page is created as part of an event and then it gets more edits, it will still be included in both counts.

ok, ticket created & thanks for flagging this: T406783

Acceptance criteria (summary of contributions):

• Given that any user (logged in or logged out) is viewing the “Contributions” tab for an event,
  • ✅ Then they should see 6 contribution summary cards displayed above the table:
    
    • ✅ Participants
    • ✅ Wikis edited
    • ✅ Articles created
    • ✅ Articles edited
    • ✅ Bytes changed
    • ✅ Links changed
  • And each card should use the Card component

• Given that any user (logged in or logged out) is viewing the “Bytes changed” and “Links changed” cards,
  • ✅ Then values should be visually split into positive and negative numbers,
    
  • ✅ Use the same formatting as that found in page histories (ChangesList::showCharacterDifference)

• And for contributions that are made by publicly registered participants,
  • ✅ Then their contribution data should be shown to all users who view the Contributions tab in both aggregate and per edit view
• And for contributions that are made by privately registered participants,
  • ✅ Then their contribution data should only be shown to permitted viewers (i.e., event organizers, wiki admins or other user groups designed as permitted by the wikis, and the participant who made the edits) in the granular and aggregate view in the Contributions tab

✅ Make the cards in the summary scrollable horizontally. The table should also be scrollable horizontally per the component's breakpoint for mobile.

All AC met and functioning as expected. There is less spacing between the cards in the build than in the comp, so sending this to @JFernandez-WMF for thoughts or design sign off. See below:

comp	build	build (full view)

this looks good to me, thanks all!