Page MenuHomePhabricator

File deletions not tagged with the "Nuke" tag
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Mass delete a user's recent uploads using Special:Nuke.

What happens?: The file deletions are not tagged with the "Nuke" tag, unlike deletions of non-file pages.

What should have happened instead?: The file deletions are tagged with the "Nuke" tag, like deletions of non-file pages.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
See https://en.wikipedia.org/wiki/Special:Log/Sir_Sputnik for examples of file deletions that were not tagged with the "Nuke" tag.
T366068: Tag deletion logs performed with Nuke

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Currently, tags aren't added to file deletions because we rely on FileDeleteForm to perform the deletion (usage), which itself requires tags to be user-appliable (related line). Oddly enough, I can't find a "proper" example of a file page deletion besides all places that just end up using FileDeleteForm. I guess deleting a page with tags applied isn't really a common action that got abstracted somewhere?

Arendpieter changed the task status from Open to In Progress.Mar 5 2026, 8:40 PM

Change #1248604 had a related patch set uploaded (by Arendpieter; author: Arendpieter):

[mediawiki/extensions/Nuke@master] Tag file deletions performed with Nuke

https://gerrit.wikimedia.org/r/1248604

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://31987c3e39.catalyst.wmcloud.org/w/

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

https://31987c3e39.catalyst.wmcloud.org/w/

Change #1248604 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] Tag file deletions performed with Nuke

https://gerrit.wikimedia.org/r/1248604

jsn.sherman moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.