Executor unit tests (chai) asserts have arguments in the wrong order
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	gengh
	Aug 19 2025, 11:16 AM

Project Tags

Referenced Files

None

Subscribers

cmassaro

gengh

Description

Chai asserts should be assert( actual, expected ), but we do assert( expected, actual ), which becomes confusing when debugging tests.

Docs: https://www.chaijs.com/api/assert/#method_deepequal

Example: https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/blob/main/executors/javascript-wasmedge/test/executor.js?ref_type=heads#L46

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	wikifunctions: Upgrade evaluators from 2026-07-27-212343 to 2026-08-04-215640	Jforrester	operations/deployment-charts	master	+2 -2

Customize query in gerrit

Related Changes in GitLab:

	Title	Reference	Author	Source Branch	Dest Branch
	Switch actual and expected in JS chai test assertions.	repos/abstract-wiki/wikifunctions/function-evaluator!622	apine	apine-test-order	main

Customize query in GitLab

Related Objects

Mentioned In: rMSFE154fd54ce3bb: Switch actual and expected in JS chai test assertions.

Event Timeline

gengh created this task.Aug 19 2025, 11:16 AM

cmassaro claimed this task.Aug 19 2025, 11:19 AM

gengh added a project: Abstract Wikipedia Fix-It tasks.Aug 19 2025, 11:26 AM

cmassaro removed cmassaro as the assignee of this task.Aug 19 2025, 11:58 AM

cmassaro subscribed.

Jdforrester-WMF triaged this task as Medium priority.Aug 27 2025, 3:41 PM

Jdforrester-WMF moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.

gengh assigned this task to cmassaro.Nov 26 2025, 4:54 PM

gengh removed cmassaro as the assignee of this task.

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/622

Switch actual and expected in JS chai test assertions.

cmassaro claimed this task.Jul 29 2026, 10:45 PM

cmassaro edited projects, added: Abstract Wikipedia team (27Q1 (Jul–Sep)); removed: Abstract Wikipedia team.

cmassaro moved this task from Incoming to In Code review on the Abstract Wikipedia team (27Q1 (Jul–Sep)) board.

Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (27Q1 (Jul–Sep)) board.Jul 30 2026, 11:07 AM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/622

Switch actual and expected in JS chai test assertions.

Jdforrester-WMF mentioned this in rMSFE154fd54ce3bb: Switch actual and expected in JS chai test assertions..Jul 30 2026, 11:36 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 30 2026, 12:32 PM

Jdforrester-WMF added a project: Essential-Work.Jul 30 2026, 4:59 PM

Change #1321556 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2026-07-27-212343 to 2026-08-04-215640

https://gerrit.wikimedia.org/r/1321556

gerritbot added a project: Patch-For-Review.Aug 5 2026, 1:59 PM

Change #1321556 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2026-07-27-212343 to 2026-08-04-215640

https://gerrit.wikimedia.org/r/1321556

Jdforrester-WMF closed this task as Resolved.Aug 5 2026, 2:11 PM

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (27Q1 (Jul–Sep)) board.

Maintenance_bot removed a project: Patch-For-Review.Aug 5 2026, 2:33 PM

Executor unit tests (chai) asserts have arguments in the wrong orderClosed, ResolvedPublicActions

Description

Description

Completion checklist

Details

Related Objects

Event Timeline

Executor unit tests (chai) asserts have arguments in the wrong order
Closed, ResolvedPublic
Actions