Page MenuHomePhabricator

xLab: Allow editing non-blocked fields once the instrument/experiment is already running
Closed, ResolvedPublic5 Estimated Story Points

Description

Description

At this time, as xLab works, once an experiment has reached 24 hours before the start date or an instrument start date is not in the future, no fields can be edited because that limitation blocks any other modification. Any modification at that time would be impossible without changing its start date as a new one later in the future (according to the corresponding criteria). There are technical reasons to have that limit but there are some non-technical fields for instruments/experiments, and others pretty technical only for instruments, that could be edited at any time because they are not involved in those reasons:

  • As an experiment owner, I want to change the end date of an experiment when it is active and has begun collecting data, so that I can extend the experiment's duration.
  • As an instrument owner, I want to change the schema type, stream and contextual attributes of an instrument when it is active and has begun collecting data
  • As an experiment/instrument owner, I want to change the non-technical fields (description, related OKRs, phabricator task, teams and contact email; and variant description only for experiments) of an instrument/experiment when it's active and has begun collecting data

Acceptance criteria

  • Instrument/Experiment owner can edit the end date even when it is active and has begun collecting data
  • Instrument owners can change the schema type, schema field and contextual attributes of an instrument even when it is active and has begun collecting data
  • Instrument/Experiment owners can change the non-technical fields (description, related OKRs, phabricator task, teams and contact email; and variant description only for experiments) of an instrument/experiment even when it's active and has begun collecting data

Event Timeline

JVanderhoop-WMF subscribed.

Because we are moving to GrowthBook, we'll mark this as lower priority for now. I understand this is helpful for teams, and perhaps while we onboard them we can make sure they're aware that they won't be able to make changes.

Milimetric raised the priority of this task from Low to High.Sep 17 2025, 3:32 PM
Milimetric subscribed.

Moving up in priority because of the new task we just merged in. Moving to GrowthBook will not happen soon enough to help us with the end date problem. Adding that as an AC to this task.

Sfaci renamed this task from xLab: Allow editing non-technical fields once the instrument/experiment is already activated to xLab: Allow editing non-blocked fields once the instrument/experiment is already activated.Oct 1 2025, 7:27 PM
Sfaci updated the task description. (Show Details)
Milimetric set the point value for this task to 5.Oct 6 2025, 3:30 PM
Sfaci renamed this task from xLab: Allow editing non-blocked fields once the instrument/experiment is already activated to xLab: Allow editing non-blocked fields once the instrument/experiment is already running.Oct 7 2025, 9:39 AM
Sfaci updated the task description. (Show Details)
Sfaci moved this task from READY TO GROOM to Backlog on the Test Kitchen board.

sfaci updated https://gitlab.wikimedia.org/repos/data-engineering/mpic/-/merge_requests/262

Draft: Allow to edit non-blocked fields and end date once an instrument/experiment has started

cjming merged https://gitlab.wikimedia.org/repos/data-engineering/mpic/-/merge_requests/262

Allow to edit non-blocked fields and end date once an instrument/experiment has started

Change #1199228 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] xLab: Deploying v1.1.0 release to staging

https://gerrit.wikimedia.org/r/1199228

Change #1199228 merged by jenkins-bot:

[operations/deployment-charts@master] xLab: Deploying v1.1.0 release to staging

https://gerrit.wikimedia.org/r/1199228

Change #1199733 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] xLab: Deploying v1.1.0 release to production

https://gerrit.wikimedia.org/r/1199733

Change #1199733 merged by jenkins-bot:

[operations/deployment-charts@master] xLab: Deploying v1.1.0 release to production

https://gerrit.wikimedia.org/r/1199733