Page MenuHomePhabricator
Create Task
Maniphest T402415

Broken output for broken wiki/ext links containing html tags
Closed, ResolvedPublicBUG REPORT
Actions

Description

See this transcript:

$ echo "[[<div>[{{1x|foo}}]</div>]]" | php bin/parse.php
<p data-parsoid='{"dsr":[0,27,0,0]}'>[[&lt;div>[<span about="#mwt3" typeof="mw:Transclusion" data-parsoid='{"pi":[[{"k":"1"}]],"dsr":[8,18,null,null]}' data-mw='{"parts":[{"template":{"target":{"wt":"1x","href":"./Template:1x"},"params":{"1":{"wt":"foo"}},"i":0}}]}'>foo</span>]]]</p>

We are processing the div tags as text!

The above is a reduced test case for the busted output seen on https://nov.wikipedia.org/wiki/Template%3ACountry?useparsoid=1

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Bump wikimedia/parsoid to 0.22.0-a18C. Scott Ananianmediawiki/vendormaster+4 K -3 K
Retokenize wikilink target for non-wikilinksArlolramediawiki/services/parsoidmaster+3 K -3 K
Customize query in gerrit

Related Objects

Event Timeline

ssastry created this task.Aug 20 2025, 4:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2025, 4:53 PM
Jgiannelos edited projects, added: Content-Platform-Team (Work In Progress); removed: Content-Platform-Team.Aug 21 2025, 2:10 PM
Jgiannelos moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Aug 21 2025, 2:17 PM
Izno subscribed.Aug 21 2025, 8:34 PM

The template's issue is the result of a copy-paste error of Template:Navbar into Template:Transclude when these templates were brought to this wiki (from whence I do not know since the copy-paste occurred long after these have been converted on en.wp and several other places to use Lua). This edit pulling from en.wp's 2009 version of Template:Transclude fixes that issue (in both parsers).

As for the reduced case, that is broken in old parser too, which turns the divs into something useful but the intent seems clearly to be "make this a link":

image.png (87×126 px, 904 B)

I don't think there's something worth fixing here presently if the reduced case is somehow interesting. We go from one way of being broken to another. If anything, probably the rightest thing to do would be to dump a (likely-red) link of whatever the insides would turn into.

ssastry triaged this task as Low priority.EditedAug 22 2025, 4:40 PM

Ya, this isn't high priority by any means, but mostly that Parsoid is doing the wrong thing when it bails on a broken link. For now, we can accept this as GIGO maybe, and get to handling the bail-out better in the future.

ssastry added a comment.Aug 22 2025, 5:28 PM

T402586: Non-wikilinks with html tags in target position is probably the same thing.

ABreault-WMF claimed this task.Aug 22 2025, 7:05 PM
ABreault-WMF moved this task from Backlog to Code Review on the Content-Platform-Team (Work In Progress) board.
ABreault-WMF subscribed.
In T402415#11111283, @ssastry wrote:

T402586: Non-wikilinks with html tags in target position is probably the same thing.

With the patch from that task I get,

$ (T402586) echo "[[<div>[{{1x|foo}}]</div>]]" | php bin/parse.php
<p data-parsoid='{"dsr":[0,2,0,0]}'>[[</p><div data-parsoid='{"stx":"html","dsr":[2,25,5,6]}'>[<span about="#mwt3" typeof="mw:Transclusion" data-parsoid='{"pi":[[{"k":"1"}]],"dsr":[8,18,null,null]}' data-mw='{"parts":[{"template":{"target":{"wt":"1x","href":"./Template:1x"},"params":{"1":{"wt":"foo"}},"i":0}}]}'>foo</span>]</div><p data-parsoid='{"dsr":[25,27,0,0]}'>]]</p>
gerritbot added a comment.Aug 22 2025, 7:31 PM

Change #1180960 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Retokenize wikilink target for non-wikilinks

https://gerrit.wikimedia.org/r/1180960

gerritbot added a project: Patch-For-Review.Aug 22 2025, 7:32 PM
gerritbot added a comment.Aug 22 2025, 8:16 PM

Change #1180960 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Retokenize wikilink target for non-wikilinks

https://gerrit.wikimedia.org/r/1180960

ABreault-WMF moved this task from Code Review to To Deploy on the Content-Platform-Team (Work In Progress) board.Aug 22 2025, 8:23 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 22 2025, 8:31 PM
gerritbot added a comment.Aug 25 2025, 6:40 PM

Change #1181757 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a18

https://gerrit.wikimedia.org/r/1181757

gerritbot added a project: Patch-For-Review.Aug 25 2025, 6:40 PM
gerritbot added a comment.Aug 25 2025, 7:51 PM

Change #1181757 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a18

https://gerrit.wikimedia.org/r/1181757

Maintenance_bot removed a project: Patch-For-Review.Aug 25 2025, 8:33 PM
ABreault-WMF closed this task as Resolved.Aug 28 2025, 6:29 PM

Post deploy and purge, these render the same now
https://nov.wikipedia.org/wiki/Template%3ACountry?useparsoid=0
https://nov.wikipedia.org/wiki/Template%3ACountry?useparsoid=1

MSantos added a project: OKR-Work.Jul 9 2026, 11:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits