Page MenuHomePhabricator

[MEX] M3.3.1 - add qualifiers edit form to edit statements
Closed, ResolvedPublic

Description

As a wikidata editor,
I want to be able to add qualifiers when editing or creating a statement on mobile
So that the statement can be more precise

.... NOTE: Add references (ticket T402433) is very similar to this....

add qualifier.png (1×1 px, 108 KB)

https://www.figma.com/design/RtMDwH7sMF5IPRJvyyZPv4/Mobile-editing-experience?node-id=2231-12226&t=C9HTDU2XkF8Mdz6A-1 DEV READY

a/c

  • When the 'add qualifier' button is clicked, the add qualifier form is opened
  • This form is an overlay which blocks scrolling on the form below
  • When the form is exited, the user is returned to the same place they were at before the form opened
  • The edit qualifiers form/user flow matches the figma design but is not pixel perfect
  • Once the user arrives to the form, the initial input form - codex component Lookup - is already active, but the dropdown only opens once the user starts typing (as in desktop)
  • Once the user selects or types in a valid entry, the second field appears and is already active, but once again the dropdown only opens when the user starts typing
  • valid qualifer datatypes available would be 'simple text inputs'
  • property suggestor should only make 'simple text inputs' available
  • once both values are inserted correctly the add button on top becomes active, and if the user clicks it, he returns to the previous screen where he can now see his qualifiers
  • the closing cross on the upper left corner takes the user back to the previous screen

Note: dev's choice for how to manage the multiple overlay. one option is main screen -> edit statement modal overlay -> reference modal overlay). Ideally it should be the same or nearly the same as in T402433

For the future

  • lookup suggestions will be handled outside of this ticket (when datatypes which support lookups is added constraint violations is implemented. at this time both lookups can show up to 6 suggestions, - the lookups dropdown type is "intial suggestions" (component behaviour) and the menu items include a description (also component behaviour)

Details

Event Timeline

karapayneWMDE renamed this task from [MEX] M3.1.1 - add qualifiers to edit form for simple text inputs to [MEX] M3.3.1 - add qualifiers edit form to edit statements.Aug 22 2025, 8:15 AM
karapayneWMDE updated the task description. (Show Details)
karapayneWMDE updated the task description. (Show Details)
Alice.moutinho updated the task description. (Show Details)
Alice.moutinho subscribed.

Change #1185998 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/Wikibase@master] [WIP] Add qualifier

https://gerrit.wikimedia.org/r/1185998

the work isn't fully done on this, but since I'm out tomorrow for a long weekend and (I believe) most of the work is done, I'm putting this in ready for peer review. The problems that are known to me are noted in the commit message, and I plan to take care of those when I return on Monday.

Change #1185998 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add qualifier when editing a statement

https://gerrit.wikimedia.org/r/1185998