Page MenuHomePhabricator

[MEX] M3.3.2 - add references edit form to edit statements
Closed, ResolvedPublic

Description

As a wikidata editor,
I want to be able to add references when editing or creating a statement on mobile
So that the statement can be more precise

add reference.png (1×1 px, 103 KB)

https://www.figma.com/design/RtMDwH7sMF5IPRJvyyZPv4/Mobile-editing-experience?node-id=2239-20480&t=C9HTDU2XkF8Mdz6A-1 ready for dev

a/c

  • When the 'add reference' button is clicked, the add reference form is opened
  • This form is an overlay which blocks scrolling on the form below
  • When the form is exited, the user is returned to the same place they were at before the form opened
  • The edit reference form matches the figma design but is not pixel perfect
  • Once the user arrives to the form, the initial input form - codex component Lookup - is already active, but the dropdown only opens once the user starts typing (as in desktop)
  • Once the user selects or types in a valid entry, the second field appears and is already active, but once again the dropdown only opens when the user starts typing
  • valid reference datatypes available would be 'simple text inputs'
  • property suggestor should only make 'simple text inputs' available
  • once both values are inserted correctly the add button on top becomes active, and if the user clicks it, he returns to the previous screen where he can now see his qualifiers
  • the closing cross on the upper left corner takes the user back to the previous screen

Note: dev's choice for how to manage the multiple overlay. one option is main screen -> edit statement modal overlay -> reference modal overlay). Ideally it should be the same or nearly the same as in T402431

For later (aka a future task):

  • both lookups can show up to 6 suggestions
  • the lookups dropdown type is "initial suggestions" (component behaviour) and the menu items include a description (also component behaviour)

Event Timeline

karapayneWMDE renamed this task from [MEX] M3.1.1 - add references to edit form for simple text inputs to [MEX] M3.3.2 - add references edit form to edit statements.Aug 22 2025, 8:16 AM
karapayneWMDE updated the task description. (Show Details)
karapayneWMDE updated the task description. (Show Details)
hoo moved this task from The Backlog to The Board on the Wikidata-Omega board.
hoo edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.
hoo moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.

Change #1190240 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Add references edit form

https://gerrit.wikimedia.org/r/1190240

hoo removed hoo as the assignee of this task.Sep 22 2025, 11:25 AM
hoo removed hoo as the assignee of this task.Oct 6 2025, 7:59 PM

@karapayneWMDE

Hi, i had forgotten the edit snak type in front of the seconf field here - Arthur noticed it on another ticket and now i have been checking all the tix... i am too late here because this is ready i guess. Should we make a new ticket to add the snak type here?

the design:

Screenshot 2025-10-10 at 11.39.08.png (1×1 px, 112 KB)

Change #1190240 abandoned by Arthur taylor:

[mediawiki/extensions/Wikibase@master] Add references edit form

Reason:

Abandoning in favour of I109f27494485cfec

https://gerrit.wikimedia.org/r/1190240

🔄 Peer Review Handover Summary

THE COMMENT WAS UPDATED TO THE LATEST CHANGES.
Moved from "In Peer Review" > "In Development" due to merge conflicts and minor code review issues.

✅ Work Completed

  • The acceptance criteria are almost met regarding the proposed development with local manual testing .. looks good so far (still missing only two acceptance criteria items).

🧪 Testing/Technical Status

Completed:

  • E2E tests written and passing
  • Manual testing performed
  • CI Builds are green and no merge conflicts (so far)
  • Code review received

🚧 Remaining Work

Medium Priority:

  • Merge conflicts should be resolved with a rebase.
  • The mentioned review comments must be addressed and resolved.
  • Only two missing AC items are included in the comment reviews.

🔗 Related Resources

  • Related Gerrit Patch(s):

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1196435


Handover Date: 24th October 2025
Last Updated By: Mahmoud

Change #1196435 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):

[mediawiki/extensions/Wikibase@master] Add references edit form to edit statements

https://gerrit.wikimedia.org/r/1196435

Change #1196435 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add references edit form to edit statements

https://gerrit.wikimedia.org/r/1196435