Page MenuHomePhabricator

"Accept" header label in REST Sandbox is hard to read
Open, LowPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Go to the REST Sandbox: https://test.wikipedia.org/wiki/Special:RestSandbox
  • Expand the documentation for any endpoint (for example, GET /v1/page/{title}/history)
  • Look at the "Response" section
  • Under the "Media type" label, there is a dropdown; under the dropdown, there is a label that says "Controls Accept header"

What happens?:

  • The highlight color on the word "Accept" is hard to read in both dark and light mode. See screenshots below:

LightMode.jpg (420×752 px, 32 KB)

DarkMode.jpg (420×752 px, 31 KB)

What should have happened instead?:
"Accept" should be easy to read.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Observed in Chrome and Firefox.

Event Timeline

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Note: This task will be resolved after SwaggerUI is replaced with a Codex solution: https://phabricator.wikimedia.org/T397474

Change #1180935 had a related patch set uploaded (by Shreshth Srivastava; author: Shreshth Srivastava):

[mediawiki/core@master] T402459: Fix highlight color for Accept label in Swagger UI

https://gerrit.wikimedia.org/r/1180935

Hello sir, i just submit the fixed code for this "Accept" css. change id- Ie2bc9bd32b1dee21884fe11aa501d5324b291033

Change #1180935 had a related patch set uploaded (by Shreshth Srivastava; author: Shreshth Srivastava):

[mediawiki/core@master] T402459: Fix highlight color for Accept label in Swagger UI

https://gerrit.wikimedia.org/r/1180935

Hey, thanks for the review! I've gone through all your comments and fixed everything in Patchset 4:

Switched indentation to tabs throughout the file
Cleaned up the trailing whitespace
Fixed CRLF → LF line endings (pretty sure that's what broke the CI last time)
Updated the commit subject to use restsandbox: as the component name instead of the task number
Also rewrote the commit body to better explain what the change actually does. Let me know if there's anything else that needs tweaking!

PS: Used Claude Code to help with the cleanup and push workflow.