Page MenuHomePhabricator
Create Task
Maniphest T402520

Use constructor property promotion and readonly modifier
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

Perform this update across the PHP codebase

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Revert "TranslationUnitDTO: Make blob type properties writable"Urbanecmmediawiki/extensions/ContentTranslationwmf/1.45.0-wmf.17+3 -3
TranslationUnitDTO: Make blob type properties writableAbijeet Patromediawiki/extensions/ContentTranslationwmf/1.45.0-wmf.17+3 -3
TranslationUnitDTO: Make blob type properties writableAbijeet Patromediawiki/extensions/ContentTranslationmaster+3 -3
includes: Use constructor property promotion and readonly modifierAbijeet Patromediawiki/extensions/ContentTranslationmaster+33 -126
Validator: Use constructor property promotion and readonly modifierAbijeet Patromediawiki/extensions/ContentTranslationmaster+4 -8
Special: Use constructor property promotion and readonly modifierAbijeet Patromediawiki/extensions/ContentTranslationmaster+5 -20
Store: Use constructor property promotion and readonly modifierAbijeet Patromediawiki/extensions/ContentTranslationmaster+13 -31
Manager: Use constructor property promotion and readonly modifierAbijeet Patromediawiki/extensions/ContentTranslationmaster+1 -4
Service: Use constructor property promotion and readonly modifierAbijeet Patromediawiki/extensions/ContentTranslationmaster+40 -69
Exception: Use constructor property promotion and readonly modifierAbijeet Patromediawiki/extensions/ContentTranslationmaster+1 -3
HookHandler: Use constructor property promotion and readonly modifierAbijeet Patromediawiki/extensions/ContentTranslationmaster+15 -58
Events: Use constructor property promotion and readonly modifierAbijeet Patromediawiki/extensions/ContentTranslationmaster+4 -12
DTO: Use constructor property promotion and readonly modifierAbijeet Patromediawiki/extensions/ContentTranslationmaster+41 -127
Entity: Use constructor property promotion and readonly modifierAbijeet Patromediawiki/extensions/ContentTranslationmaster+23 -84
ActionApi: Use constructor property promotion and readonly modifierAbijeet Patromediawiki/extensions/ContentTranslationmaster+61 -200
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

abi_ created this task.Aug 21 2025, 1:10 PM
abi_ triaged this task as Medium priority.Aug 21 2025, 1:15 PM
abi_ set the point value for this task to 4.
abi_ moved this task from Needs Triage to Maintenance on the ContentTranslation board.Aug 21 2025, 1:36 PM
gerritbot added a comment.Aug 21 2025, 1:41 PM

Change #1180868 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] ActionApi: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1180868

gerritbot added a project: Patch-For-Review.Aug 21 2025, 1:41 PM
gerritbot added a comment.Aug 21 2025, 2:50 PM

Change #1180883 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] DTO: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1180883

gerritbot added a comment.Aug 24 2025, 1:50 PM

Change #1181274 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] Entity: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181274

gerritbot added a comment.Aug 24 2025, 2:13 PM

Change #1181275 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] Events: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181275

gerritbot added a comment.Aug 24 2025, 2:13 PM

Change #1181276 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] Exception: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181276

gerritbot added a comment.Aug 24 2025, 2:13 PM

Change #1181277 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] HookHandler: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181277

gerritbot added a comment.Aug 24 2025, 2:28 PM

Change #1181278 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] Manager: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181278

gerritbot added a comment.Aug 24 2025, 2:28 PM

Change #1181279 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] Service: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181279

gerritbot added a comment.Aug 24 2025, 2:28 PM

Change #1181280 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] Special: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181280

gerritbot added a comment.Aug 24 2025, 3:23 PM

Change #1180868 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] ActionApi: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1180868

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.16; 2025-08-26).Aug 24 2025, 4:00 PM
abi_ changed the task status from Open to In Progress.Aug 25 2025, 12:55 PM
abi_ moved this task from Backlog to In Progress on the LPL Essential (2025 Jul-Oct) board.
gerritbot added a comment.Aug 25 2025, 1:05 PM

Change #1181700 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] Store: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181700

gerritbot added a comment.Aug 25 2025, 1:05 PM

Change #1181701 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] Validator: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181701

gerritbot added a comment.Aug 25 2025, 1:26 PM

Change #1181706 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] includes: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181706

gerritbot added a comment.Aug 28 2025, 9:55 AM

Change #1180883 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] DTO: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1180883

gerritbot added a comment.Aug 28 2025, 9:57 AM

Change #1181274 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Entity: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181274

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.17; 2025-09-02); removed: MW-1.45-notes (1.45.0-wmf.16; 2025-08-26).Aug 28 2025, 10:00 AM
gerritbot added a comment.Aug 28 2025, 11:59 AM

Change #1181275 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Events: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181275

gerritbot added a comment.Aug 28 2025, 11:59 AM

Change #1181276 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Exception: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181276

gerritbot added a comment.Aug 28 2025, 11:59 AM

Change #1181277 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] HookHandler: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181277

gerritbot added a comment.Aug 28 2025, 11:59 AM

Change #1181278 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Manager: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181278

gerritbot added a comment.Aug 28 2025, 11:59 AM

Change #1181279 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Service: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181279

gerritbot added a comment.Aug 28 2025, 11:59 AM

Change #1181280 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Special: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181280

gerritbot added a comment.Aug 28 2025, 11:59 AM

Change #1181700 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Store: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181700

gerritbot added a comment.Aug 28 2025, 11:59 AM

Change #1181701 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Validator: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181701

gerritbot added a comment.Aug 29 2025, 4:52 PM

Change #1181706 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] includes: Use constructor property promotion and readonly modifier

https://gerrit.wikimedia.org/r/1181706

Maintenance_bot removed a project: Patch-For-Review.Aug 29 2025, 5:31 PM
abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (2025 Jul-Oct) board.Sep 1 2025, 8:08 AM
• Nikerabbit added a project: LPL Projects (Other).Sep 1 2025, 8:41 AM
gerritbot added a comment.Sep 3 2025, 2:15 PM

Change #1184536 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@master] TranslationUnitDTO: Make blob type properties writable

https://gerrit.wikimedia.org/r/1184536

gerritbot added a project: Patch-For-Review.Sep 3 2025, 2:15 PM
gerritbot added a comment.Sep 3 2025, 2:19 PM

Change #1184538 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/ContentTranslation@wmf/1.45.0-wmf.17] TranslationUnitDTO: Make blob type properties writable

https://gerrit.wikimedia.org/r/1184538

gerritbot added a comment.Sep 3 2025, 2:46 PM

Change #1184536 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] TranslationUnitDTO: Make blob type properties writable

https://gerrit.wikimedia.org/r/1184536

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.18; 2025-09-09); removed: MW-1.45-notes (1.45.0-wmf.17; 2025-09-02).Sep 3 2025, 3:00 PM
gerritbot added a comment.Sep 3 2025, 3:37 PM

Change #1184538 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.45.0-wmf.17] TranslationUnitDTO: Make blob type properties writable

https://gerrit.wikimedia.org/r/1184538

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.17; 2025-09-02); removed: MW-1.45-notes (1.45.0-wmf.18; 2025-09-09).Sep 3 2025, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 3 2025, 4:31 PM
gerritbot added a comment.Sep 3 2025, 4:36 PM

Change #1184561 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/ContentTranslation@wmf/1.45.0-wmf.17] Revert "TranslationUnitDTO: Make blob type properties writable"

https://gerrit.wikimedia.org/r/1184561

gerritbot added a project: Patch-For-Review.Sep 3 2025, 4:36 PM

Change #1184561 merged by Urbanecm:

[mediawiki/extensions/ContentTranslation@wmf/1.45.0-wmf.17] Revert "TranslationUnitDTO: Make blob type properties writable"

https://gerrit.wikimedia.org/r/1184561

Urbanecm_WMF added subscribers: thiemowmde, Urbanecm_WMF.Sep 3 2025, 4:37 PM

@thiemowmde I noticed you merged a branch to a deployment branch without also deploying it. I reverted it, see https://wikitech.wikimedia.org/wiki/How_to_deploy_code#Problem:_undeployed_code.

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2025, 5:31 PM
thiemowmde added a comment.Sep 3 2025, 6:17 PM

@Urbanecm_WMF Ok, sorry, I'm apparently not familiar enough with the processes there. I will make sure to read the link. Thanks for that!

• Nikerabbit moved this task from Pending Deployment to Need QA on the LPL Essential (2025 Jul-Oct) board.Sep 4 2025, 11:43 AM
• Nikerabbit subscribed.

Revert of the revert was deployed today: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/1184645

abi_ closed this task as Resolved.Sep 8 2025, 4:00 AM
abi_ moved this task from Need QA to Done on the LPL Essential (2025 Jul-Oct) board.

This was deployed via the train on Thursday. Don't see any issues with publishing rates:

image.png (2,263×1,034 px, 223 KB)

I don't see any issues in Logstash either.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits