Page MenuHomePhabricator
Create Task
Maniphest T402597

Exploratory testing on PHP 8.3 for MediaWiki Platform Team components
Closed, ResolvedPublic
Actions

Description

This task is a blocker for WE6.4.2 (FY25-26 Q1), as tracked by the parent task T360995: Migrate Wikimedia production from PHP 8.1 to PHP 8.3.

Step 2 of the PHP upgrade process § Test checklist:
  • QTE, MW, SRE: Validation and end-to-end testing, especially areas not covered by CI.

This testing step is the last phase before SRE may start the rollout and send (a percentage of) live web requests in production to the PHP 8.3 containers.

This task represents the testing for MediaWiki Platform Team components as listed on mw:Maintainers. It is up to the team to judge and decide what components warrant testing at this stage, and what/how much testing to do.

MediaWiki core:

  • Authentication and Authorization
  • BagOStuff
  • Benchmarker
  • Notifications
  • Profiler
  • ResourceLoader
  • StatsLib

MediaWiki extensions:

  • CentralAuth
  • OATHAuth
  • OAuth
  • OAuthRateLimiter
  • WebAuthn

MediaWiki libs:

  • wikimedia/cssjanus
  • OOjs (not PHP)
  • jquery-client (not PHP)
  • wikimedia/less.php
  • wikimedia/minify
  • wikimedia/php-session-serializer
  • wikimedia/relpath
  • wikimedia/wrappedstring

Misc service-level components:

  • php-excimer
  • poolcounter (not PHP)

How to test:

  • Enable WikimediaDebug in your browser and choose the k8s-mwdebug-next option. This routes wikipedia.org and wikimedia.org requests from your browser to the new MediaWiki containers that run PHP 8.3 instead of PHP 8.1.
  • Report any problems under T401855: ☂ PHP 8.3 issues found during WMF rollout, via the button on that task.
  • Even if you see no problems in the user interface, check the Logstash: mwdebug for any errors during your debug session. For example, non-fatal errors (such as PHP Deprecation, PHP Notice, and PHP Warning messages), and post-send exceptions (such as via a DeferredUpdate) would not show in the user interface, but are reported to Logstash.
  • We will by default delay the rollout until subtasks of T401855 are resolved. If an issue you found is considered non-blocking, please leave a comment on the subtask in question.

Once your team is satisfied with testing and has discovered any issues you want to discover before rollout, feel free to close this task.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
benchmarks: Fix deprecated ContentRenderer::getParserOutput in benchmarkParse.phpmediawiki/coremaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Aug 21 2025, 10:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2025, 10:10 PM
Krinkle updated the task description. (Show Details)Aug 21 2025, 10:18 PM
Tgr subscribed.Aug 22 2025, 7:42 AM

T384232: QA for SUL3 on testwikis has a checklist for testing the auth stack that can be reused.

Krinkle added a comment.Aug 22 2025, 2:48 PM

I've ticked off the libaries (BagOStuff, StatsLib, cssjanus, less.php, minify, relpath, wrappedstring) because they:

  • have ~100% test coverage in CI,
  • and their CI runs on all supported PHP versions (8.1, 8.2, 8.3, and 8.4),
  • and have no untested configuration options, subclasses, events, or hooks that we use in production,
  • and are low level components that have no user journey of their own - they power other features instead.

I've also ticked off Profiler because I covered that in T400109: Ensure MediaWiki-Core-Profiler works with php-xhprof 2.x (PHP 8.3). That was locally rather than in prod, but that's good enough for a debug tool.

Krinkle updated the task description. (Show Details)Aug 22 2025, 2:48 PM
Krinkle updated the task description. (Show Details)Aug 22 2025, 2:53 PM
Tgr mentioned this in T402804: Exploratory testing on PHP 8.3 for MediaWiki authentication stack.Aug 25 2025, 1:41 PM
Tgr added a comment.Aug 25 2025, 1:45 PM
In T402597#11109677, @Tgr wrote:

T384232: QA for SUL3 on testwikis has a checklist for testing the auth stack that can be reused.

Created T402804: Exploratory testing on PHP 8.3 for MediaWiki authentication stack based on that.

Krinkle mentioned this in T402809: Exploratory testing on PHP 8.3 for MediaWiki Interfaces Team components.Aug 25 2025, 1:58 PM
Krinkle mentioned this in T402810: Exploratory testing on PHP 8.3 for Content Transform Team components.Aug 25 2025, 2:12 PM
OWresch-WMF moved this task from Inbox, needs triage to Next on the MediaWiki-Platform-Team board.Aug 25 2025, 2:30 PM
Krinkle added a comment.Sep 1 2025, 12:58 PM

Finished testing for ResourceLoader via WikimediaDebug on PHP 8.3 with browser caching disabled in devtools:

LGTM.

Krinkle updated the task description. (Show Details)Sep 1 2025, 12:58 PM
Krinkle updated the task description. (Show Details)Sep 1 2025, 1:23 PM
Krinkle added a comment.Sep 1 2025, 1:27 PM

Finished testing of php-excimer by loading https://en.wikipedia.org/wiki/Special:Version.

LGTM.

Tgr mentioned this in T403484: Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Login.Sep 2 2025, 2:03 PM
Tgr mentioned this in T403485: Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Central session.
Tgr mentioned this in T403486: Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Signup.
Tgr mentioned this in T403487: Exploratory testing on PHP 8.3 for MediaWiki authentication stack: OAuth.
Tgr mentioned this in T403488: Exploratory testing on PHP 8.3 for MediaWiki authentication stack: 2FA.Sep 2 2025, 2:05 PM
gerritbot added a comment.Sep 5 2025, 3:35 PM

Change #1185122 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] benchmarks: Fix deprecated ContentRenderer::getParserOutput in benchmarkParse.php

https://gerrit.wikimedia.org/r/1185122

gerritbot added a project: Patch-For-Review.Sep 5 2025, 3:36 PM
Krinkle updated the task description. (Show Details)Sep 5 2025, 3:36 PM
Krinkle added a comment.Sep 5 2025, 3:48 PM

Ticked off Benchmarker. Tested locally on PHP 8.3. Note that this is a component specifically for CLI use. (There is no web UI in prod, e.g. via WikimediaDebug).

Tested as follows:

$ php maintenance/benchmarks/
README.md                      benchmarkHooks.php             benchmarkLruHash.php           benchmarkSanitizer.php         benchmarkTitleValue.php        
benchmarkCommentFormatter.php  benchmarkJsValidate.php        benchmarkParse.php             benchmarkSettings.php          benchmarkTruncate.php          
benchmarkEval.php              benchmarkJsonCodec.php         benchmarkPurge.php             benchmarkTidy.php              data/                      

$ php maintenance/benchmarks/benchmarkEval.php -e 'ucfirst("foo");' --inner 10_000 --count 200 

Running PHP version 8.3.24 (arm64) on Darwin 24.4.0 …

eval
   count: 200
    rate:   4545.2/s
   total:    44.00ms
    mean:     0.22ms
     max:     0.26ms
  stddev:     0.01ms
Current memory usage: 20.00 MiB
   Peak memory usage: 20.00 MiB

$ php maintenance/benchmarks/benchmarkLruHash.php 

Running PHP version 8.3.24 (arm64) on Darwin 24.4.0 …

HashBagOStuff::__construct
   count: 1000
    rate: 1060238.6/s
   total:     0.94ms
    mean:     0.00ms
     max:     0.00ms
  stddev:     0.00ms
Current memory usage: 20.00 MiB
   Peak memory usage: 20.00 MiB

MapCacheLRU::__construct
   count: 1000
    rate: 5777278.2/s
   total:     0.17ms
    mean:     0.00ms
     max:     0.00ms
  stddev:     0.00ms
Current memory usage: 20.00 MiB
   Peak memory usage: 20.00 MiB

…

HashBagOStuff::get
   count: 1000
    rate:   3896.7/s
   total:   256.63ms
    mean:     0.26ms
     max:     0.31ms
  stddev:     0.01ms
Current memory usage: 20.00 MiB
   Peak memory usage: 20.00 MiB

MapCacheLRU::get
   count: 1000
    rate:   5672.9/s
   total:   176.28ms
    mean:     0.18ms
     max:     0.22ms
  stddev:     0.01ms
Current memory usage: 20.00 MiB
   Peak memory usage: 20.00 MiB

$ php maintenance/benchmarks/benchmarkTitleValue.php --count=100000

Running PHP version 8.3.24 (arm64) on Darwin 24.4.0 …

BenchmarkTitleValue::constructTitleValue()
   count: 100000
    rate: 2146840.6/s
   total:    46.58ms
    mean:     0.00ms
     max:     0.03ms
  stddev:     0.00ms
Current memory usage: 20.00 MiB
   Peak memory usage: 20.00 MiB

BenchmarkTitleValue::constructTitle()
   count: 100000
    rate: 1531175.8/s
   total:    65.31ms
    mean:     0.00ms
     max:     0.02ms
  stddev:     0.00ms
Current memory usage: 20.00 MiB
   Peak memory usage: 20.00 MiB

$ php maintenance/benchmarks/benchmarkParse.php Main_Page                                               

CPU time = 0.003 s, wall clock time = 0.127 s

$ php maintenance/benchmarks/benchmarkTidy.php           

24 MB
…
Run 2: 104.77948188782
50.5 MB
…
Run 3: 102.95639038086
56.5 MB
…
Run 4: 103.82349491119
64.5 MB
…
Run 5: 103.08699607849
70.5 MB
…
Run 6: 103.78789901733
78.5 MB
…
Run 8: 103.75008583069
92.5 MB
…
106.5 MB
Run 10: 103.7367105484

Minimum: 102.9461145401 ms
Median: 103.74339818954 ms
Mean: 104.36684608459 ms
Maximum: 111.1142873764 ms
Memory usage: 106.5 MB
Peak memory usage: 106.5 MB
Tgr closed subtask T402804: Exploratory testing on PHP 8.3 for MediaWiki authentication stack as Resolved.Sep 8 2025, 8:36 PM
Tgr updated the task description. (Show Details)
Tgr added a comment.Sep 8 2025, 8:42 PM

I think we can skip Notifications and OAuthRateLimiter which don't do anything interesting (from the POV of changing PHP features), and php-session-serializer (which does interesting things but has 100% test coverage).

We should probably test the patch for T363639: web-auth/webauthn-lib must be upgraded to 4+ for PHP 8.2+ support though (once it's done) - it adds a bunch of new libraries which involve encryption and such.

gerritbot added a comment.Sep 9 2025, 8:48 AM

Change #1185122 merged by jenkins-bot:

[mediawiki/core@master] benchmarks: Fix deprecated ContentRenderer::getParserOutput in benchmarkParse.php

https://gerrit.wikimedia.org/r/1185122

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.19; 2025-09-16).Sep 9 2025, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sep 9 2025, 9:31 AM
Krinkle closed this task as Resolved.Sep 9 2025, 3:47 PM
Krinkle assigned this task to Tgr.
Krinkle updated the task description. (Show Details)

Thanks!

Krinkle mentioned this in T360995: Migrate Wikimedia production from PHP 8.1 to PHP 8.3.Sep 11 2025, 6:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits