[MEX] M3.1.2 - Left-to-right languages are supported
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	karapayneWMDE
	Aug 22 2025, 10:04 AM

Description

As a wikidata editor
I want my interface to be in the language I select while editing on mobile
So that I can feel confident while editing

A/C

left-to-right displayed languages match the figma file
the mobile version matches the desktop version in terms of which languages are supported
users can switch languages by using the "language" button on the home page of wikidata
unit tests are created/updated

Notes:

To change interface language on mobile, you must go to the home page, scroll to the bottom and tap "Language", then select a new language. This matches the functionality on wikipedia
- (!) When language is changed on wikidata.beta.wmcloud.org, you are redirected to wikipedia's homepage
right-to-left designs are not yet completed (2025-aug-27) but will be handled in T403013: [MEX] M3 - Right-to-left languages are supported

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Add message for edit statement dialog header	mediawiki/extensions/Wikibase	master	+4 -1
Refactor editStatementGroup Jest tests	mediawiki/extensions/Wikibase	master	+16 -10
Respect $wgEditSubmitButtonLabelPublish	mediawiki/extensions/Wikibase	master	+27 -2
Remove placeholder from statement value input	mediawiki/extensions/Wikibase	master	+1 -1
Use messages for edit statement dialog	mediawiki/extensions/Wikibase	master	+16 -9
Use wikibase-edit message for edit link	mediawiki/extensions/Wikibase	master	+8 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T394621 [MEX] Mobile Editing Experience of Items Project
Open	None	T400128 [MEX] M3 - Create editing functionality for statements on Items on mobile
Open	None	T400129 [MEX] M3.1 edit function for a simple text input
Resolved	karapayneWMDE	T401700 [MEX] M3.1.1 First Pass - Edit Functionality Simple text input (string)
Resolved	karapayneWMDE	T401702 [MEX] M3.1.2 Functional- Edit Functionality Simple text input (string)
Resolved	Arian_Bozorg	T402630 [MEX] M3.1.2 - Left-to-right languages are supported

Event Timeline

karapayneWMDE created this task.Aug 22 2025, 10:04 AM

karapayneWMDE moved this task from Incoming to MEX Incoming column on the Wikidata-Omega board.Aug 22 2025, 10:11 AM

karapayneWMDE updated the task description. (Show Details)Aug 27 2025, 8:58 AM

karapayneWMDE renamed this task from [MEX] M3.1.2 - Multiple languages are supported to [MEX] M3.1.2 - Left-to-right languages are supported.Aug 27 2025, 9:26 AM

karapayneWMDE updated the task description. (Show Details)

karapayneWMDE updated the task description. (Show Details)Aug 27 2025, 9:34 AM

karapayneWMDE moved this task from MEX Incoming column to Ready for Task Time (Story Writing) on the Wikidata-Omega board.Aug 28 2025, 10:51 AM

karapayneWMDE moved this task from Ready for Task Time (Story Writing) to The Backlog on the Wikidata-Omega board.Aug 29 2025, 12:59 PM

Lucas_Werkmeister_WMDE claimed this task.Sep 1 2025, 10:09 AM

Lucas_Werkmeister_WMDE edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.

Lucas_Werkmeister_WMDE moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.

Change #1183631 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use wikibase-edit message for edit link

https://gerrit.wikimedia.org/r/1183631

gerritbot added a project: Patch-For-Review.Sep 1 2025, 10:38 AM

Change #1183651 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use messages for edit statement dialog

https://gerrit.wikimedia.org/r/1183651

Question (probably for @Alice.moutinho or @Arian_Bozorg): Does the input field for the statement value (T402447) have a placeholder, and if yes, what is it? The current dialog has “add property value here”, but I feel like that’s probably just something Arthur made up for the prototype, because I don’t see it in Figma anywhere – and I don’t see an empty input field in any of the dev-ready components (they all have a value already filled in AFAICT).

And can you confirm that the “edit statement” (or “add statement”) heading is part of the intended UI and we should define a translatable message for it?

Should be ready for review apart from the two messages mentioned above.

@LucasWerkmeister Hi Lucas, just user the same copy we have on desktop - here and anywhere else where there is copy and there are doubts. Edit statement and add statement are part of the UI. (ps. i was never here )

Lucas_Werkmeister_WMDE removed a subscriber: LucasWerkmeister.Sep 1 2025, 3:34 PM

Change #1183631 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use wikibase-edit message for edit link

https://gerrit.wikimedia.org/r/1183631

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.17; 2025-09-02).Sep 1 2025, 5:00 PM

Actually, about that “edit statement” heading… are we sure about that? Because I just realized it’s really perpetuating the same misunderstanding as in T403184. You’re editing more than one statement (in internal terminology, a statement group) – in this screenshot, “singer” and “songwriter” are separate “occupation” statements:

I would probably phrase this example as something like “edit occupation(s)” – but there’s no way we can make anything like that work for thousands of properties across hundreds of languages… but I think “edit statements” would at least be more correct than “edit statement”?

The desktop UI uses very similar terminology, but I think it’s at least a bit closer to being technically correct. The button (link) at the bottom says “add statement”, but that’s correct because it really only lets you add one statement for the selected property – you can’t add a second statement until you’ve saved the first one. I would say that the “add value” button/link really adds another statement, but calling it “value” isn’t really wrong here I guess. And there’s no heading or button for editing the whole statement group at once. (I don’t think the desktop UI uses the term “statement group” anywhere, except in a handful of message keys that ordinary users never see. In Lua we speak of the “statements” of an entity + property.).

Change #1184047 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove placeholder from statement value input

https://gerrit.wikimedia.org/r/1184047

Change #1184048 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Respect $wgEditSubmitButtonLabelPublish

https://gerrit.wikimedia.org/r/1184048

Change #1184083 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Refactor editStatementGroup Jest tests

https://gerrit.wikimedia.org/r/1184083

ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.Sep 3 2025, 10:02 AM

ArthurTaylor claimed this task.Sep 3 2025, 10:18 AM

Change #1183651 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use messages for edit statement dialog

https://gerrit.wikimedia.org/r/1183651

Change #1184047 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove placeholder from statement value input

https://gerrit.wikimedia.org/r/1184047

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.18; 2025-09-09); removed MW-1.45-notes (1.45.0-wmf.17; 2025-09-02).Sep 3 2025, 11:00 AM

Change #1184083 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Refactor editStatementGroup Jest tests

https://gerrit.wikimedia.org/r/1184083

Change #1184048 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Respect $wgEditSubmitButtonLabelPublish

https://gerrit.wikimedia.org/r/1184048

I think this is done except for the “edit statement” heading (T402630#11138088), which is waiting for feedback from Product / UX. Not sure which column would be best for this task in the meantime…

Yeah - it's basically done. Let's leave it here for today. Latest tomorrow at standup I will try and get clarification from @Arian_Bozorg and we can decide what to do with it.

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2025, 11:31 AM

Sorry, let's leave it as is for now and I will look at it with Alice as we move into the refinement stages of the project

ArthurTaylor moved this task from In Peer Review to Product Verification on the Wikidata-Omega (The Board) board.Sep 4 2025, 10:10 AM

ArthurTaylor removed ArthurTaylor as the assignee of this task.Sep 5 2025, 7:27 AM

Hi @LucasWerkmeister,

I see your point. Thank you for clearing that up. I thought the statement was "occupation" and singer and songwriter where ... sub-statements? because of the way the prototype i have been reworking was set up:

Screenshot 2025-09-08 at 09.02.43.png (678×732 px, 61 KB)

But if sometimes one block is more than one statement, then the title is indeed misleading.

Is it possible to differentiate between blocks with only one statement (that does occur, or?) and blocks with multiple statements? so that we could have singular "edit statement" when it is one, and plural "edit statements" if its several? like this we would be always correct!

If this is not possible, then we should go with plural as you suggested.

Lucas_Werkmeister_WMDE removed a subscriber: LucasWerkmeister.Sep 10 2025, 11:30 AM

In T402630#11156159, @Alice.moutinho wrote:

Is it possible to differentiate between blocks with only one statement (that does occur, or?) and blocks with multiple statements? so that we could have singular "edit statement" when it is one, and plural "edit statements" if its several? like this we would be always correct!

It’s always technically possible to have more than one statement with the same property (though it can be discouraged via constraints, or encouraged for that matter).

We could make the heading depend on the number of statements (“edit {{PLURAL:$1|statement|statements}}”) – show “edit statement” when adding a new statement or editing a statement group with just one statement, and change it to “edit statements” if the statement group has multiple statements or the user starts to add another statement.

That sounds like a simple and elegant solution to this

Lucas_Werkmeister_WMDE claimed this task.Sep 11 2025, 1:42 PM

Lucas_Werkmeister_WMDE moved this task from Product Verification to In Development on the Wikidata-Omega (The Board) board.

Change #1187446 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Add message for edit statement dialog header

https://gerrit.wikimedia.org/r/1187446

gerritbot added a project: Patch-For-Review.Sep 11 2025, 1:53 PM

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Sep 11 2025, 1:53 PM

Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.

ArthurTaylor claimed this task.Sep 12 2025, 6:37 AM

ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.

ArthurTaylor removed ArthurTaylor as the assignee of this task.Sep 12 2025, 8:16 AM

ArthurTaylor moved this task from In Peer Review to Product Verification on the Wikidata-Omega (The Board) board.

Change #1187446 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add message for edit statement dialog header

https://gerrit.wikimedia.org/r/1187446

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.19; 2025-09-16); removed MW-1.45-notes (1.45.0-wmf.18; 2025-09-09).Sep 12 2025, 9:01 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 12 2025, 9:30 AM

Arian_Bozorg closed this task as Resolved.Sep 18 2025, 8:53 AM

Arian_Bozorg claimed this task.

Arian_Bozorg moved this task from Product Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.

Lucas_Werkmeister_WMDE edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega (The Board).Nov 28 2025, 11:49 AM

	F65984574: Screenshot 2025-09-08 at 09.02.43.png
	Sep 8 2025, 7:07 AM

	F65947560: image.png
	Sep 2 2025, 9:29 AM

[MEX] M3.1.2 - Left-to-right languages are supportedClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

[MEX] M3.1.2 - Left-to-right languages are supported
Closed, ResolvedPublic
Actions

Related Objects
Search...