ConfirmAccount checks the skipcaptcha right directly
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Aug 22 2025, 11:56 AM

Description

As a follow on to T398850: Class "ReCaptchaNoCaptcha" not found, ConfirmAccount probably shoudn't be checking the skipcaptcha right directly, it should use SimpleCaptcha::canSkipCaptcha

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Don't check the skipcaptcha right directly	mediawiki/extensions/ConfirmAccount	REL1_43	+10 -6
Don't check the skipcaptcha right directly	mediawiki/extensions/ConfirmAccount	REL1_44	+10 -6
Don't check the skipcaptcha right directly	mediawiki/extensions/ConfirmAccount	master	+10 -6

Customize query in gerrit

Related Objects

Mentioned Here: T398850: Class "ReCaptchaNoCaptcha" not found

Event Timeline

Reedy created this task.Aug 22 2025, 11:56 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2025, 11:56 AM

Change #1181118 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmAccount@master] Don't check the skipcaptcha right directly

https://gerrit.wikimedia.org/r/1181118

gerritbot added a project: Patch-For-Review.Aug 22 2025, 11:57 AM

Change #1181118 merged by jenkins-bot:

[mediawiki/extensions/ConfirmAccount@master] Don't check the skipcaptcha right directly

https://gerrit.wikimedia.org/r/1181118

Maintenance_bot removed a project: Patch-For-Review.Aug 27 2025, 3:30 AM

Change #1182546 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmAccount@REL1_44] Don't check the skipcaptcha right directly

https://gerrit.wikimedia.org/r/1182546

Change #1182548 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ConfirmAccount@REL1_43] Don't check the skipcaptcha right directly

https://gerrit.wikimedia.org/r/1182548

Change #1182546 merged by jenkins-bot:

[mediawiki/extensions/ConfirmAccount@REL1_44] Don't check the skipcaptcha right directly

https://gerrit.wikimedia.org/r/1182546

Reedy closed this task as Resolved.Aug 27 2025, 1:23 PM

Reedy claimed this task.

Change #1182548 merged by jenkins-bot: