Page MenuHomePhabricator

[PCS] Fix/improve fetching of site-specific CSS.
Open, Needs TriagePublic

Description

One of the CSS bundles provided by PCS is site-specific CSS: /data/css/mobile/site, as defined by each language wiki.

However, it looks like the service is currently fetching desktop-specific site CSS (from Common.css) instead of the more-desirable mobile-specific CSS (Mobile.css and/or Minerva.css).

This hasn't necessarily caused any issues so far, since desktop and mobile CSS likely overlaps quite a bit, but updating the service to return the proper CSS will surely align it more with the expected mobile presentation.

Event Timeline

Change #1181174 had a related patch set uploaded (by Dbrant; author: Dbrant):

[mediawiki/services/mobileapps@master] Improve fetching of site-specific styles.

https://gerrit.wikimedia.org/r/1181174

A couple things about that patch.

  1. The mobile domain sunsetting (accepted) RFC needs review (and perhaps the attached tasks). Introducing a dependency on the m. website seems like an error at this time.
  2. There's probably merit to reviewing how MobileFrontend decides what CSS/JS to load, since there are configuration options in that context which stop loading the mobile web resources and which perhaps more importantly for this task start loading the common.X ones. The relevant config is already enabled on MediaWiki wiki and en.wp presently has a task open that should be going through SoonTM (T375538 with some other perhaps-interesting links). See here, here, and possibly here.

A couple things about that patch.

Thanks for that context! Will keep an eye on these developments, and adjust the PCS-side logic accordingly.