Page MenuHomePhabricator

Call to undefined method DummyContentForTesting::getText() in CargoHooks.php
Closed, ResolvedPublicBUG REPORT

Description

The DerivedPageDataUpdaterTest fails with Cargo.

$ ./vendor/bin/phpunit tests/phpunit/includes/Storage/DerivedPageDataUpdaterTest.php
Using PHP 8.3.6
Running with MediaWiki settings because there might be integration tests
PHPUnit 9.6.21 by Sebastian Bergmann and contributors.

...........E............................................          56 / 56 (100%)

Time: 00:07.286, Memory: 79.00 MB

There was 1 error:

1) MediaWiki\Tests\Storage\DerivedPageDataUpdaterTest::testAvoidSecondaryDataUpdatesOnNonHTMLContentHandlers
Error: Call to undefined method DummyContentForTesting::getText()

mediawiki/extensions/Cargo/CargoHooks.php:275
mediawiki/includes/HookContainer/HookContainer.php:155
mediawiki/includes/HookContainer/HookRunner.php:3270
mediawiki/includes/Storage/PageUpdater.php:1729
mediawiki/includes/libs/rdbms/database/Database.php:2334
mediawiki/includes/libs/rdbms/database/DBConnRef.php:127
mediawiki/includes/libs/rdbms/database/DBConnRef.php:754
mediawiki/includes/deferred/AtomicSectionUpdate.php:41
mediawiki/includes/deferred/DeferredUpdates.php:459
mediawiki/includes/deferred/DeferredUpdates.php:201
mediawiki/includes/deferred/DeferredUpdates.php:288
mediawiki/includes/deferred/DeferredUpdatesScope.php:243
mediawiki/includes/deferred/DeferredUpdatesScope.php:172
mediawiki/includes/deferred/DeferredUpdates.php:282
mediawiki/includes/deferred/DeferredUpdates.php:373
mediawiki/includes/deferred/DeferredUpdates.php:156
mediawiki/includes/deferred/DeferredUpdates.php:179
mediawiki/includes/Storage/PageUpdater.php:990
mediawiki/tests/phpunit/includes/Storage/DerivedPageDataUpdaterTest.php:132
mediawiki/tests/phpunit/includes/Storage/DerivedPageDataUpdaterTest.php:677

Event Timeline

Also this one (and a few others it looks like):

$ ./vendor/bin/phpunit tests/phpunit/includes/api/ApiEditPageTest.php 
Using PHP 8.3.6
Running with MediaWiki settings because there might be integration tests
PHPUnit 9.6.21 by Sebastian Bergmann and contributors.

.........................E....................................... 65 / 78 ( 83%)
.............                                                     78 / 78 (100%)

Time: 00:16.135, Memory: 74.50 MB

There was 1 error:

1) MediaWiki\Tests\Api\ApiEditPageTest::testSupportsDirectApiEditing_withContentHandlerOverride
Error: Call to undefined method DummyNonTextContent::getText()

mediawiki/extensions/Cargo/CargoHooks.php:275
mediawiki/includes/HookContainer/HookContainer.php:155
mediawiki/includes/HookContainer/HookRunner.php:3270
mediawiki/includes/Storage/PageUpdater.php:1729
mediawiki/includes/libs/rdbms/database/Database.php:2334
mediawiki/includes/libs/rdbms/database/DBConnRef.php:127
mediawiki/includes/libs/rdbms/database/DBConnRef.php:754
mediawiki/includes/deferred/AtomicSectionUpdate.php:41
mediawiki/includes/deferred/DeferredUpdates.php:459
mediawiki/includes/deferred/DeferredUpdates.php:201
mediawiki/includes/deferred/DeferredUpdates.php:288
mediawiki/includes/deferred/DeferredUpdatesScope.php:243
mediawiki/includes/deferred/DeferredUpdatesScope.php:172
mediawiki/includes/deferred/DeferredUpdates.php:282
mediawiki/includes/deferred/DeferredUpdates.php:373
mediawiki/includes/deferred/DeferredUpdates.php:156
mediawiki/includes/deferred/DeferredUpdates.php:179
mediawiki/includes/Storage/PageUpdater.php:990
mediawiki/includes/editpage/EditPage.php:2561
mediawiki/includes/editpage/EditPage.php:1833
mediawiki/includes/api/ApiEditPage.php:540
mediawiki/includes/api/ApiMain.php:2033
mediawiki/includes/api/ApiMain.php:924
mediawiki/tests/phpunit/includes/api/ApiTestCase.php:186
mediawiki/tests/phpunit/includes/api/ApiTestCase.php:239
mediawiki/tests/phpunit/includes/api/ApiEditPageTest.php:691

Change #1181268 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Cargo@master] Only run PageSaveComplete on wikitext content types

https://gerrit.wikimedia.org/r/1181268

Change #1181268 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Only run PageSaveComplete on wikitext content types

https://gerrit.wikimedia.org/r/1181268

Samwilson claimed this task.

Possible that this patch results in a minor regression with non-wikitext pages no longer saving records to special tables like _pageData. Posting this just to document the difference, I don't think it's really significant.