Page MenuHomePhabricator

Recent changes's "view new changes" can cause odd wrapping at some viewport widths
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
Perryprog
Aug 24 2025, 7:24 PM
Referenced Files
F65926494: Screen Recording 2025-08-28 at 12.57.29.mov
Aug 28 2025, 3:14 PM
F65925620: Top section.png
Aug 28 2025, 11:03 AM
F65925615: Screen Recording 2025-08-28 at 12.57.29.mov
Aug 28 2025, 11:03 AM
F65911598: image.png
Aug 25 2025, 9:05 PM
F65911024: image.png
Aug 25 2025, 6:33 PM
F65906671: image.png
Aug 24 2025, 7:32 PM
F65906607: image.png
Aug 24 2025, 7:24 PM
F65906605: image.png
Aug 24 2025, 7:24 PM

Description

In certain viewport widths, especially on the wider side, the recent changes controls can wrap and space itself in unexpected ways.

image.png (288×1 px, 187 KB)

image.png (184×1 px, 53 KB)

image.png (366×1 px, 64 KB)

It seems like this is partially due to a hidden (via visibility, not display) "group results by page" which seems to be an experimentation labs thing.

I'll take a stab at resolving this; I think I'll just make it so that this whole flexbox doesn't try to space things evenly. Since "live update" and "view new changes" are closely related, I'll shift it to be like this:

image.png (214×1 px, 60 KB)

One other potential solution would be to just use display: none instead of visibility: hidden if that's something that's okay with this control. This will still lead to some odd wrapping, but there's likely some finagling that can be done to make it work.

image.png (172×1 px, 43 KB)

Event Timeline

Change #1181293 had a related patch set uploaded (by Perryprog; author: Perryprog):

[mediawiki/skins/Timeless@master] rc: adjust alignment of recent changes controls

https://gerrit.wikimedia.org/r/1181293

matmarex subscribed.

I don't think anything here is specific to Timeless, I see the same problem on Vector 2022:

image.png (965×1 px, 140 KB)

We shouldn't patch it in Timeless, since I am sure that no one will update that if the core styles changes, which they probably will once more people notice this bug. It should be fixed in MediaWiki core.

Ah! I wasn't able to reproduce it in Vector, though maybe I didn't try with the right window width since it was just a quick check. (Edit: yup, it happens just below my normal browser width on Vector.)

I am sure that no one will update that if the core styles changes

I will! (If I'm active. Probably.)

Will take a closer look soonish.

Change #1181293 abandoned by Perryprog:

[mediawiki/skins/Timeless@master] rc: adjust alignment of recent changes controls

Reason:

To be fixed in core.

https://gerrit.wikimedia.org/r/1181293

Change #1181774 had a related patch set uploaded (by Perryprog; author: Perryprog):

[mediawiki/core@master] rc: adjust alignment of recent changes controls

https://gerrit.wikimedia.org/r/1181774

Perryprog renamed this task from Recent changes's "view new changes" can cause odd wrapping in Timeless to Recent changes's "view new changes" can cause odd wrapping at some viewport widths.Aug 25 2025, 8:58 PM
Perryprog updated the task description. (Show Details)

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://95edba3cb0.catalyst.wmcloud.org/w/

Kgraessle added subscribers: OTichonova, Kgraessle.

@OTichonova

I created a patch demo so you can see the proposed design changes to the layout for RecentChanges that fixes this bug.
Let me know what you think about this new design and if so I can +2 this patch.

@OTichonova

I created a patch demo so you can see the proposed design changes to the layout for RecentChanges that fixes this bug.
Let me know what you think about this new design and if so I can +2 this patch.

Thank you @Kgraessle. In the patch demo, as the screen shrinks, the time period filter button moves a couple of times up and down (above and below the ‘view new change since…’ text) (video here).
Currenlty, in recent changes the 3 elements move around quite a bit as well (video here). 
I was wondering if it would be possible to: 


  • Keep the text in the center between the 2 buttons at wider screen widths?
  • Once the width becomes too small for all 3 elements to be side by side, have them stack in the following way -> 2 buttons on top (each aligning right/left side of the screen) and the text below? This would be similar to how it is on mobile web. This way, there would be less movement of the elements with different screen sizes?
Top section.png (388×508 px, 27 KB)

Hmm. The tricky part is that there's a hidden element which is currently set as invisible but still reserves space (I'm not sure why it's set to take up space. Since I assume there is a plan to maybe make that control visible, I would suspect that it's necessary to also design around its layout as well? Here's what a video of what the layout looks like with that element visible:

The second note would I think be harder, and it would require changing the DOM structure which I think would be a breaking change, if that's okay. It's made especially tricky due to the hidden element since the mockup wouldn't have space for it in that example, but again I don't know if we need to worry about that.

Hmm. The tricky part is that there's a hidden element which is currently set as invisible but still reserves space (I'm not sure why it's set to take up space. Since I assume there is a plan to maybe make that control visible, I would suspect that it's necessary to also design around its layout as well? Here's what a video of what the layout looks like with that element visible:

The second note would I think be harder, and it would require changing the DOM structure which I think would be a breaking change, if that's okay. It's made especially tricky due to the hidden element since the mockup wouldn't have space for it in that example, but again I don't know if we need to worry about that.

We are planning to end this experiment no later than 9/15, so I suggest that we live with it as it is for now and take this into account ahead of our next experiment.

We are planning to end this experiment no later than 9/15, so I suggest that we live with it as it is for now and take this into account ahead of our next experiment.

Hm, alright—can you confirm that when the experiment is ended that the hidden control (.mw-rcfilters-ui-groupByToggleWidget) is going to be fully removed from the DOM?

Change #1181774 abandoned by Perryprog:

[mediawiki/core@master] rc: adjust alignment of recent changes controls

Reason:

In favor of Ifddf70a715a4cdc97e6e8a233b3397e02e3bfb9a.

https://gerrit.wikimedia.org/r/1181774

Resolved on testwiki.

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

https://95edba3cb0.catalyst.wmcloud.org/w/