Tagging DT for information, since we're going to use the API here.

If you want to use the DT API for something like this, we might want to prioritize T416038 (patch) to give you an overview API, rather than making you basically fetch the full text of each discussion page to dig through it.

@DLynch, this would be ideal for this module! I have just started working on this and can focus on the UI side while we wait for T416038: Provide an API for basic data about a talk page to be merged.

To make room for this module on desktop we can: T416690: Reduce 'Review changes' suggestion list from 10 edits to 5 on desktop.

Change #1239277 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PersonalDashboard@master] Create Active Discussions module

https://gerrit.wikimedia.org/r/1239277

T416038: Provide an API for basic data about a talk page is now merged!

@Samwalton9-WMF on the mobile view: do we need the "view more things" button at the bottom that links to the same view as clicking anywhere in the module?

Good question, discussing here too - T417757#11644192

@Scardenasmolinar The footer button is showing a placeholder message in my local environment. It seems like the message key wasn't added to the messages array in extension.json. Perhaps i18n/ext.personalDashboard.activeDiscussions.mobile could be merged into i18n/ext.personalDashboard.activeDiscussions since there is no longer a resources/ext.personalDashboard.activeDiscussions.mobile directory?

In T402781#11670317, @Dillon wrote:

@Scardenasmolinar The footer button is showing a placeholder message in my local environment. It seems like the message key wasn't added to the messages array in extension.json. Perhaps i18n/ext.personalDashboard.activeDiscussions.mobile could be merged into i18n/ext.personalDashboard.activeDiscussions since there is no longer a resources/ext.personalDashboard.activeDiscussions.mobile directory?

I noticed that and almost have a patch to fix this.

That error has been fixed, and everything seems to be working fine, but I am getting a console error on the mobile version:

Not sure why this is happening. Maybe a race condition?

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://48fca55624.catalyst.wmcloud.org/w/

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

https://48fca55624.catalyst.wmcloud.org/w/

Minor design fixes:

Desktop:

In the figma it looks like the person icon and the discussion bubble icon are aligned on the right side. Also I think the page title text should have less padding on top.

Mobile:

It looks like we're missing the subheader text here, also the icons should wrap to a new row in the mobile design.

Mobile Summary:
We should probably also limit the amount of text that shows up here:

All views:
Timestamp of active discussion is underlined.

It looks like we're missing the subheader text here, also the icons should wrap to a new row in the mobile design.

I know it's part of the design, but it's not showing in the Recent Activity or the Policies module either. Maybe this is a bug?

Other than that, I think I addressed most of the bugs, with the exception of the icons wrapping:

Test wiki created on Patch demo by Samwalton9 (WMF) using patch(es) linked to this task:
https://35d4e842e6.catalyst.wmcloud.org/w/

Thanks for fixing the above issues, it's looking really great!
I did notice a few more design changes upon second review:

It looks like the timestamp formatting is the same as Recent Activity module and not the discussion tools formatting:

Current format:

Desired format (maybe?) @Samwalton9-WMF :

The other thing I noticed is that the border around the cards in figma is more like the Policy Module (e.g: the border edges are around the entire card vs missing left/right borders).

Regarding timestamps, in the design mockups I used the format that DiscussionTools uses in its section subheadings:

Is it possible to copy the logic to display e.g. "4 minutes ago" instead of a specific time/day?

I don't mind punting this to a follow-up ticket.

The other thing I noticed is that the border around the cards in figma is more like the Policy Module (e.g: the border edges are around the entire card vs missing left/right borders).

@Samwalton9-WMF, before making this change, I want to make sure if I should. I ask because the design resembles the Policies module, but the Policies module rows are not clickable. The behavior is the same as the Risky Edits module, which doesn't have side borders per row. Should I add them?

I don't have strong opinions on this but I can see the argument for having the same design as the Review Changes module, let's do it!

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://a1d0f1093a.catalyst.wmcloud.org/w/

Hi,
It looks like the icons are not aligning to the right and there's some extra spacing between them as well.
Attaching screenshots:

Mobile:

Desktop:

That's weird. I think that was from one patch that was out of date because this is what I'm seeing with my latest version:

In T402781#11704025, @Scardenasmolinar wrote:

That's weird. I think that was from one patch that was out of date because this is what I'm seeing with my latest version:

Oh strange, it looks great now.

I did notice one small thing in that screenshot you posted above, the list card border goes all the way to the right which is different from Review Changes module.

Other than that I'm good to +2 this once we've chatted about feature flag strategy for rolling out new modules. Thanks for all your work on this module.

I have added a feature flag to soft-launch this module. If you add personaldashboard_activediscussions_show=true as a URL parameter, then the module will show up.

Hi, a few styling things I noticed.

In the mobile summary view there's some extra padding above the Active Discussions module.
Also, it looks like the risky article edits card has a border around it now, I fixed this locally by updating the .cdx-card selector in the ListCardMobile.vue, do you mind adding this to your patch before we merge it?

.cdx-card.ext-personal-dashboard-moderation-card-mobile-summary {
	border: unset;
	border-bottom: unset;

	&.cdx-card {
		padding: 0 0 1rem 0;
	}

	&:hover {
		background-color: unset;
	}

	&.cdx-button {
		font-size: @font-size-medium;
	}
}

Also the border on the list card for active discussions goes all the way to the right:

In T402781#11717827, @Kgraessle wrote:

Hi, a few styling things I noticed.

In the mobile summary view there's some extra padding above the Active Discussions module.
Also, it looks like the risky article edits card has a border around it now, I fixed this locally by updating the .cdx-card selector in the ListCardMobile.vue, do you mind adding this to your patch before we merge it?

.cdx-card.ext-personal-dashboard-moderation-card-mobile-summary {
	border: unset;
	border-bottom: unset;

	&.cdx-card {
		padding: 0 0 1rem 0;
	}

	&:hover {
		background-color: unset;
	}

	&.cdx-button {
		font-size: @font-size-medium;
	}
}

Also the border on the list card for active discussions goes all the way to the right:

Done! Thanks for catching that!

Change #1239277 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Create Active Discussions module

https://gerrit.wikimedia.org/r/1239277

Change #1255967 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PersonalDashboard@master] Change wgPersonalDashboardActiveDiscussionsPages from key-value to array

https://gerrit.wikimedia.org/r/1255967

Change #1255967 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PersonalDashboard@master] Change wgPersonalDashboardActiveDiscussionsPages from key-value to array

https://gerrit.wikimedia.org/r/1255967

Change #1255967 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Change wgPersonalDashboardActiveDiscussionsPages from key-value to array

https://gerrit.wikimedia.org/r/1255967