Page MenuHomePhabricator

Tone Check: Tone check does not get activated anymore once it gets declined for a single instance of tone violation
Open, Needs TriagePublic

Description

Steps to reproduce:

  1. Add a tone violating sentence to a paragraph
  2. Put your cursor inside a different paragraph to activate tone check.
  3. Click on "Decline"
  4. Select the last response stating it's not violating the tone.
  5. Add the same or a different tone violating sentence in the same paragraph or somewhere else in the article.

Observed Result:

Tonecheck does not get activated even when I start a new edit session.

Event Timeline

"In the same paragraph" is expected, because that's how declining works.

Add the same or a different tone violating sentence in the same paragraph or somewhere else in the article.

If you add a tone violating sentence to the same paragraph, the range marked as "not violating" will expand to include your pasted text. I think in most cases this is fine.

If you paste a tone violating sentence elsewhere I can't reproduce the bug, the tone violation shows just fine.

"In the same paragraph" is expected, because that's how declining works.

Actually, now I am seeing in both cases, it is showing up again after declining? Has the behavior got modified recently?

"In the same paragraph" is expected, because that's how declining works.

@DLynch: If what you mentioned is expected, that is not how it is behaving right now. I added the same tone violating sentence in the same paragraph after responding it's not violating the tone, it's still activating tone check. Can you please confirm what the expected behavior is currently if it has been changed.

Screenshot 2025-11-07 at 1.32.01 PM.png (590×2 px, 332 KB)

I think that this is the "decline" range not expanding when new content is added. (I.e. you declined "Foo bar", and then it notices that "Foo bar baz" contains a non-declined part of the document. Could be fixed by changing the decline check for the paragraph-expanding behavior, I think.

If you paste a tone violating sentence elsewhere I can't reproduce the bug, the tone violation shows just fine.

+1.

I think that this is the "decline" range not expanding when new content is added. (I.e. you declined "Foo bar", and then it notices that "Foo bar baz" contains a non-declined part of the document. Could be fixed by changing the decline check for the paragraph-expanding behavior, I think.

@DLynch: accurate for me to think the question here is something like the following?
"In what (if any) cases does a "previously declined" range expand to include text you've added and/or changed since declining?

Yeah.

It's particularly noticeable for Tone because it works by looking at the entire paragraph, rather than just highlighting the new modified part.

The behavior of it not expanding was added back in T384658 because we'd noticed that you could dismiss an add-reference check and then add a new paragraph immediately after that dismissed one, and the new paragraph would also not trigger the check.

I remember at the time we talked about adding new functionality to fragments so that we could tell them to only expand up to the boundaries of a paragraph, but there's some confusing edge cases involved there. (E.g. you have a fragment that's supposed to only expand inside a paragraph, and you split that paragraph in the middle into two paragraphs -- should that fragment now cover both paragraphs?)