[{reqId}] {exception_url} InvalidArgumentException: $usertalk must be provided if block target is not a user/IPI may be wrong, but I feel like this error might be preventing the patch for T398673: Unregistered editors on blocked ranges need a way to interact on-wiki to appeal a block from working as intended (rather than the error (e.g.) just being a side effect that doesn't impact the new feature itself).
Testing at https://3387e46cc4.catalyst.wmcloud.org/wiki/Special:MyTalk, the error seems to appear after pressing "Continue", without a temporary account being created in the process (judging by Special:Log/newusers).
I can reproduce this locally if the block target is an IP range, so it is affecting how the feature works for users affected by a range block.
It's happening a few times a day, and will increase as we deploy temp accounts to larger wikis: https://logstash.wikimedia.org/goto/eb688a4df049330828fb1c78fd271be8
Change #1192558 had a related patch set uploaded (by Tchanders; author: Tchanders):
[mediawiki/core@master] Pass user talk page when autocreating temp user to appeal block
@STran I made this patch before I saw this task was picked up - feel free to expand it if it's helpful.
Change #1192571 had a related patch set uploaded (by STran; author: STran):
[mediawiki/core@master] Pass through a user talk page in ip reveal temp account creation
Change #1192571 abandoned by STran:
[mediawiki/core@master] Pass through a user talk page in ip reveal temp account creation
Reason:
prefer Iab61cd5d85937e4f88c240e0a2615c20e474d8b2
Change #1192558 merged by jenkins-bot:
[mediawiki/core@master] Pass user talk page when autocreating temp user to appeal block
Still appearing as the fix didn't make the train
[{reqId}] {exception_url} InvalidArgumentException: $usertalk must be provided if block target is not a user/IP@Tchanders can this be moved tentatively to Done or In Progress? I'm not seeing anything left to review for this ticket (correct me if I am wrong though)
(Boldly resolving this task, as the patch was merged, and the task is in the 'Done' column of a now-archived sprint workboard. Please reopen if e.g. this is incorrect :))
I'm still seeing errors for this in logs: https://logstash.wikimedia.org/goto/d0ee6b7da95c9a03863fd26a605f47d7
If we add the filter for autocreatingTempUserToAppealBlock in the stack trace, there are no longer any errors: https://logstash.wikimedia.org/goto/c58eb54fe0d7da37826b3c139e62f606
However, other code paths are still attempting to check if a block applies to user talk without properly passing the user talk page - filed separately as T411242.