Tapping Revise from "Pre-Save" moment does not land you in Tone Check's "revising" state
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	Aug 26 2025, 5:51 PM

Project Tags

Referenced Files

None

Subscribers

Description

Behavior

Add text to an article that Tone Model thinks needs revision
Notice Tone Check appears
Do not address the Tone Check (either by tapping Revise or Decline)
Press Publish to advance to the pre-save moment
Notice Tone Check appears
Tap Revise

✅ Expected

You are returned to the`mid-edit` moment with Tone Check in its "revising" state (think: blue bars)

Actual

You are returned to the`mid-edit` moment with Tone Check in its "initial" state (think: Revise and Decline buttons)

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	ToneCheck: don't lose state when transitioning back from pre-save	DLynch	mediawiki/extensions/VisualEditor	master	+21 -5
	EditCheckController: option to join in on an existing refresh	DLynch	mediawiki/extensions/VisualEditor	master	+15 -1

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T265163 Create a system to encode best practices into editing experiences
Open	None	T365300 Introduce Edit Checks that encourage behavior aligned with Manual of Style consensus
Open	None	T365301 Tone Check: Prompt people to revise promotional language
Open	None	T416406 [MILESTONE] Offer Tone Check as default-on feature (all wikis)
Resolved	Esanders	T413026 [MILESTONE] Offer Tone Check as default-on feature at partner wikis
Resolved	DLynch	T402954 Tapping Revise from "Pre-Save" moment does not land you in Tone Check's "revising" state

Event Timeline

ppelberg created this task.Aug 26 2025, 5:51 PM

ppelberg mentioned this in T402605: Ensure unaddressed Tone Checks are re-presented in Pre-Save.

ppelberg edited subscribers, added: dchan; removed: KStoller-WMF, Trizek-WMF, diego and 5 others.

ppelberg moved this task from Inbox to Q3 2025-2026 on the Editing-team (Scheduled) board.Sep 4 2025, 4:58 PM

ppelberg edited projects, added: Editing-team (Kanban Board); removed: Editing-team (Scheduled).Sep 4 2025, 11:06 PM

ppelberg moved this task from Inbox to Ready to Be Worked On on the Editing-team (Kanban Board) board.

ppelberg edited projects, added: Editing-team (Scheduled); removed: Editing-team (Kanban Board).Nov 7 2025, 11:37 PM

We're going to revisit this task once the A/B experiment concludes (T387918).

Reason: we want to limit adjustments of the UX while the experiment is ongoing to those we think have the potential to meaningfully be disruptive/confusing to people.

We did previously fix this, so I think it's probably some incredibly timing-dependent aspect of the switch between moments.

ppelberg edited projects, added: Editing-team (Editing-18Feb-27Feb-2026); removed: Editing-team (Scheduled).Jan 16 2026, 10:42 PM

ppelberg edited parent tasks, added: T413026: [MILESTONE] Offer Tone Check as default-on feature at partner wikis; removed: T365301: Tone Check: Prompt people to revise promotional language.Feb 18 2026, 1:04 AM

ppelberg edited projects, added: Editing-team (Editing-2Mar-17Mar-2026); removed: Editing-team (Editing-18Feb-27Feb-2026).

ppelberg triaged this task as High priority.Feb 19 2026, 7:52 PM

ppelberg moved this task from Decisions to be made to Ready to Be Worked On on the Editing-team (Editing-2Mar-17Mar-2026) board.

ppelberg removed a project: Epic.Feb 25 2026, 1:03 AM

DLynch claimed this task.Mar 9 2026, 5:10 PM

DLynch moved this task from Ready to Be Worked On to Doing on the Editing-team (Editing-2Mar-17Mar-2026) board.

Change #1249403 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] EditCheckController: if a refresh is ongoing return the same promise

https://gerrit.wikimedia.org/r/1249403

Change #1249404 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] ToneCheck: don't lose state when transitioning back from pre-save

https://gerrit.wikimedia.org/r/1249404

DLynch moved this task from Doing to Code Review on the Editing-team (Editing-2Mar-17Mar-2026) board.Mar 9 2026, 9:15 PM

It turns out that when I said we had already fixed this, I was thinking of a similar-but-distinct issue where the revise mode was getting lost within mid-edit, which was fixed in the QA for T401727. This was actually a different problem that we've had all along -- we never correctly set the revising state after the transition from pre-save. It was masked somewhat by us previously successfully focusing the action, so it wasn't obvious what would be expected, and then automatically switching to the revise highlight once someone started typing.