Page MenuHomePhabricator

site_generators_tests.TestSiteGenerators.test_allpages_pagesize failing
Closed, ResolvedPublicBUG REPORT

Description

00:45:34 FAIL: test_allpages_pagesize (tests.site_generators_tests.TestSiteGenerators)
00:45:34 Test allpages with page maxsize parameter.
00:45:34 ----------------------------------------------------------------------
00:45:34 Traceback (most recent call last):
00:45:34   File "/src/tests/site_generators_tests.py", line 323, in test_allpages_pagesize
00:45:34     self.assertLessEqual(len(page.text.encode(mysite.encoding())), 200)
00:45:34 AssertionError: 578 not less than or equal to 200

https://integration.wikimedia.org/ci/job/pywikibot-core-tox-deeptest-py38/502/console

00:45:55 __________________ TestSiteGenerators.test_allpages_pagesize ___________________
00:45:55 
00:45:55 self = <tests.site_generators_tests.TestSiteGenerators testMethod=test_allpages_pagesize>
00:45:55 
00:45:55     def test_allpages_pagesize(self) -> None:
00:45:55         """Test allpages with page maxsize parameter."""
00:45:55         mysite = self.get_site()
00:45:55         for page in mysite.allpages(minsize=100, total=5):
00:45:55             self.assertIsInstance(page, pywikibot.Page)
00:45:55             self.assertTrue(page.exists())
00:45:55             self.assertGreaterEqual(len(page.text.encode(mysite.encoding())),
00:45:55                                     100)
00:45:55         for page in mysite.allpages(maxsize=200, total=5):
00:45:55             self.assertIsInstance(page, pywikibot.Page)
00:45:55             self.assertTrue(page.exists())
00:45:55             if len(page.text.encode(mysite.encoding())) > 200 \
00:45:55                and mysite.data_repository() == mysite:  # pragma: no cover
00:45:55                 unittest_print(
00:45:55                     f'{page}.text is > 200 bytes while raw JSON is <= 200')
00:45:55                 continue
00:45:55 >           self.assertLessEqual(len(page.text.encode(mysite.encoding())), 200)
00:45:55 E           AssertionError: 578 not less than or equal to 200
00:45:55 
00:45:55 tests/site_generators_tests.py:323: AssertionError

https://integration.wikimedia.org/ci/job/pywikibot-core-tox-deeptest-py313/42/console

Event Timeline

Xqt triaged this task as High priority.Aug 27 2025, 1:08 AM
Xqt changed the subtype of this task from "Task" to "Bug Report".
Xqt moved this task from Backlog to CI test failures on the Pywikibot-tests board.

See:

Xqt changed the task status from Open to In Progress.Aug 29 2025, 7:27 AM
Xqt claimed this task.

Change #1183074 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] allpages: fix maxsize handling in misermode

https://gerrit.wikimedia.org/r/1183074

Change #1183074 merged by Xqt:

[pywikibot/core@master] site.allpages: apply client-side filtering for maxsize in misermode

https://gerrit.wikimedia.org/r/1183074