Page MenuHomePhabricator
Create Task
Maniphest T403127

VisualEditor is loading oojs-ui on desktop page load
Closed, ResolvedPublicBUG REPORT
Actions

Description

Flagged by performance dashboard:

Screenshot 2025-08-27 at 2.14.37 PM.png (532×1 px, 75 KB)

https://grafana.wikimedia.org/goto/1_Xv2wXNR?orgId=1

There also seems to be a spike in total blocking time:
https://grafana.wikimedia.org/d/c6a56131-dc83-4c9a-8d50-2e687f83ab70/reading-web-performance-peter-h-copy?orgId=1&from=now-30d&to=now&timezone=utc

Steps to replicate the issue (include links if applicable):

What happens?:
An additional 100kb of uncompressed JS is being loaded.

What should have happened instead?:
The JS should be loaded when needed per our performance guidelines.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Restore ext.visualEditor.track modulemediawiki/extensions/VisualEditorwmf/1.45.0-wmf.16+9 -6
Drop oojs-ui from page loadmediawiki/extensions/VisualEditormaster+6 -2
Switch to using mw.util rather than OO.uiVisualEditor/VisualEditormaster+4 -4
Restore ext.visualEditor.track modulemediawiki/extensions/VisualEditormaster+9 -6
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson-WMF created this task.Aug 27 2025, 9:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 27 2025, 9:14 PM
Jdlrobson-WMF updated the task description. (Show Details)Aug 27 2025, 9:15 PM
ppelberg subscribed.Aug 27 2025, 9:47 PM
matmarex subscribed.Aug 27 2025, 10:13 PM

With https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/544247 oojs-ui was suddenly loaded on page load

That patch was merged almost 6 years ago.

How did you identify VisualEditor as the cause?

Jdlrobson-WMF added a subscriber: Catrope.Aug 27 2025, 10:28 PM

That patch was merged almost 6 years ago.

Sorry wrong patch.
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1167846

How did you identify VisualEditor as the cause?

I was working on a test with @Catrope - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1152304 - which I paused why I was on sabbatical. After rebasing it, it alerted me to the fact that oojs-ui is being loaded on page load. If you revert the above patch the test passes.

gerritbot added a comment.Aug 27 2025, 10:58 PM

Change #1182667 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/VisualEditor@master] Drop oojs-ui from page load

https://gerrit.wikimedia.org/r/1182667

gerritbot added a project: Patch-For-Review.Aug 27 2025, 10:58 PM
gerritbot added a comment.Aug 27 2025, 11:05 PM

Change #1182668 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[VisualEditor/VisualEditor@master] Switch to using mw.util rather than OO.ui

https://gerrit.wikimedia.org/r/1182668

ppelberg triaged this task as Unbreak Now! priority.Aug 27 2025, 11:13 PM
ppelberg added a project: Editing-team (Kanban Board).
matmarex unsubscribed.Aug 28 2025, 12:16 AM
Peter subscribed.Aug 28 2025, 5:16 AM
gerritbot added a comment.Aug 29 2025, 9:58 AM

Change #1183088 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Restore ext.visualEditor.track module

https://gerrit.wikimedia.org/r/1183088

PatchDemoBot added a comment.Aug 29 2025, 10:01 AM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://ed7a613ead.catalyst.wmcloud.org/w/

gerritbot added a comment.Aug 29 2025, 3:23 PM

Change #1183088 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Restore ext.visualEditor.track module

https://gerrit.wikimedia.org/r/1183088

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.17; 2025-09-02).Aug 29 2025, 4:00 PM
gerritbot added a comment.Aug 29 2025, 5:06 PM

Change #1183154 had a related patch set uploaded (by Jdlrobson; author: Esanders):

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.16] Restore ext.visualEditor.track module

https://gerrit.wikimedia.org/r/1183154

Jdlrobson-WMF added a comment.Aug 29 2025, 5:07 PM

That did it! I'm out Monday but can help backport it Tuesday (unless you feel comfortable about a Friday or Monday deployment given the long weekend for US people?)

gerritbot added a comment.Sep 2 2025, 1:57 PM

Change #1182668 abandoned by Esanders:

[VisualEditor/VisualEditor@master] Switch to using mw.util rather than OO.ui

Reason:

See I8d2860672436cbf4e1d245e45062161babbe887a

https://gerrit.wikimedia.org/r/1182668

gerritbot added a comment.Sep 2 2025, 1:58 PM

Change #1182667 abandoned by Esanders:

[mediawiki/extensions/VisualEditor@master] Drop oojs-ui from page load

Reason:

See I8d2860672436cbf4e1d245e45062161babbe887a

https://gerrit.wikimedia.org/r/1182667

gerritbot added a comment.Sep 2 2025, 8:45 PM

Change #1183154 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.16] Restore ext.visualEditor.track module

https://gerrit.wikimedia.org/r/1183154

Stashbot added a comment.Sep 2 2025, 8:45 PM

Mentioned in SAL (#wikimedia-operations) [2025-09-02T20:45:39Z] <kemayo@deploy1003> Started scap sync-world: Backport for [[gerrit:1183154|Restore ext.visualEditor.track module (T403127)]]

Stashbot added a comment.Sep 2 2025, 8:51 PM

Mentioned in SAL (#wikimedia-operations) [2025-09-02T20:51:31Z] <kemayo@deploy1003> jdlrobson, kemayo: Backport for [[gerrit:1183154|Restore ext.visualEditor.track module (T403127)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Sep 2 2025, 8:58 PM

Mentioned in SAL (#wikimedia-operations) [2025-09-02T20:57:59Z] <kemayo@deploy1003> Finished scap sync-world: Backport for [[gerrit:1183154|Restore ext.visualEditor.track module (T403127)]] (duration: 12m 20s)

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.16; 2025-08-26); removed MW-1.45-notes (1.45.0-wmf.17; 2025-09-02).Sep 2 2025, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 2 2025, 9:32 PM
Jdlrobson-WMF mentioned this in T395710: Wikidata is loading considerably more code than other projects.Sep 2 2025, 11:05 PM
VPuffetMichel moved this task from Inbox to QA on the Editing-team (Kanban Board) board.Sep 3 2025, 12:35 PM
VPuffetMichel added a project: Editing QA.
Jdforrester-WMF subscribed.Sep 4 2025, 12:30 PM

Presumably this is no longer UBN, and just awaiting confirmation? Can it be downgraded so it doesn't show up in the UBN dashboard?

PatchDemoBot added a comment.Sep 5 2025, 10:40 AM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://ed7a613ead.catalyst.wmcloud.org/w/

Jdlrobson-WMF lowered the priority of this task from Unbreak Now! to High.Sep 5 2025, 4:17 PM

Hope I'm not overstepping here @ppelberg by changing priority.

Screenshot 2025-09-05 at 9.17.07 AM.png (540×1 px, 80 KB)

I'm still seeing similar blocking issues, but I think that relates to a Wiki loves monument banner that is now loading.

ppelberg added a subscriber: Jdlrobson.Sep 5 2025, 5:02 PM
In T403127#11152871, @Jdlrobson-WMF wrote:

Hope I'm not overstepping here @ppelberg by changing priority.

Screenshot 2025-09-05 at 9.17.07 AM.png (540×1 px, 80 KB)

I'm still seeing similar blocking issues, but I think that relates to a Wiki loves monument banner that is now loading.

Eek! No, not at all. Thank you for consciously taking action, @Jdlrobson and thank you, @Jdforrester-WMF for noticing!

ppelberg moved this task from Inbox to High Priority on the Editing QA board.Sep 5 2025, 5:02 PM
ppelberg closed this task as Resolved.Sep 16 2025, 4:32 AM
ppelberg claimed this task.
ppelberg added a project: Skipped QA.
In T403127#11152871, @Jdlrobson-WMF wrote:

Screenshot 2025-09-05 at 9.17.07 AM.png (540×1 px, 80 KB)

I'm still seeing similar blocking issues, but I think that relates to a Wiki loves monument banner that is now loading.

Per above, Editing sees this issue as Resolved.

VPuffetMichel added a project: Essential-Work.Dec 8 2025, 10:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits