Page MenuHomePhabricator

[MEX] Rename components to match rest of Wikibase
Closed, ResolvedPublic

Description

Generally speaking, in Wikibase, a statement contains just one main snak with a value (or somevalue/novalue) and optional qualifiers or references; a statement group is the collection of all statements with the same property (of the main snak). However, in wbui2025 we’ve deviated from this terminology in some places; I’d like to bring it closer to the rest of Wikibase.

Event Timeline

Due to the way the MEX UI is laid out, I think we’re going to be referring to the statement group, rather than individual statements, quite a bit… (see also the vaguely related T403149).

Change #1182609 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Rename wbui2025 statementView to statementGroupView

https://gerrit.wikimedia.org/r/1182609

Change #1182610 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Rename wbui2025 statementDetailView to statementView

https://gerrit.wikimedia.org/r/1182610

Change #1182846 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Rename wbui2025 editStatement to editStatementGroup

https://gerrit.wikimedia.org/r/1182846

Change #1182847 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Rename wbui2025 editStatementAddValue to editStatement

https://gerrit.wikimedia.org/r/1182847

Moving to peer review in the hope that CI will finish successfully. (Except for one job on [this change}(https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1182846) where I can already see it’ll need a recheck.)

Change #1182609 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Rename wbui2025 statementView to statementGroupView

https://gerrit.wikimedia.org/r/1182609

Change #1182610 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Rename wbui2025 statementDetailView to statementView

https://gerrit.wikimedia.org/r/1182610

Change #1182846 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Rename wbui2025 editStatement to editStatementGroup

https://gerrit.wikimedia.org/r/1182846

Change #1182847 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Rename wbui2025 editStatementAddValue to editStatement

https://gerrit.wikimedia.org/r/1182847

Let’s just close this rather than make it into a general “I’d like to rename everything to be better” task. If someone wants to do further renames, make another task (or upload the changes directly if they don’t need to be “grouped” like these four changes).