Page MenuHomePhabricator

Merge PatrolLog into PatrolManager
Open, Needs TriagePublic

Description

PatrolLog (includes/logging/PatrolLog.php) holds a single (public) static method (PatrolLog::record), which encapsulates sending log entries to Special:Log/patrol.

It's called just from the new PatrolManager service and one extension. Moving the method to the service seems to be quite logical to me.

There is some technical debt that could perhaps be left behind: T199755.

Acceptance criteria

  • All PatrolLog methods and the class are hard deprecated
  • The PatrolLog class is dropped in 1.48

Event Timeline

Change #1281507 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Move PatrolLog::record to PatrolManager

https://gerrit.wikimedia.org/r/1281507

Change #1281531 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/PageTriage@master] PageTriage: Use PatrolManager over deprecated method calls

https://gerrit.wikimedia.org/r/1281531

Dreamy_Jazz reopened this task as Open.

Change #1281507 merged by jenkins-bot:

[mediawiki/core@master] Move PatrolLog::record to PatrolManager

https://gerrit.wikimedia.org/r/1281507

Change #1281535 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/PageTriage@master] Replace deprecated MarkPatrolledComplete hook

https://gerrit.wikimedia.org/r/1281535

Change #1281540 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Hard deprecate PatrolLog::record

https://gerrit.wikimedia.org/r/1281540

Change #1281531 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] PageTriage: Use PatrolManager over deprecated method calls

https://gerrit.wikimedia.org/r/1281531

Change #1281540 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate PatrolLog::record

https://gerrit.wikimedia.org/r/1281540