Page MenuHomePhabricator
Create Task
Maniphest T403244

Empty HTML fragment viewer that should be disabled is instead editable
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Go to https://www.wikifunctions.org/view/en/Z27851
  • Expand the "call" section
  • The second fragment is editable, even if it shouldn't be
  • If you actually edit it, after the first edit it becomes not editable (frozing the illegal edit that you've just done).

What should have happened instead?:
The fragment viewer should have been disabled from the start.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ZHTMLFragment: disable editor in read modeDaphne Smitmediawiki/extensions/WikiLambdamaster+1 -1
Customize query in gerrit

Event Timeline

Dv103 created this task.Aug 29 2025, 9:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2025, 9:41 AM
Maintenance_bot added a project: Abstract Wikipedia team.Aug 29 2025, 10:30 AM
Jdforrester-WMF triaged this task as Medium priority.Sep 3 2025, 3:36 PM
Jdforrester-WMF moved this task from To Triage to Bugs to investigate on the Abstract Wikipedia team board.
gerritbot added a comment.Sep 23 2025, 1:48 PM

Change #1190680 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] ZHTMLFragment: disable editor in read mode

https://gerrit.wikimedia.org/r/1190680

gerritbot added a project: Patch-For-Review.Sep 23 2025, 1:48 PM
DSmit-WMF changed the task status from Open to In Progress.Sep 23 2025, 1:49 PM
DSmit-WMF claimed this task.
DSmit-WMF moved this task from Bugs to investigate to 26Q1 (Jul–Sep) on the Abstract Wikipedia team board.
DSmit-WMF edited projects, added: Abstract Wikipedia team (26Q1 (Jul–Sep)); removed: Abstract Wikipedia team.
DSmit-WMF moved this task from Incoming to In Code review on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.
DSantamaria added a project: Essential-Work.Sep 24 2025, 10:11 AM
gerritbot added a comment.Sep 24 2025, 11:56 AM

Change #1190680 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZHTMLFragment: disable editor in read mode

https://gerrit.wikimedia.org/r/1190680

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.21; 2025-09-30).Sep 24 2025, 12:05 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 24 2025, 12:32 PM
Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.Sep 24 2025, 1:51 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.Oct 2 2025, 4:03 PM
Jdforrester-WMF closed this task as Resolved.Oct 2 2025, 4:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits