Page MenuHomePhabricator

[MEX] M3.1.2 - edit snak type
Closed, ResolvedPublic

Description

As a wikidata editor,
I want to be able to define the snak type (custom value / unknown value / no value) while editing a statement on mobile
So that the statement can be more precise

Screenshot 2025-09-11 at 12.09.50.png (1×1 px, 206 KB)

Figma: https://www.figma.com/design/RtMDwH7sMF5IPRJvyyZPv4/Mobile-editing-experience?node-id=2255-40178&t=C9HTDU2XkF8Mdz6A-1

  • snak icon (not on codex) is inserted in menu button component
  • all 3 choices are displayed in the dropdown and the currently selected choice is highlighted
  • per default the option "custom value" is selected
  • no value and unknown value, if selected, are displayed on the edit screen as only text, replacing the input field that is there for custum value
    • The text is displayed in Inter, medium Italic, 18px (For this font style there are no tokens - has to be implemented as a snowflake)
  • to save changes in snak type, user needs to publish

a/c

  • the snak type field matches the figma design (visually and user flow)
  • the snak type field can be edited
  • the snak type field can be saved
  • tests are updated and/or created

Note:

  • the snak burger icon should be the same one used on desktop where the top part if filled in (even if figma design indicates the middle section should be filled in).
  • snak type UX for on display pulled out to T404685

Event Timeline

Alice.moutinho renamed this task from [MEX] M3.1.2 - value type to [MEX] M3.1.2 - edit snak.Aug 29 2025, 12:01 PM
Alice.moutinho updated the task description. (Show Details)
Lucas_Werkmeister_WMDE renamed this task from [MEX] M3.1.2 - edit snak to [MEX] M3.1.2 - edit snak type.Aug 29 2025, 12:40 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)

What happens when a new snak type is selected?

Change #1191004 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Snak type selector

https://gerrit.wikimedia.org/r/1191004

Change #1191004 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add snaktype selector menubutton and menu, and make it work

https://gerrit.wikimedia.org/r/1191004