Page MenuHomePhabricator

Vector 2022 navbar icons have inconsistent hover states
Open, LowPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • View any page in vector 2022

What happens?:

cleanshot_2025-08-18_at_15.50.06.gif (232×800 px, 529 KB)
(animated gif)

There are four different button styles here:

  • The ones which were historically tabs have blue text and a heavy underline for highlight/active
  • The watchlist star has a grey hover highlight that covers a decent area around the icon
  • The tools menu has a differently-aligned grey hover highlight that fills the area, but barely covers its text
  • The language selector has a blue hover highlight, and juts out over the edge of the navbar

What should have happened instead?:

The historical tabs are fine, but the rest of the buttons should have consistent alignment and padding.

Details

Related Changes in Gerrit:

Event Timeline

Change #1180168 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/skins/Vector@master] Adjust padding in tools navbar

https://gerrit.wikimedia.org/r/1180168

That patch just tweaks the tools button to remove the gap that's applied to it and move its spacing into the edges of the button, so it no longer has an excessively-large space between the label and the down arrow and absolutely no padding.

gap
cleanshot_2025-08-18_at_16.06.57_2x.png (134×332 px, 8 KB)
before
cleanshot_2025-08-19_at_11.13.59_2x.png (282×424 px, 15 KB)
after
cleanshot_2025-08-19_at_11.09.43_2x.png (288×424 px, 15 KB)

It probably needs more work, particularly to align the height with that of the watchlist button, but this is the most minimal change possible and preserves the existing dimensions exactly.

HFan-WMF moved this task from Backlog to Needs refinement on the Reader Experience Team board.

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://9c94e3a3b4.catalyst.wmcloud.org/w/

I was playing around with the button component on Codex and it looks like our buttons are using correct hover styles. The "star" and "tools" are default buttons hence it has the grey hover. While the language selector is a progressive button and hence it has a blue hover.

Why is the language selector progressive button instead of default button? I am not sure, but I am assuming it is to draw more attention to it? @Jdlrobson @Volker_E do you have any history on this?

However, I do think we can fix the spacing and padding issues.

  • Currently on web. Notice how the arrows are aligned with the article edge which causes hover to bleed outside of that edge for "langauge selector". And seems like the "tools menu" hover state is not following the proper spacing guidelines hence it looks improper without any padding.
Screenshot 2025-09-04 at 4.24.05 PM.png (306×790 px, 27 KB)
Screenshot 2025-09-04 at 4.24.11 PM.png (322×808 px, 28 KB)
Screenshot 2025-09-04 at 4.24.16 PM.png (284×784 px, 27 KB)
current defaultlanguage selector hovertools menu hover
  • I am proposing we adjust how the buttons are placed so the arrows are not aligned exactly with the article edge so when the hover shows up it has proper spacing available to show it correctly.
Screenshot 2025-09-04 at 4.25.29 PM.png (304×892 px, 23 KB)
Screenshot 2025-09-04 at 4.35.34 PM.png (332×878 px, 25 KB)
without hoverwith hover

To fix the hover states we need to fix the position of the button.

I'd agree that proposal looks much better.