Page MenuHomePhabricator

Source code highlighting confused in diff view
Closed, ResolvedPublic



Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 1:07 AM
bzimport added projects: Gerrit, Upstream.
bzimport set Reference to bz38335.
bzimport added a subscriber: Unknown Object (MLST).

It starts about in the middle of the file and syntax coloring must be enabled.

I guess this is caused by the heredoc being hidden as common lines.

It's not about being hidden. It's just getting confused at the heredoc.

I filed this bug upstream almost 3 weeks ago. Resolving LATER until something happens there.

Switching from LATER to the second most relevant resolution for fear of information loss.

Both upstream and up-upstream bugs are still open; I can't actually see the bug myself but it's probably me.

Cannot spot anything strange in either.
<<< (heredoc) is used in lines 95 and 233 but nothing weird visible.

Nikkerabit: Do you remember what the problem was? (Screenshots welcome.)

Created attachment 11809
Example from URL

As I said it was just me. :) Seen on Firefox and Chrome, as explained on : after $box = <<<EOT (and actually even starting a bit before it), everything is treated as a single string so all colours get lost; compare for instance the lines selected in the screenshot.


WrongColours.png (768×1 px, 92 KB)

demon claimed this task.
demon added a subscriber: demon.

Pretty sure this is all better now.