Page MenuHomePhabricator
Create Task
Maniphest T403424

Release wikimedia/timestamp v5.0.0 and update dependency in MediaWiki
Closed, ResolvedPublic
Actions

Description

Per the FIXME comment in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1175273/18/includes/json/ClockAdapter.php, we will want to update the wikimedia/timestamp Composer package in MediaWiki core to a version that includes the patch https://gerrit.wikimedia.org/r/c/mediawiki/libs/Timestamp/+/1180650, as part of the work on JWT tokens.

There have been some breaking changes merged since the last release, so this one will need to be a major version bump, to v5. There are other extensions and libraries that depend on v4: https://codesearch.wmcloud.org/search/?q=wikimedia%2Ftimestamp. We'll have to coordinate updating to the new version in anything deployed to WMF production.

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
composer: Allow wikimedia/timestamp ^5.0.0repos/data-engineering/metrics-platform!102matmarexpatch-1main
Customize query in GitLab

Related Objects
Search...

Event Timeline

matmarex created this task.Sep 1 2025, 6:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2025, 6:01 PM
matmarex added a subtask: T401058: Support PSR-20.Sep 1 2025, 6:03 PM
matmarex added a parent task: T399243: Support JWT generation for session tokens in MediaWiki core.
matmarex added a project: OKR-Work.Sep 1 2025, 6:05 PM
matmarex claimed this task.Sep 1 2025, 6:09 PM
Umherirrender added a project: Release.Sep 1 2025, 8:21 PM
Jdforrester-WMF subscribed.Sep 4 2025, 2:51 PM

Should https://gerrit.wikimedia.org/r/c/mediawiki/libs/Timestamp/+/1137473 be part of this release?

matmarex added a comment.Sep 4 2025, 4:23 PM

I don't think so, mostly because it isn't finished.

Tgr moved this task from Inbox, needs triage to Next (DO NOT USE) on the MediaWiki-Core-Platform-Team board.Sep 8 2025, 3:05 PM
gerritbot added a comment.Sep 19 2025, 11:26 PM

Change #1189931 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/libs/Timestamp@master] Release v5.0.0

https://gerrit.wikimedia.org/r/1189931

gerritbot added a project: Patch-For-Review.Sep 19 2025, 11:26 PM
matmarex moved this task from Next (DO NOT USE) to In progress (DO NOT USE) on the MediaWiki-Core-Platform-Team board.Sep 19 2025, 11:29 PM
gerritbot added a comment.Sep 22 2025, 6:18 AM

Change #1189931 merged by jenkins-bot:

[mediawiki/libs/Timestamp@master] Release v5.0.0

https://gerrit.wikimedia.org/r/1189931

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2025, 6:30 AM
matmarex added a comment.Sep 22 2025, 6:09 PM

Pushed v5.0.0 tag:
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/libs/Timestamp/+/refs/tags/v5.0.0
https://packagist.org/packages/wikimedia/timestamp#v5.0.0

gerritbot added a comment.Sep 22 2025, 6:24 PM

Change #1190314 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/Wikibase@master] composer: Allow wikimedia/timestamp ^5.0.0

https://gerrit.wikimedia.org/r/1190314

gerritbot added a project: Patch-For-Review.Sep 22 2025, 6:24 PM
gerritbot added a comment.Sep 22 2025, 6:39 PM

Change #1190316 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/libs/XMPReader@master] composer: Allow wikimedia/timestamp ^5.0.0

https://gerrit.wikimedia.org/r/1190316

gerritbot added a comment.Sep 22 2025, 6:39 PM

Change #1190317 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/libs/XMPReader@master] Release 0.10.0

https://gerrit.wikimedia.org/r/1190317

matmarex added a comment.Sep 22 2025, 6:42 PM

I think that takes care of all potentially conflicting dependencies.

Next steps:

  • Tag release of wikimedia/xmp-reader
  • Upgrade wikimedia/xmp-reader in MW core
  • Upgrade wikimedia/timestamp in MW core
gerritbot added a comment.Sep 22 2025, 7:14 PM

Change #1190316 merged by jenkins-bot:

[mediawiki/libs/XMPReader@master] composer: Allow wikimedia/timestamp ^5.0.0

https://gerrit.wikimedia.org/r/1190316

gerritbot added a comment.Sep 22 2025, 8:30 PM

Change #1190314 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] composer: Allow wikimedia/timestamp ^5.0.0

https://gerrit.wikimedia.org/r/1190314

gerritbot added a comment.Sep 22 2025, 8:51 PM

Change #1190317 merged by jenkins-bot:

[mediawiki/libs/XMPReader@master] Release 0.10.0

https://gerrit.wikimedia.org/r/1190317

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.20; 2025-09-23).Sep 22 2025, 9:00 PM
matmarex added a comment.Sep 22 2025, 9:05 PM

Pushed 0.10.0 tag:
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/libs/XMPReader/+/refs/tags/0.10.0
https://packagist.org/packages/wikimedia/xmp-reader#0.10.0

matmarex added a comment.Sep 22 2025, 9:18 PM

Hmph, https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform is also a production dependency (in mediawiki/vendor via EventLogging).

CodeReviewBot added a comment.Sep 22 2025, 9:23 PM

matmarex opened https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/102

composer: Allow wikimedia/timestamp ^5.0.0

gerritbot added a comment.Sep 22 2025, 9:33 PM

Change #1190350 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/vendor@master] Update wikimedia/xmp-reader to 0.10.0

https://gerrit.wikimedia.org/r/1190350

gerritbot added a comment.Sep 22 2025, 9:33 PM

Change #1190351 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Update wikimedia/xmp-reader to 0.10.0

https://gerrit.wikimedia.org/r/1190351

gerritbot added a comment.Sep 23 2025, 9:01 AM

Change #1190350 merged by jenkins-bot:

[mediawiki/vendor@master] Update wikimedia/xmp-reader to 0.10.0

https://gerrit.wikimedia.org/r/1190350

gerritbot added a comment.Sep 23 2025, 9:02 AM

Change #1190351 merged by jenkins-bot:

[mediawiki/core@master] Update wikimedia/xmp-reader to 0.10.0

https://gerrit.wikimedia.org/r/1190351

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.21; 2025-09-30); removed: MW-1.45-notes (1.45.0-wmf.20; 2025-09-23).Sep 23 2025, 9:02 AM
CodeReviewBot added a comment.Sep 23 2025, 8:37 PM

phuedx merged https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/102

composer: Allow wikimedia/timestamp ^5.0.0

Maintenance_bot removed a project: Patch-For-Review.Sep 23 2025, 9:32 PM
gerritbot added a comment.Sep 24 2025, 9:16 AM

Change #1190982 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/vendor@master] Upgrading wikimedia/metrics-platform (4.2.3 => 4.2.4)

https://gerrit.wikimedia.org/r/1190982

gerritbot added a project: Patch-For-Review.Sep 24 2025, 9:16 AM
gerritbot added a comment.Sep 25 2025, 12:49 AM

Change #1191207 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/EventLogging@master] Upgrading wikimedia/metrics-platform (4.2.3 => 4.2.4)

https://gerrit.wikimedia.org/r/1191207

gerritbot added a comment.Sep 25 2025, 12:59 AM

Change #1191208 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/vendor@master] Update wikimedia/timestamp to 5.0.0

https://gerrit.wikimedia.org/r/1191208

gerritbot added a comment.Sep 25 2025, 12:59 AM

Change #1191209 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Update wikimedia/timestamp to 5.0.0

https://gerrit.wikimedia.org/r/1191209

matmarex edited parent tasks, added: T398815: WE5.1.2 Verifiable MediaWiki sessions, T405541: Replace MediaWiki\Json\ClockAdapter; removed: T399243: Support JWT generation for session tokens in MediaWiki core.Sep 25 2025, 1:08 AM
matmarex removed a parent task: T398815: WE5.1.2 Verifiable MediaWiki sessions.
gerritbot added a comment.Sep 25 2025, 2:39 AM

Change #1191217 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] ParamValidator: Catch exceptions on invalid timestamp formats

https://gerrit.wikimedia.org/r/1191217

gerritbot added a comment.Sep 25 2025, 11:37 AM

Change #1191217 merged by jenkins-bot:

[mediawiki/core@master] ParamValidator: Catch exceptions on invalid timestamp formats

https://gerrit.wikimedia.org/r/1191217

gerritbot added a comment.Sep 25 2025, 7:20 PM

Change #1191488 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/EventLogging@master] tests: Avoid dependency on wikimedia/timestamp internals

https://gerrit.wikimedia.org/r/1191488

gerritbot added a comment.Sep 26 2025, 12:33 PM

Change #1191488 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] tests: Avoid dependency on wikimedia/timestamp internals

https://gerrit.wikimedia.org/r/1191488

gerritbot added a comment.Sep 26 2025, 12:37 PM

Change #1190982 merged by jenkins-bot:

[mediawiki/vendor@master] Upgrading wikimedia/metrics-platform (4.2.3 => 4.2.4)

https://gerrit.wikimedia.org/r/1190982

gerritbot added a comment.Sep 26 2025, 12:37 PM

Change #1191208 merged by jenkins-bot:

[mediawiki/vendor@master] Update wikimedia/timestamp to 5.0.0

https://gerrit.wikimedia.org/r/1191208

gerritbot added a comment.Sep 26 2025, 12:46 PM

Change #1191209 merged by jenkins-bot:

[mediawiki/core@master] Update wikimedia/timestamp to 5.0.0

https://gerrit.wikimedia.org/r/1191209

Jdforrester-WMF closed this task as Resolved.Sep 26 2025, 12:50 PM
gerritbot added a comment.Sep 26 2025, 1:06 PM

Change #1191207 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] Upgrading wikimedia/metrics-platform (4.2.3 => 4.2.4)

https://gerrit.wikimedia.org/r/1191207

Maintenance_bot removed a project: Patch-For-Review.Sep 26 2025, 1:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits