Page MenuHomePhabricator

Pinch to zoom is not working on some devices
Closed, ResolvedPublic

Description

lets make it as robust as the wikipedia app


Version: unspecified
Severity: normal

Details

Reference
bz38348

Related Objects

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:08 AM
bzimport set Reference to bz38348.
bzimport added a subscriber: Unknown Object (MLST).

For parity with Wikipedia app:

  • drop the 'PinchZoom' Cordova extension
  • when setting up the map, don't enable touchZoom or disable zoomControls if we are on Android 2

That'll leave us with double-tap to zoom in and the +/- zoom in/out buttons on Android 2.x, and more reliable pinch-to-zoom on Android 3/4 (and potentially iPhone if we end up making an iOS build later).

It's not working on my android 4.0.2

This seems to be a leaflet bug... I just tried the latest master (non-stable) of leaflet and the problem went away. It's discussed on https://github.com/CloudMade/Leaflet/issues/150

Should we upgrade?