@SChekfa-WMF @JTannerWMF

We were discussing this in Eng Sync and were wondering if we could re-use our list item component instead for this. It would save time in development and also might provide for a smoother selection for users (the i icon looks tiny, and it's on top of an already-tappable button).

This screen is a legacy UIKit view which takes longer for us to build new pieces into, plus new components here would be adding to our tech debt since we'd have to add it to an old framework.

Here's a quick mock-up, I think we could probably get more of a background rounded rectangle for the icons as well, I just didn't want to spend time on that at this stage:

Estimates:
List version - small 3
Current design - big 5

@Tsevener this is fine with me, thanks for explaining — would it be possible to make the icon tappable to enter a lightbox so that they can see it at a larger size before committing? @JTannerWMF how do you feel about this?

@SChekfa-WMF

would it be possible to make the icon tappable to enter a lightbox so that they can see it at a larger size before committing?

Well, that would probably undo the gains we made by scope cutting. So if the lightbox is a requirement I suggest we stick with the original design.

l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5428

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/5428

Hi @Tsevener ! Could you confirm how this slide works? My understanding: showing this slide depends on if the user has a locally stored donation history. That donation history could be from an ApplePay donation OR a WebPay donation (in the way that we track WebPay https://phabricator.wikimedia.org/T376219).

Hi @HNordeenWMF! Just confirming - this task involves changing in Settings, which I am less familiar with. Will let @GOlson-WMF chime in if this question is about Settings.

But for the contributor slide, we show the contributor version if:

1. The user has donated in the app within the target data collection start/end dates. These are local donation events we keep track of, and we add to them when they donate either via the native apple pay form the in-app web view for other payment methods.

2. We also fetch their edit counts via the user contributions API for their primary app language. We pass in the appropriate target start/end dates as parameters, as well as a namespace of 0.

If their edit count or donate count from the previous steps is > 0, they see the contributor version of the slide (i.e. with the app icon toggle), otherwise they see the non-contributor version (i.e. without the app icon toggle).

Thanks @Tsevener ! It's about both I guess (I am assuming that if we recognize someone as a Donor/Editor, they get the Settings AND the slide), and if someone is not a donor/editor, the settings item is hidden).

That's what I was looking for - if someone makes a WebPay donation after seeing YiR, our system is equipped to recognize that and offer them the icon in Settings & Year in Review.

Appears to be fixed on 7.8.5 (5867)

Tested on iPhone 16 on iOS 26, iPad 12.9 on iPadOS 26, and iPhone 11 on iOS 18. Tested on all themes

@Tsevener is this item tied to the Config? (Does it disappear for folks when we turn off the config?) I'm hoping not, since we promised it will be there until next year's year in Review.

Going to tag @GOlson-WMF on this one since I think there's some bandwidth to investigate there. @GOlson-WMF Can you answer these questions?

Our YiR feature will disappear when the config goes out of date. Can you confirm that once the activeEndDate has passed, the custom app icon (if the user chose it) will still remain active, and confirm that the Settings view will still have the icon picker?

Also, this may be trickier to confirm but we want the custom app icon to automatically switch back to the standard icon in 1 year, correct @HNordeenWMF? Is that happening?

Absolutely! What I found:

We set it in AppearanceSettingsViewController which is not impacted at all by YIR. Then, we use qualifiesForIcon2025 as our defaults flag, which is only updated in the year in review data controller (below)

public func updateContributorStatus(isContributor: Bool) {
    try? userDefaultsStore?.save(
        key: WMFUserDefaultsKey.qualifiesForIcon2025.rawValue,
        value: isContributor
    )
}

If you want, we can add something in that will check a date and set it to false after x date? That may work, but we'd need an official date.

So @HNordeenWMF (TLDR)

1. This item is NOT tied to the config, but it will only show up if the user starts YIR enough that we get that data to determine if they're a contributor or not. So once YIR closes, if a user hasn't opened it, even if they were a contributor, they will not see it. But for those who do see it, they'll keep it.
2. I don't have a specific end date for the automatic switch back but I believe it could be done relatively easily, and I can do some investigating and testing to see.

thanks @GOlson-WMF ! That's great it's not tied to the Config, because we will likely turn off the Config before 1 year but we want the icon to remain until next year's Year in Review.

The requirement has:

[] Custom icon feature should last for 1 year from full production release

Let's add an end date of November 30, 2026 please!

Moving this back into Ready for Dev so we don't miss this. Please add an icon end date per https://phabricator.wikimedia.org/T403543#11355300.

Moving instead to Did not pass QA so it doesn't mess with our sprint calculations.

l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5530

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/5530