Page MenuHomePhabricator

Synthetic list defined refs can be orphaned
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Create a page with the following Wikitext
<ref details="page 1" name="book">Miller</ref>
  • Edit the page in VE
  • Delete the subref [1.1] in VE

What happens?:

  • The subref is removed from the article
  • The main ref is still visible in the references list

image.png (966×172 px, 10 KB)

What should have happened instead?:

  • The main ref should also be gone
Notes:
  • In this case ( and similar variants of this ) VE uses a synthetic list defined ref to store the main content.
  • When saving Parsoid always makes sure, that the synthetic list defined refs are not stored back.
Related:

There's a similar scenario where users get into the situation described above

  • Create a page with the following Wikitext
<ref details="page 1" name="book" />

<references>
<ref name="book">Miller</ref>
</references>
  • Edit the page in VE
  • Delete the subref [1.1] in VE
  • The main ref is still visible in the references list

image.png (966×172 px, 10 KB)

  • When saving you get to the following Wikitext
<references>
<ref name="book">Miller</ref>
</references>
  • And an error

image.png (949×54 px, 12 KB)

Outcome

image.png (971×328 px, 29 KB)

Cannot save the page
https://de.wikipedia.beta.wmcloud.org/w/index.php?title=SyntheticListDefinedRefs

Event Timeline

Triage:

  • we're keeping this on the list of known issues until further insights and feedback.
  • The issue is also observed with normal LDRs without the use of sub-references.

Seems to be solved by T356471#11160318, I can no longer reproduce the bug on beta.

Seems to be solved by T356471#11160318, I can no longer reproduce the bug on beta.

I can confirm this. Seems fixed. Let's still have a quick review about that.

Moving back given that the issue occurs again with the revert in T356471#11175267 / T404421

Removing from this board again. I just moved it here because it was drive-by fixed by merging that patch from the other ticket. With the revert this is now again post-mvp

Tobi_WMDE_SW claimed this task.