Page MenuHomePhabricator
Create Task
Maniphest T403588

Ensure basic accessibility for subreferencing feature
Closed, ResolvedPublic
Actions

Description

With the upcoming rollout of the subreferencing feature, basic accessibility should be in place.

  • References should be reachable via tab navigation
  • Popups should open when triggered via keyboard

Findings (for review): internal doc on a11y

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update OOUI to v0.53.1mediawiki/coremaster+248 -92
Add missing preventDefault to SearchWidget.onQueryKeydownoojs/uimaster+1 -0
Highlight ref search result when there is only onemediawiki/extensions/Citemaster+7 -1
Revert "Re-define tab key in the reference reuse search dialog"mediawiki/extensions/Citemaster+5 -5
Update VE core submodule to master (8b1b8b872)mediawiki/extensions/VisualEditormaster+1 -1
Fix keyboard focus wraparound in custom window managersVisualEditor/VisualEditormaster+12 -3
[POC] Easier to use focus trap in ContextItem popupsVisualEditor/VisualEditormaster+4 -0
Re-define tab key in the reference reuse search dialogmediawiki/extensions/Citemaster+8 -0
[POC] Connect LinearContextItem label to edit buttonVisualEditor/VisualEditormaster+9 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

MareikeHeuerWMDE created this task.Sep 3 2025, 9:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2025, 9:02 AM
WMDE-Fisch moved this task from Incoming to Dev-Work on the Cite (Sub-referencing) board.Sep 3 2025, 9:31 AM
A_smart_kitten added a project: Accessibility.Sep 3 2025, 10:14 AM
lilients_WMDE claimed this task.Sep 9 2025, 1:15 PM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2025-09-03-Salted-Caramel-Icecream board.
lilients_WMDE added a parent task: T338318: Evaluate & improve accessibility of TechWish products.
lilients_WMDE mentioned this in T338318: Evaluate & improve accessibility of TechWish products.Sep 9 2025, 1:39 PM
lilients_WMDE removed lilients_WMDE as the assignee of this task.Sep 9 2025, 3:11 PM
lilients_WMDE updated the task description. (Show Details)
lilients_WMDE moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2025-09-03-Salted-Caramel-Icecream board.
lilients_WMDE subscribed.
gerritbot added a comment.Sep 10 2025, 9:11 AM

Change #1186936 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] Connect LinearContextItem label to edit button

https://gerrit.wikimedia.org/r/1186936

gerritbot added a project: Patch-For-Review.Sep 10 2025, 9:11 AM
gerritbot added a comment.Sep 10 2025, 9:36 AM

Change #1186944 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[oojs/ui@master] Allow Enter key when there is only one SearchWidget result

https://gerrit.wikimedia.org/r/1186944

gerritbot added a comment.Sep 11 2025, 8:47 AM

Change #1187377 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Re-define tab key in the reference reuse search dialog

https://gerrit.wikimedia.org/r/1187377

thiemowmde added subscribers: thiemowmde, WMDE-Fisch.EditedSep 11 2025, 9:01 AM

I left a few suggestions in the document. Technical version:

  • We added a 2nd button to our ContextItem. But VE expects only 1 button. The 1st edit button can be activated with Enter. The code for this can be seen in ve.ce.LinearEnterKeyDownHandler.static.execute. Enter simply executes the reference command that is attached to ve.ce.MWReferenceNode. That command is a very trivial window → open command that opens the reference dialog a.k.a. ve.ui.MWReferenceDialog.
    • We would need an additional …KeyDownHandler in case we want the tab key to do something. It's unclear if this would conflict with existing code in VE.
    • We could make the command more complex and make it do different things, depending on the ContextItem and if it contains more than one button. But it's unclear if a command is able to interact with a ContextItem.
    • Similar, we make the command more complex so that Enter doesn't open the edit dialog directly but a tiny floating dropdown with only 2 items for the 2 buttons. Similar to the Ctrl+Shift+P dropdown in VE. Only keyboard users will see this.
    • Turns out the intended behavior is to use Ctrl+Shift+Enter to focus the ContextItem. Then tab can be used to go to the 2nd button.
  • Tabbing in the ref dialog Citoid popup makes it loose the focus completely, with no way back. This appears to be an upstream bug, as far as I can see. This is intended behavior because it's a ContextItem. While we can try to improve it, it's not a bug.

See the patches in this ticket for a few more minor suggestions.

gerritbot added a comment.Sep 11 2025, 9:34 AM

Change #1187377 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Re-define tab key in the reference reuse search dialog

https://gerrit.wikimedia.org/r/1187377

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.19; 2025-09-16).Sep 11 2025, 10:10 AM
WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2025-09-03-Salted-Caramel-Icecream board.Sep 15 2025, 8:46 AM
Tobi_WMDE_SW moved this task from Demo to Done on the WMDE-TechWish-Sprint-2025-09-03-Salted-Caramel-Icecream board.Sep 16 2025, 8:34 AM
thiemowmde closed this task as Resolved.Sep 16 2025, 9:17 AM

Investigation is done. The basic requirements are all fine. The open patches are optional convenience features, not strictly needed to call this done.

gerritbot added a comment.Sep 17 2025, 12:07 PM

Change #1189146 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] [POC] Easier to use focus trap in ContextItem popups

https://gerrit.wikimedia.org/r/1189146

gerritbot added a comment.Sep 18 2025, 9:39 AM

Change #1186936 abandoned by Thiemo Kreuz (WMDE):

[VisualEditor/VisualEditor@master] [POC] Connect LinearContextItem label to edit button

https://gerrit.wikimedia.org/r/1186936

gerritbot added a comment.Sep 18 2025, 10:54 PM

Change #1189593 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[VisualEditor/VisualEditor@master] Fix keyboard focus wraparound in custom window managers

https://gerrit.wikimedia.org/r/1189593

gerritbot added a comment.Sep 22 2025, 8:13 AM

Change #1190186 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Revert "Re-define tab key in the reference reuse search dialog"

https://gerrit.wikimedia.org/r/1190186

gerritbot added a comment.Sep 22 2025, 10:55 AM

Change #1189146 abandoned by Thiemo Kreuz (WMDE):

[VisualEditor/VisualEditor@master] [POC] Easier to use focus trap in ContextItem popups

Reason:

Obsolete thanks to I7c75f7f.

https://gerrit.wikimedia.org/r/1189146

gerritbot added a comment.Oct 2 2025, 11:46 AM

Change #1189593 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Fix keyboard focus wraparound in custom window managers

https://gerrit.wikimedia.org/r/1189593

gerritbot added a comment.Oct 2 2025, 7:06 PM

Change #1193184 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b1b8b872)

https://gerrit.wikimedia.org/r/1193184

gerritbot added a comment.Oct 2 2025, 7:40 PM

Change #1193184 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8b1b8b872)

https://gerrit.wikimedia.org/r/1193184

gerritbot added a comment.Oct 20 2025, 1:57 PM

Change #1190186 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Revert "Re-define tab key in the reference reuse search dialog"

https://gerrit.wikimedia.org/r/1190186

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.24; 2025-10-21); removed MW-1.45-notes (1.45.0-wmf.19; 2025-09-16).Oct 20 2025, 2:00 PM
gerritbot added a comment.Nov 28 2025, 3:15 PM

Change #1212598 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[oojs/ui@master] Add missing preventDefault to SearchWidget.onQueryKeydown

https://gerrit.wikimedia.org/r/1212598

gerritbot added a comment.Nov 28 2025, 3:34 PM

Change #1212602 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Highlight ref search result when there is only one

https://gerrit.wikimedia.org/r/1212602

gerritbot added a comment.Dec 16 2025, 10:27 PM

Change #1212598 merged by jenkins-bot:

[oojs/ui@master] Add missing preventDefault to SearchWidget.onQueryKeydown

https://gerrit.wikimedia.org/r/1212598

gerritbot added a comment.Dec 18 2025, 9:55 PM

Change #1219646 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.53.1

https://gerrit.wikimedia.org/r/1219646

gerritbot added a comment.Dec 18 2025, 11:37 PM

Change #1219646 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.53.1

https://gerrit.wikimedia.org/r/1219646

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits