Page MenuHomePhabricator

VisualEditor moves main content unexpectedly down to another reuse when details are added (unintended diff)
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Assume the following wikitext
<ref name="miller">Miller: main content is part of 1st occurence in text</ref>

Some content here

<ref name="miller"></ref>

Or create a ref, copy paste in VE and add details via the dialog.

Screenshot From 2025-09-03 12-13-59.png (615×797 px, 95 KB)

What happens?:

  • The main content of the reference moves into the second [1]

image.png (461×1 px, 58 KB)

What should have happened instead?:
The main content must stay where it was originally defined.

Notes:
  • There is no content loss but this behavior might be considered as a dirty diff by some wikitext editors
  • Unintended diff

There's another flavor of this issue. See T404089: VisualEditor moves main content unexpectedly up to another reuse when details are added (unintended diff). I suggest an additional more stable fix in there.

Event Timeline

Lina_Farid_WMDE renamed this task from VisualEditor moves main content away from its original place when a detail is created to VisualEditor moves main content away from its original place when a detail is created (unintended diff).Sep 3 2025, 12:42 PM
Lina_Farid_WMDE updated the task description. (Show Details)
WMDE-Fisch renamed this task from VisualEditor moves main content away from its original place when a detail is created (unintended diff) to VisualEditor moves main content unexpectedly down to another reuse when details are added (unintended diff).Sep 4 2025, 8:47 AM
WMDE-Fisch updated the task description. (Show Details)

Change #1185052 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Make sure main content always moves to the first sub-ref

https://gerrit.wikimedia.org/r/1185052

Change #1185085 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Use the actual ve.dm.InternalListNodeGroup class in tests

https://gerrit.wikimedia.org/r/1185085

Change #1185052 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Make sure main content moves to first sub-ref, if needed

https://gerrit.wikimedia.org/r/1185052

Change #1185085 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Use the actual ve.dm.InternalListNodeGroup class in tests

https://gerrit.wikimedia.org/r/1185085

WMDE-Fisch reopened this task as Open.
WMDE-Fisch closed this task as Resolved.