Page MenuHomePhabricator
Create Task
Maniphest T403621

Create MergeStrategy::SUM
Open, Needs TriagePublic
Actions

Description

The appendExtensionData/appendJsVars mechanism in ParserOutput needs a "counter" "sum" strategy which sums integers in order to handle usage counts, such as the one desired by Wikidata in the parent task.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ParserOutput: Implement MergeStrategy::SUMmediawiki/coremaster+117 -58
Bump wikimedia/parsoid to 0.22.0-a22mediawiki/vendormaster+477 -431
Switch ContentMetadataCollector strategy to an enumerationmediawiki/services/parsoidmaster+11 -25
Bump wikimedia/parsoid to 0.22.0-a21mediawiki/vendormaster+26 K -23 K
Rename MergeStrategy::COUNTER to MergeStrategy::SUMmediawiki/services/parsoidmaster+10 -10
Add enumeration for ParserOutput merge strategy from Parsoidmediawiki/coremaster+35 -26
Add MergeStrategy enumerationmediawiki/services/parsoidmaster+26 -0
Add MergeStrategy::COUNTER support to StubMetadataCollectormediawiki/services/parsoidmaster+63 -11
Bump wikimedia/parsoid to 0.22.0-a20mediawiki/vendormaster+2 K -1 K
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenReleaseNoneT84936 Release VisualEditor-MediaWiki as "1.0"
 OpenNoneT50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
 OpenNoneT54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
 OpenNoneT396539 Introduce a way to edit a span of text from within read mode
 OpenNoneT385558 Improve copy and paste from read mode to VE
 OpenNoneT174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
 OpenFeatureNoneT54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
 OpenNoneT55784 [EPIC] Use Parsoid HTML for all page views
 OpenNoneT272987 [EPIC] Parsoid read views for DiscussionTools
 OpenNoneT297840 Populate ParserCache with Parsoid output as a post-edit hook
 OpenNoneT393717 Put lints in ParserOutput/RefreshLinksJob
 OpenBUG REPORTNoneT393682 Wikifunctions fragments that trigger errors and try to put the page in a tracking category show it at the bottom of the view page, but the pages using the fragment do not appear on the category page
 OpenNoneT409815 SLI: MediaWiki system load
 OpenNoneT393716 [EPIC] RefreshLinksJob should use Parsoid-generated metadata
 OpenNoneT310511 Metadata comparison testing between Parsoid and the legacy parser
 OpenNoneT310512 Parsoid and the legacy parser should emit exactly the same ParserOutput metadata
 OpenNoneT402371 Client pages of Wikidata should be able to track their usage of WD data using Parsoid
 OpenNoneT403621 Create MergeStrategy::SUM
 OpenNoneT331483 Resolve differences between Parsoid & legacy parser TOC metadata output for template, extension, and parser-function generated content
 ResolvedcscottT213468 Parsoid section IDs don't correspond to PHP section IDs when headings are transcluded
 ResolvedABreault-WMFT215628 Make Parsoid and PHP edit-section numbering consistent when <noinclude> and <includeonly> are in use
 ResolvedcscottT214538 MediaWiki shouldn't assign section numbers during tokenization, but instead only when headings are generated
 OpencscottT359221 Parsoid's TOC handling needs to deal with HTML-returning components (exts, SPTs, parser funcs returning HTML) consistently
 ResolvedssastryT359450 Parsoid is not adding headings to TOC entries in some templated content scenarios
 ResolvedJgiannelosT402456 More Parsoid TOC edge cases?
 OpenJgiannelosT415554 From TOC difftesting (legacy/parsoid): Differences in template handling from sections
 OpenJgiannelosT415558 From TOC difftesting (legacy/parsoid): Mismatch when sections come from the same article
 OpenJgiannelosT415563 From TOC difftesting (legacy/parsoid): Inconsistent index level between legacy and parsoid
 OpenJgiannelosT415565 From TOC difftesting (legacy/parsoid): Section titles wrapped in html elements on parsoid
 ResolvedJgiannelosT403188 Implement TOC comparison in Linter extension

Event Timeline

cscott created this task.Sep 3 2025, 1:39 PM
Restricted Application edited projects, added Parsoid; removed Parsoid (Tracking). · View Herald TranscriptSep 3 2025, 1:39 PM
gerritbot added a comment.Sep 3 2025, 1:39 PM

Change #1184525 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Add MergeStrategy enumeration

https://gerrit.wikimedia.org/r/1184525

gerritbot added a project: Patch-For-Review.Sep 3 2025, 1:39 PM
Anomie unsubscribed.Sep 3 2025, 3:13 PM
gerritbot added a comment.Sep 3 2025, 6:31 PM

Change #1184525 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add MergeStrategy enumeration

https://gerrit.wikimedia.org/r/1184525

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2025, 7:30 PM
gerritbot added a comment.Sep 4 2025, 1:23 PM

Change #1184133 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Add enumeration for ParserOutput merge strategy from Parsoid

https://gerrit.wikimedia.org/r/1184133

gerritbot added a project: Patch-For-Review.Sep 4 2025, 1:23 PM

Change #1184148 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ParserOutput: Implement MergeStrategy::COUNTER

https://gerrit.wikimedia.org/r/1184148

gerritbot added a comment.Sep 4 2025, 1:23 PM

Change #1184779 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Add MergeStrategy::COUNTER support to StubMetadataCollector

https://gerrit.wikimedia.org/r/1184779

gerritbot added a comment.Sep 4 2025, 1:23 PM

Change #1184780 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Switch ContentMetadataCollector strategy to an enumeration

https://gerrit.wikimedia.org/r/1184780

MSantos added a project: Essential-Work.Sep 4 2025, 2:06 PM
MSantos moved this task from Backlog to Later on the Content-Transform-Team board.
MSantos moved this task from Needs Triage to Feature requests on the Parsoid board.Sep 4 2025, 2:18 PM
gerritbot added a comment.Sep 5 2025, 3:43 AM

Change #1184779 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add MergeStrategy::COUNTER support to StubMetadataCollector

https://gerrit.wikimedia.org/r/1184779

gerritbot added a comment.Sep 5 2025, 3:23 PM

Change #1185118 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a20

https://gerrit.wikimedia.org/r/1185118

gerritbot added a comment.Sep 5 2025, 3:56 PM

Change #1185118 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a20

https://gerrit.wikimedia.org/r/1185118

gerritbot added a comment.Sep 6 2025, 11:03 PM

Change #1185290 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Rename MergeStrategy::COUNTER to MergeStrategy::SUM

https://gerrit.wikimedia.org/r/1185290

cscott renamed this task from Create MergeStrategy::COUNTER to Create MergeStrategy::SUM.Sep 6 2025, 11:04 PM
cscott updated the task description. (Show Details)
cscott mentioned this in T354877: Track usage limits in ParserOutput (or elsewhere).
cscott mentioned this in T402371: Client pages of Wikidata should be able to track their usage of WD data using Parsoid.Sep 6 2025, 11:11 PM
gerritbot added a comment.Sep 8 2025, 5:44 PM

Change #1184133 merged by jenkins-bot:

[mediawiki/core@master] Add enumeration for ParserOutput merge strategy from Parsoid

https://gerrit.wikimedia.org/r/1184133

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.18; 2025-09-09).Sep 8 2025, 6:00 PM
gerritbot added a comment.Sep 9 2025, 10:26 PM

Change #1185290 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Rename MergeStrategy::COUNTER to MergeStrategy::SUM

https://gerrit.wikimedia.org/r/1185290

gerritbot added a comment.Sep 12 2025, 3:00 PM

Change #1187841 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a21

https://gerrit.wikimedia.org/r/1187841

gerritbot added a comment.Sep 12 2025, 3:44 PM

Change #1187841 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a21

https://gerrit.wikimedia.org/r/1187841

gerritbot added a comment.Sep 12 2025, 8:46 PM

Change #1184780 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Switch ContentMetadataCollector strategy to an enumeration

https://gerrit.wikimedia.org/r/1184780

gerritbot added a comment.Sep 15 2025, 4:42 PM

Change #1188397 had a related patch set uploaded (by OSleger; author: OSleger):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a22

https://gerrit.wikimedia.org/r/1188397

gerritbot added a comment.Sep 15 2025, 7:16 PM

Change #1188397 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a22

https://gerrit.wikimedia.org/r/1188397

gerritbot added a comment.Oct 25 2025, 11:53 PM

Change #1184148 merged by jenkins-bot:

[mediawiki/core@master] ParserOutput: Implement MergeStrategy::SUM

https://gerrit.wikimedia.org/r/1184148

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.25; 2025-10-28); removed MW-1.45-notes (1.45.0-wmf.18; 2025-09-09).Oct 26 2025, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 26 2025, 12:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits