Page MenuHomePhabricator

Endowment donations not included in "highest donation" totals?
Closed, ResolvedPublic

Description

A US donor in #1722132/CID 28354423 reached out confused about their donation history noted in a fundraising email. In the email we advised the donor that "Your highest contribution to us was $104‍ in 2024." However, under their same email address they actually donated $104 in April 2025, October 2024, and September 2023. The April 2025 donation was made to the endowment so we thought it was possible the donation made to the endowment was not being included when we're determining the highest donation made.

Panos shared the following in Slack:

"Having checked this CID's data in Acoustic, there seems to be a mismatch between some fields.
The fields in question for this are:
AF_highest_donation_date
endowment_highest_donation_date
both_funds_highest_donation_date

We employ both_funds_highest_donation_date to render that date dynamically. Its current value is 10/21/24.

However the value for endowment_highest_donation_date is 4/16/25. This shouldn't be the case though. The both_funds field should always reflect the most recent of the other two in my understanding."

Event Timeline

AMJohnson updated the task description. (Show Details)

Hi @Lars ! I'm wondering if I could put this phab on your radar if your bandwidth allows. The quoted section in the description should have enough information but happy to chat in more detail if you need.

@ppenloglou Yes, I actually just put this in our current sprint yesterday so plan to do this in the next two weeks.

@ppenloglou This is a specific edge case that our code did not account for where the donor has given exactly the same amount for their highest donation to the foundation and to the endowment and the endowment donation was more recent than the foundation donation. If the donation amounts were not exactly the same or the foundation donation was most recent, we would have the correct date in this field.

Fix incoming.

Change #1189929 had a related patch set uploaded (by Lars SG; author: Lars SG):

[wikimedia/fundraising/tools@master] Ensure both_funds_highest_donation_date is correct when the largest endowment and foundation donations are the same amount and the endowment is most recent.

https://gerrit.wikimedia.org/r/1189929

Change #1192952 had a related patch set uploaded (by Lars SG; author: Lars SG):

[wikimedia/fundraising/tools@master] Add latest direct mail appeal to Acoustic export

https://gerrit.wikimedia.org/r/1192952

Change #1189929 merged by jenkins-bot:

[wikimedia/fundraising/tools@master] Ensure both_funds_highest_donation_date is correct when the largest endowment and foundation donations are the same amount and the endowment is most recent.

https://gerrit.wikimedia.org/r/1189929

Change #1192952 had a related patch set uploaded (by Lars SG; author: Lars SG):

[wikimedia/fundraising/tools@master] Add latest direct mail appeal to Acoustic export

https://gerrit.wikimedia.org/r/1192952

Change #1192952 merged by Eileen:

[wikimedia/fundraising/tools@master] Add latest direct mail appeal to Acoustic export

https://gerrit.wikimedia.org/r/1192952

@ppenloglou This has been deployed and I've confirmed the affected cid is now correct.

You're the best, thank you so much @Lars !

XenoRyet set Final Story Points to 2.