Page MenuHomePhabricator

MobileFrontend should have an OWNERS.md
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

Currently many teams work in the MobileFrontend codebase. It's not clear which teams at WMF are accountable for issues with different parts of the code. An OWNERs.md would make this clearer and give teams more autonomy regarding changes.

User story

As a developer I want to know who to talk to when there are issues with the code.

Requirements

  • Should cover includes folder
  • Should cover frontend code
  • Should cover tests
  • Ownership should be enforced by a test

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

  • Add mockups and design requirements

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.2.0 of the Web team task template using phabulous

Event Timeline

Jdlrobson-WMF triaged this task as High priority.

Change #1186115 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] WIP: Define ownership in the MobileFrontend extension

https://gerrit.wikimedia.org/r/1186115

HSwan-WMF set the point value for this task to 2.Nov 5 2025, 5:47 PM
egardner added a subscriber: Jdlrobson.

I've made a few updates to the file that @Jdlrobson created here, and I've pinged the Editing and Reader Experience teams for their respective OK. Once I have those, we can finalize this and merge it.

Might it make sense to move files around according to feature/ownership, instead of grouping by RL module? e.g. an /editor folder that contains a /editor/init sub-folder containing editor-related files that are currently in /mobile.init/, and an editor/startup folder etc?

Might it make sense to move files around according to feature/ownership, instead of grouping by RL module? e.g. an /editor folder that contains a /editor/init sub-folder containing editor-related files that are currently in /mobile.init/, and an editor/startup folder etc?

I like this idea, but this might be a later thing (next few weeks). I'm still learning my way around MobileFrontend and want to be careful about re-arranging lots of files at once. Maybe we close out this immediate task and then I'll come back to improving some code organization to better reflect ownership in the near future. I'd also love to look into removing Webpack from more of this codebase, etc.

Change #1186115 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Define ownership in the MobileFrontend extension

https://gerrit.wikimedia.org/r/1186115