Page MenuHomePhabricator

ve.track module isn't loaded when launching 2017 editor on a page with discussiontools enabled
Closed, ResolvedPublicPRODUCTION ERROR

Description

Steps to replicate the issue (include links if applicable):

  • Visit a talk page
  • Launch the 2017 editor *dynamically* (i.e. not in a new tab, or by reloading. the page)

What happens?:

No EditAttemptStep or VisualEditorFeatureUse logging occurs, because the ve.track module isn't loaded, and thus ve.track isn't hooked up to mw.track.

What should have happened instead?:

Logging.

This is presumably somehow due to our reshuffling of modules -- it specifically started happening when we split the ve.track module back out from ve.core,utils in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1183154 to avoid OOUI being loaded with the init module.

Done

  • @MNeisler confirms we ARE logging events where feature = editCheck-tone in VisualEditorFeatureUse

Related Objects

Event Timeline

Restricted Application changed the subtype of this task from "Bug Report" to "Production Error". · View Herald TranscriptSep 4 2025, 3:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1184872 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Move ve.track.js into a separate module

https://gerrit.wikimedia.org/r/1184872

Change #1184872 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Move ve.track.js into a separate module

https://gerrit.wikimedia.org/r/1184872

DLynch added a project: Essential-Work.
DLynch moved this task from Inbox to QA on the Editing-team (Kanban Board) board.

QA:

  1. Make sure discussiontools and 2017 source editor are both enabled
  2. Visit a talk page
  3. Choose to "edit source"
  4. Verify that EditAttemptStep/VisualEditorFeatureUser events are being logged via the console / network tab

Change #1185179 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a5bd08c8b)

https://gerrit.wikimedia.org/r/1185179

Change #1185179 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a5bd08c8b)

https://gerrit.wikimedia.org/r/1185179

Change #1185970 had a related patch set uploaded (by DLynch; author: Esanders):

[VisualEditor/VisualEditor@wmf/1.45.0-wmf.17] Move ve.track.js into a separate module

https://gerrit.wikimedia.org/r/1185970

Both EditAttemptStep or VisualEditorFeatureUse events are being logged in the console:

Screenshot 2025-09-08 at 4.27.19 PM.png (1×2 px, 519 KB)

Screenshot 2025-09-08 at 4.27.36 PM.png (1×2 px, 555 KB)

Change #1185982 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.17] Update VE core submodule to master (a5bd08c8b)

https://gerrit.wikimedia.org/r/1185982

Change #1185982 abandoned by DLynch:

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.17] Update VE core submodule to master (a5bd08c8b)

Reason:

Would need to do the subrepo backport anyway

https://gerrit.wikimedia.org/r/1185982

Change #1185982 restored by DLynch:

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.17] Update VE core submodule to master (a5bd08c8b)

https://gerrit.wikimedia.org/r/1185982

Change #1185970 abandoned by DLynch:

[VisualEditor/VisualEditor@wmf/1.45.0-wmf.17] Move ve.track.js into a separate module

Reason:

Separate backport not needed

https://gerrit.wikimedia.org/r/1185970

Change #1185982 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.45.0-wmf.17] Update VE core submodule to master (a5bd08c8b)

https://gerrit.wikimedia.org/r/1185982

Mentioned in SAL (#wikimedia-operations) [2025-09-08T20:11:02Z] <kemayo@deploy1003> kemayo, esanders: Backport for [[gerrit:1185991|Enable DT thanks at mediawikiwiki (T400849)]], [[gerrit:1185982|Update VE core submodule to master (a5bd08c8b) (T302413 T391521 T397145 T401890 T402392 T397518 T402717 T403741 T403745)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-09-08T20:17:50Z] <kemayo@deploy1003> Finished scap sync-world: Backport for [[gerrit:1185991|Enable DT thanks at mediawikiwiki (T400849)]], [[gerrit:1185982|Update VE core submodule to master (a5bd08c8b) (T302413 T391521 T397145 T401890 T402392 T397518 T402717 T403741 T403745)]] (duration: 13m 05s)

I re-checked the events logged in VEFU following deployment of this fix and confirmed that we are now logging all expected tone check events as instrumented in T393818.

I re-checked the events logged in VEFU following deployment of this fix and confirmed that we are now logging all expected tone check events as instrumented in T393818.

Excellent; thank you for confirming, Megan.