Page MenuHomePhabricator

Drop PageViewInfo's integration with the Graph extension on action=info, the extension is dead
Closed, ResolvedPublic

Description

Perhaps it could be replaced by the Chart extension in future, but (a) that doesn't currently support inline data to specify a chart, and (b) shouldn't block the removal of the dead code.

Event Timeline

Change #1184869 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/PageViewInfo@master] Drop PageViewInfo's integration with the Graph extension on action=info, the extension is dead

https://gerrit.wikimedia.org/r/1184869

Change #1184873 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/extensions/PageViewInfo] Drop Graph dependency

https://gerrit.wikimedia.org/r/1184873

https://www.mediawiki.org/wiki/Extension:PageViewInfo probably wants some updating too..

Provides fancy looking graphs of Wikimedia page view data

Change #1184869 merged by jenkins-bot:

[mediawiki/extensions/PageViewInfo@master] Drop PageViewInfo's integration with the Graph extension on action=info, the extension is dead

https://gerrit.wikimedia.org/r/1184869

Change #1184873 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/PageViewInfo] Drop Graph dependency

https://gerrit.wikimedia.org/r/1184873

Change #1185108 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/extensions/PageViewInfo@wmf/1.45.0-wmf.17] Drop PageViewInfo's integration with the Graph extension on action=info, the extension is dead

https://gerrit.wikimedia.org/r/1185108

Change #1185108 merged by jenkins-bot:

[mediawiki/extensions/PageViewInfo@wmf/1.45.0-wmf.17] Drop PageViewInfo's integration with the Graph extension on action=info, the extension is dead

https://gerrit.wikimedia.org/r/1185108

Do we want to replace it with something? Adding some sort of graph e.g. with d3 (already used by various extensions) would be trivial.

I don't think is a good resolution, maybe we can use Charts instead ?

I don't think is a good resolution, maybe we can use Charts instead ?

I would open a separate ticket for that, as it would be a separate goal.

REL1_43 CI fail:

23:56:38 1) ResourcesTest::testValidDependencies
23:56:38 Dependencies that do not exist
23:56:38 Failed asserting that two arrays are equal.
23:56:38 --- Expected
23:56:38 +++ Actual
23:56:38 @@ @@
23:56:38  Array (
23:56:38      'ext.pageviewinfo' => Array (
23:56:38 +        0 => 'ext.graph.render'
23:56:38      )
23:56:38  )
23:56:38 
23:56:38 /workspace/src/tests/phpunit/structure/ResourcesTest.php:81

To solve:

CP: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageViewInfo/+/1185108
OR
Revert the revert of the revert: https://gerrit.wikimedia.org/r/c/integration/config/+/1185128

Cherry pick it to REL1_43 and REL1_44.

Change #1187869 had a related patch set uploaded (by Hslater; author: Jforrester):

[mediawiki/extensions/PageViewInfo@REL1_44] Drop PageViewInfo's integration with the Graph extension on action=info, the extension is dead

https://gerrit.wikimedia.org/r/1187869

Change #1187870 had a related patch set uploaded (by Hslater; author: Jforrester):

[mediawiki/extensions/PageViewInfo@REL1_43] Drop PageViewInfo's integration with the Graph extension on action=info, the extension is dead

https://gerrit.wikimedia.org/r/1187870

Change #1187870 merged by jenkins-bot:

[mediawiki/extensions/PageViewInfo@REL1_43] Drop PageViewInfo's integration with the Graph extension on action=info, the extension is dead

https://gerrit.wikimedia.org/r/1187870

Change #1187869 merged by jenkins-bot:

[mediawiki/extensions/PageViewInfo@REL1_44] Drop PageViewInfo's integration with the Graph extension on action=info, the extension is dead

https://gerrit.wikimedia.org/r/1187869

Change #1189210 had a related patch set uploaded (by Reedy; author: Jforrester):

[mediawiki/extensions/PageViewInfo@REL1_39] Drop PageViewInfo's integration with the Graph extension on action=info, the extension is dead

https://gerrit.wikimedia.org/r/1189210

Change #1189210 merged by jenkins-bot:

[mediawiki/extensions/PageViewInfo@REL1_39] Drop PageViewInfo's integration with the Graph extension on action=info, the extension is dead

https://gerrit.wikimedia.org/r/1189210