Page MenuHomePhabricator

Migrate parsoidtest1001 to PHP 8.3
Closed, ResolvedPublic

Description

Background:

With the upcoming migration of production MediaWiki to PHP 8.3 (T360995), we will need to upgrade parsoidtest1001 to facilitate the Content-Transform-Team's round-trip and one-off testing use cases on 8.3.

While we had initially planned to develop a k8s-based solution first (T386246), an "in-place" upgrade like that from the 8.1 migration is more realistic given the expected timeline, where production traffic-serving workloads begin migrating early in Q2.

From discussion with @cscott, it sounds like a good time to make the switch would before the production migration starts, but after we have we have fairly high confidence in 8.3 in general from ongoing testing in mw-debug. In the future, once there's a k8s-based solution available, we would like to be able to offer multi-version testing, where both PHP versions are available for testing Parsoid for the duration of the production migration (i.e., without a "cut over" date like we have here).

Procedure:

See T380485 for prior art from the PHP 8.1 migration earlier this calendar year. There are two parts to this:

Schedule:

We are tentatively targeting some time between 14:00 and 17:00 UTC on Tuesday, September 16th.

Event Timeline

Change #1184119 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/puppet@production] hieradata: migrate parsoidtest1001 to 8.3

https://gerrit.wikimedia.org/r/1184119

Change #1185185 had a related patch set uploaded (by Scott French; author: Scott French):

[mediawiki/services/parsoid@master] Update systemd unit names in testing scripts for PHP 8.3

https://gerrit.wikimedia.org/r/1185185

Change #1184119 merged by Scott French:

[operations/puppet@production] hieradata: migrate parsoidtest1001 to 8.3

https://gerrit.wikimedia.org/r/1184119

With some basic smoke testing after the upgrade to 8.3 (e.g., via curl and parse.php), parsoidtest1001 seems to be operating as expected.

I'm now waiting for the update to systemd unit names to merge, after which we should be in a good spot for RT testing to resume.

Change #1185185 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Update systemd unit names in testing scripts for PHP 8.3

https://gerrit.wikimedia.org/r/1185185

Many thanks to @cscott for starting a new RT test run to validate parsoidtest1001 post-upgrade, which seems to have completed without issue.

Together with the fact that logging appears to be working as expected (we ran into trouble with this during the 8.1 migration), I believe we're done here.

Change #1190321 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a24

https://gerrit.wikimedia.org/r/1190321

Change #1190321 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.22.0-a24

https://gerrit.wikimedia.org/r/1190321