Page MenuHomePhabricator

FileImporter marks all imported edits as minor edits
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Import a file from another wiki using FileImporter.

What happens?: All imported edits are marked as minor edits, regardless of whether the corresponding edit on the original wiki was minor or not.

What should have happened instead?: Only edits that were minor on the original wiki should be imported as minor edits.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
View the history of any page logged at https://commons.wikimedia.org/wiki/Special:Log/import, and you will see some instances of this bug.

Event Timeline

Change #1188371 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Stop marking all imported revisions as minor

https://gerrit.wikimedia.org/r/1188371

Change #1188372 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Avoid array_key_exists for best formatversion compatibility

https://gerrit.wikimedia.org/r/1188372

thiemowmde added a subscriber: Lina_Farid_WMDE.

Thanks a lot for the report! It looks like this is happening for a surprisingly long time, but was never reported. Luckily it's mostly confusing and only a very, very minor data-loss issue.

Change #1188371 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Stop marking all imported revisions as minor

https://gerrit.wikimedia.org/r/1188371

Change #1188372 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Avoid array_key_exists for best formatversion compatibility

https://gerrit.wikimedia.org/r/1188372