Page MenuHomePhabricator
Create Task
Maniphest T403911

CommunityRequests has an undeclared dependency on WikimediaMessages
Closed, ResolvedPublicBUG REPORT
Actions

Description

The wikimedia-copyrightwarning message is used from WikimediaMessages, but that extension isn't a dependency of CommunityRequets. This causes ResourcesTest to fail when WikimediaMessages isn't installed:

 ./vendor/bin/phpunit tests/phpunit/structure/ResourcesTest.php --filter testMissingMessages
Using PHP 8.3.6
Running with MediaWiki settings because there might be integration tests
PHPUnit 9.6.21 by Sebastian Bergmann and contributors.

F                                                                   1 / 1 (100%)

Time: 00:00.753, Memory: 70.50 MB

There was 1 failure:

1) ResourcesTest::testMissingMessages
Message 'wikimedia-copyrightwarning' required by 'ext.communityrequests.intake' must exist
Failed asserting that false is true.

mediawiki/tests/phpunit/structure/ResourcesTest.php:119

To fix this, a new message should be added, called communityrequests-copyrightwarning, which can then be overridden in the ResourceLoader factory in AbstractWishlistSpecialPage if WikimediaMessages is installed.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Load copyright warning message in the backendmediawiki/extensions/CommunityRequestsmaster+28 -9
Update AbstractRenderer to implement MessageLocalizermediawiki/extensions/CommunityRequestsmaster+5 -11
Update Jest's mockMwConfigGet to be called multiple timesmediawiki/extensions/CommunityRequestsmaster+20 -12
Customize query in gerrit

Related Objects

Event Timeline

Samwilson created this task.Sep 7 2025, 11:49 AM
Restricted Application added a project: Community-Tech. · View Herald TranscriptSep 7 2025, 11:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwilson renamed this task from Remove dependency on WikimediaMessages to CommunityRequests has an undeclared dependency on WikimediaMessages.Sep 7 2025, 11:50 AM
Samwilson changed the subtype of this task from "Task" to "Bug Report".
Samwilson mentioned this in T402673: Add copyright warning to voting dialog.
Samwilson claimed this task.Sep 8 2025, 3:24 AM
Samwilson edited projects, added Community-Tech (Sea Lion Squad); removed Community-Tech.
Samwilson moved this task from Backlog - groomed to In Development on the Community-Tech (Sea Lion Squad) board.
gerritbot added a comment.Sep 8 2025, 3:45 AM

Change #1185515 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/CommunityRequests@master] Load copyright warning message in the backend

https://gerrit.wikimedia.org/r/1185515

gerritbot added a project: Patch-For-Review.Sep 8 2025, 3:45 AM
gerritbot added a comment.Sep 8 2025, 10:29 AM

Change #1185878 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/CommunityRequests@master] Update AbstractRenderer to implement MessageLocalizer

https://gerrit.wikimedia.org/r/1185878

gerritbot added a comment.Sep 8 2025, 10:36 AM

Change #1185880 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/CommunityRequests@master] Update Jest's mockMwConfigGet to be called multiple times

https://gerrit.wikimedia.org/r/1185880

gerritbot added a comment.Sep 8 2025, 12:59 PM

Change #1185880 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] Update Jest's mockMwConfigGet to be called multiple times

https://gerrit.wikimedia.org/r/1185880

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.18; 2025-09-09).Sep 8 2025, 1:00 PM
Samwilson mentioned this in rECOR7a82f0d6ecc5: Update Jest's mockMwConfigGet to be called multiple times.Sep 8 2025, 1:00 PM
gerritbot added a comment.Sep 9 2025, 12:30 AM

Change #1185878 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] Update AbstractRenderer to implement MessageLocalizer

https://gerrit.wikimedia.org/r/1185878

jenkins-bot mentioned this in rECOR5fc30c90a3fa: Update AbstractRenderer to implement MessageLocalizer.Sep 9 2025, 12:31 AM
ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.19; 2025-09-16); removed MW-1.45-notes (1.45.0-wmf.18; 2025-09-09).Sep 9 2025, 1:00 AM
Samwilson moved this task from In Development to Feedback and Review on the Community-Tech (Sea Lion Squad) board.Sep 10 2025, 12:45 AM
Samwilson triaged this task as Medium priority.Sep 10 2025, 10:50 AM
gerritbot added a comment.Sep 10 2025, 7:49 PM

Change #1185515 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] Load copyright warning message in the backend

https://gerrit.wikimedia.org/r/1185515

jenkins-bot mentioned this in rECOReb1cfccec0ef: Load copyright warning message in the backend.Sep 10 2025, 7:51 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 10 2025, 8:32 PM
Samwilson moved this task from Feedback and Review to QA on the Community-Tech (Sea Lion Squad) board.Sep 11 2025, 12:00 AM

QA notes: in addition to the test command above now working, the other way to QA this is to check that the correct copyright notice is shown even when WikimediaMessages is not installed.

• MusikAnimal closed this task as Resolved.Sep 18 2025, 5:07 PM
• MusikAnimal subscribed.

FYI George is very overworked as he is covering multiple teams. I see this kind of task as more of an engineer-y thing that doesn't really need QA expertise. All that is entailed is verifying a message is shown with WikimediaMessages disabled, and us engineers can do that :-P

Closing as resolved!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits